From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63783C00144 for ; Tue, 26 Jul 2022 21:03:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C5084900002; Tue, 26 Jul 2022 17:03:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BFF818E0001; Tue, 26 Jul 2022 17:03:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A9F1C900002; Tue, 26 Jul 2022 17:03:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 972368E0001 for ; Tue, 26 Jul 2022 17:03:22 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 6C19F160A1C for ; Tue, 26 Jul 2022 21:03:22 +0000 (UTC) X-FDA: 79730476644.26.DD68770 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2063.outbound.protection.outlook.com [40.107.237.63]) by imf26.hostedemail.com (Postfix) with ESMTP id BAB9414009E for ; Tue, 26 Jul 2022 21:03:21 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DhibXZtFhqx74/tH6jJwWk2YKna6ZQHBj7xCdzoVqaTh0PfGceLDHhKBa5av0wiNwKvmt09YvsDtcdslY4yojuHEZH0N7Hvxbt2ggXFRuOF+/xDQzi6/8FuKvx4iwR0lDjvBMrNc+69TXAukxR4hMbL0b6vWgmDa4d169KtD8u5mZVOMNw8Ee1YJA9WPO29EAxz6imwPGd6RpWI9J6PS5uxQsGYClMFGNa3pC2ZzxcHF3f42afAZsOHX/JSoTNQVY4A3AadZhL5cQi8KlB12QhY4+IlkXMMFP1JMPAxcMzFClgwRTo+Cycm6cVO7HpU8Xh3d+8w+MSNovQrVO0h/8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bhx/KwlD8SBSDafxMW1A/PGMQZ7LmfsWtHiSkCfKias=; b=OuRg7kibnnQG68X5JCjYKhSxFaBPZVtg3R78O1/mQ745xDQclN3Ftu4EBw1tDcpgwYyVxkPHoB78jSJMxMFvC4c5Ezz4wMAlXEpaAl12OYhB8FNg7aDsNMZMj473iJH+vE+FMy3qrml9tynI5JFFF7S8Ep7t3/cIdrmCWCbCVcIJECaMCO4YeW7E2gN0s8hcTYHvNLalJO6VNyfX523FPzCwYHZLIJCed0P+T0xLTNIOvQTN4+lK+FHm33tXy4cr4lmCIz0hIOoNzsbxArdNoyYr8TjmAUjNcu8OhChPig2UMm9RH+rNdfNlpC2096KblVIHxpqpkzo30jxHS7y4Ag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bhx/KwlD8SBSDafxMW1A/PGMQZ7LmfsWtHiSkCfKias=; b=gye4OGtYHR12xTFz8RcxZUlS0TFuBdL681RNs0xGHbMZzeGuAROfuT53cHBgDHEbc4rxUbTzfndi15uKfQJ0IiXXSukWPg4hlwOTPb3HghiD0zNxDKKhCrig47s2r/S3PGC1VeAafN947kfXBfdESlyyfh9E7yzwpP4w7NpTmQxuNvpuMO504aIJDKNp4qrHb77YXMaTii7fJ7wyaGOnaPexowYZBLqid7/0P6QgtNapjbwFiojHgtWkGNRb4ysR9DcLdoU0/cXz2koNJdn+XymG3ywEjt5IqGquWM1DCQUmbQUQB9JcwJpUfGE1TI5LjY6YQs/A13MM2NarlkrBrA== Received: from BY5PR12MB4130.namprd12.prod.outlook.com (2603:10b6:a03:20b::16) by BN8PR12MB2930.namprd12.prod.outlook.com (2603:10b6:408:69::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.18; Tue, 26 Jul 2022 21:03:19 +0000 Received: from BY5PR12MB4130.namprd12.prod.outlook.com ([fe80::ad32:9c8c:9142:df53]) by BY5PR12MB4130.namprd12.prod.outlook.com ([fe80::ad32:9c8c:9142:df53%4]) with mapi id 15.20.5458.025; Tue, 26 Jul 2022 21:03:19 +0000 Message-ID: <299fdf08-0d88-6361-c9ec-07ce52395212@nvidia.com> Date: Tue, 26 Jul 2022 14:03:16 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 2/2] mm/hmm: add a test for cross device private faults Content-Language: en-US To: Ralph Campbell , linux-mm@kvack.org Cc: Felix Kuehling , Philip Yang , Alistair Popple , Jason Gunthorpe , Andrew Morton References: <20220725183615.4118795-1-rcampbell@nvidia.com> <20220725183615.4118795-3-rcampbell@nvidia.com> From: John Hubbard In-Reply-To: <20220725183615.4118795-3-rcampbell@nvidia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SJ0PR03CA0062.namprd03.prod.outlook.com (2603:10b6:a03:331::7) To BY5PR12MB4130.namprd12.prod.outlook.com (2603:10b6:a03:20b::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6df0c0ae-3270-46fd-76d4-08da6f4a4435 X-MS-TrafficTypeDiagnostic: BN8PR12MB2930:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qmVRUIpbgDdgVWc2D6U2FQe6gHzmOnAAcmXDnvxJYgjEyzjQdwj5QT0LcJs5P21lxWcBSW2IZfewc1c0VQAkeLO2pmvnfxqAWxk4wDPW9SUas4CTYOWRFP6mTYgK4rE3jpRSvcV5A6FXmBjeTn2+U3fZTS/yywy03/zKZydOHGku6qVcBbvjtWkDWBjg4HmAeZ3usOIDnDNicP2umR+moMztgHr2VNNBVNr6mJHWOSmPONNVELatqud+IfAGbOsebmUY6eGACX6eJ/dk2J47MiaMqETsoCJ6muyD6Jsk7AyGHM8hqB94Kss/axMtgPzaBLKC21whGbZ+N2xD/4VjrxQfJ22miv79LfEdJ0WhrduvN+a+xndSpoyoVgPOQ5/2LRaFHvRCfbEHaYiENUkjImHUb7IP+BI1UY0JBPSPoOq/9Y/rM2VW9haF3ZwnkSex9sx3M9hq1HHW8NyFBTeaEoEQKqBM7aSkKEOS05ZAS7v4XmzHXibSYlQ+6phKB3rjctl4/VCUbwjT4IlmrJvUnmVQMVgSl4o/HRjwwV1lU3c10c270IyhsxJuj4wDBFn2VNSzcSUPtk0f3dX6aat+lbNK7bmg0PidrnUbCG4L/4BBQwaiy2p35AUdv7fOPirYuADz2wgVVptY6Rm4SzTW5aIqrbpqyYagsRGU6R9NalBJnI3l9n0x6TlLtTbw3Jf8vz4nce6VsS4U23cYo5+x3vuf+IIrM0vESiejftNjgjffifED6UDQ59yDuhM8PG8CRxMol96mFffqKAxA82JYoVwv/fO+Y0AR/8y3aVICAXW7u8hTdBjaA6vDU5hf16KH4SLcZogtxjZzEGiOCcR6+w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY5PR12MB4130.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(346002)(396003)(136003)(376002)(366004)(39860400002)(31696002)(2616005)(38100700002)(53546011)(6486002)(6506007)(6512007)(26005)(86362001)(478600001)(6666004)(2906002)(5660300002)(41300700001)(31686004)(186003)(83380400001)(8936002)(66946007)(316002)(36756003)(8676002)(54906003)(4326008)(66476007)(66556008)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZXJpSHJYMEh3WjJRWE9JWDVPTVlyNktuYmVVMDNpblNQVEpOTGRVWDIxQXpP?= =?utf-8?B?czR4d3RDdnFmdEdBSDA0L0JmanE0OVNaenlVWTFvc0JlRHB3bVpiZUxPVmdq?= =?utf-8?B?T0JpK2xwOUlkdFQ0UnNMQzQrZW5IdVF6bTE5ZjZTV1cxakwzdXpMb2pKYmlI?= =?utf-8?B?U3B6dUlUNEZ5em1OWjFSbVh0NkVzRUVqc3hyYk52VFBGVE40bXViYmJubjdN?= =?utf-8?B?Zmp4WXFpT2FvczJkbHhsVWgzS29tcE5CU0VZSGVUMFQrZ096UVRNUkVkUWR1?= =?utf-8?B?Y2JNOG1vMW9SOENnUHlKWWhiVXBHMEFseENjVno4TUVFZnpNSUxONHF2eklu?= =?utf-8?B?UlhQaDlTTlBDK3NxbU1QOUJMWmJCaE5CMEM3akZUUG9SNTRBYnRxY1ZTc3pq?= =?utf-8?B?RjhkdEtXM0pHTXgzMFI3RHFnNFN3dmtFT21RMWJIM3I1a2tnekJmYW9Lalh5?= =?utf-8?B?YlFaR1dJVEQ4dldYZllXN0RDL0MweWd4d1BES1V5blV2Vy8yMkFmblYva0hM?= =?utf-8?B?R1o3SSt3TWtjZnhtbkpsMHd4R3QzNDg1aFN6bkVLYXNmU1NCemN0dHZPR2Fz?= =?utf-8?B?R3ZoZjFHQlJMdXkwSGFxRmdNNE5sUkdXMkRRWUlUQUh1cFUrWlRkRnhwTTBr?= =?utf-8?B?UUNzYWdNbWJhcVJtbTd1RkprMnFGbWpKZnMxazR5dmVjc3JOK0pPd3ZrTzNH?= =?utf-8?B?TDU0YzExMG1jSzdoNGpaL1E2WjFDWEtGaGJrMXBHMlg0a0oyTkUrZHp1R09G?= =?utf-8?B?eUV3QUxveENQbEVtNEVCQkZyMGo4clpzcnhZUmErR09NRGcvN2xrMUkyTkNU?= =?utf-8?B?Q04xZlVnd2tCVi9VaFFRWHh4NFJkRXVvdGVHL0dQQ1ZmQjVVSlN4OSsrK2pO?= =?utf-8?B?Tk9BaEFUbk1DZVlsbGFjQlB0U1hvUUN2ME5MczlXOUtpYnFrV293MXdsTFdu?= =?utf-8?B?dTJSMzNaNEN2Vm9ZVWRQdkxUdThnSXNrbGdxNlhqZno0K3VBaG1GTStQb1Rr?= =?utf-8?B?NkJUYStDdnZoWkYyWW1Yd0poTWtsOUNqU0FtMWNjVzFFZFFkS1JnVGJQZVRZ?= =?utf-8?B?RllDTjRuaTUzTytvZ1l2MzI1QlpnZmhHWTBSWWFjNHNBR3lwVGRyYWM1bDND?= =?utf-8?B?ZnNzaFNSMDJ6RzdkTVEvVGFFOGtXTFZORFloNllzbXRLdEhsMW9nZmZFelA0?= =?utf-8?B?NEZtSXFVaUx4NE9zUFBFRmR6UTJCcmJ4NGlnWE9SR0lMOTVMTHM2SVZ1RVVF?= =?utf-8?B?VnZPRXR1ZjJYM05SL1RCTExDS2JoTUxGRUNUKzNkck1hZVNBOG5Md0VqdzYw?= =?utf-8?B?QTNlcUlVTER6SU4vY0FRV0w1NVI3NndKQjhOWWRSYWpza0VMTUNhMHlJUEt3?= =?utf-8?B?WC9JUGRlRjhmTVVIajdiR0JYRU9yRXZnVnBWS2ZQRWtVaktxMWk3YUI3bWFP?= =?utf-8?B?aitCTExwQTZ4MEFzZHQ4eDNVS2dlWVVodFg5L0xyV2h2QitFYzR5eTZWR0pC?= =?utf-8?B?WTNDdllKNVQ5UG5QWEM1Q1VvejFwRTYwdXdtWGhrRjNrcHpYY29acUVwY3Rp?= =?utf-8?B?M1FDeWV6YkhHVmpDZVVJaWYyNm5TS1B0V25YK3BwNGtsdzFqUGRJVjlXZVhz?= =?utf-8?B?d3VieG0zelJWeksvb29MUGNxenpoY3BtUndWWEw5KzlLUGd4RkJRcXRsdkFX?= =?utf-8?B?UnQ1eHZIWW1zblB2U0xDNVNWYlpPR3Z2TFErRkkxNG5rQTZ5N2Jvc0MyZ2tW?= =?utf-8?B?WjdpOUZRYzRPZDhoSnVlMFMrZ1dPN2Q5ZWxuejV4a1gxbG1tMERIRitUK0VQ?= =?utf-8?B?YVlLUWJOSFNPRVp1cTlHalNsS1JkRStRN0FaTjhTRkdyNlNqNWdnYkxnbFVp?= =?utf-8?B?bVlTYzlQU1M1cEdUNUY0cExsWituVWtaM2JCWWRMR2pINEhITU92OGE3K2tQ?= =?utf-8?B?YmhYT3gvRDFvRDVTYWNGTFZZREY1Y1B4YjFzSFhueWNzZ1FBN1J1dGtDNVJa?= =?utf-8?B?M0VLUWhTSkx1T3NPZFBBWjNhSnkzbnVQbjlLZjdnZk9SdTBCdFdjb3VHUjhL?= =?utf-8?B?cG56ZTZteW5wVHQyckZnZVJNTmFtam5hT1ZSaEtSMFpQMUxlc0FVZVFkSDl1?= =?utf-8?Q?ULBKqWG0FB0fR6V+dXuub7jDB?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6df0c0ae-3270-46fd-76d4-08da6f4a4435 X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4130.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2022 21:03:19.1150 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 84ABWEsfjlJWPaCneJ7hWkApPpMzhkL3dR/628PFjNtx5NkdQXidins84m6s5Qhq3iCqgZeYpz4Fiwnm3ENhnA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR12MB2930 ARC-Authentication-Results: i=2; imf26.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=gye4OGtY; spf=pass (imf26.hostedemail.com: domain of jhubbard@nvidia.com designates 40.107.237.63 as permitted sender) smtp.mailfrom=jhubbard@nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=reject) header.from=nvidia.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1658869401; a=rsa-sha256; cv=pass; b=eGfhTPk7qKC0MH7nww6h95vMwgJn/QDxo/FDZToiJxkdZz0vNH2QMUBN4+aTFentA5pWcl 5YKbKKhN9W/HHSV4FtlMXTuJgWvQiUViEPD/22j44wfbEOeQiqYHkwDxgiGTqAK2z+bbma pjdC1E6DZcUWrgktt8KJbA1k2vQuO8o= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1658869401; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bhx/KwlD8SBSDafxMW1A/PGMQZ7LmfsWtHiSkCfKias=; b=jlyqfngW0v0yquncgWBeQ49IBpRMz8UwLicNVlVn7baj2oqimhuTFXyUK1S6Z9iiRSAorG 9qTUm45+kxupe1UF3pIxzU+155vk/Lk0AhHeDaxzeD4kSMNM8OlVqL9NAgBGM13cTB8JRW nxH573bFBO4T/pEC20P19pgraWkSelI= Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=gye4OGtY; spf=pass (imf26.hostedemail.com: domain of jhubbard@nvidia.com designates 40.107.237.63 as permitted sender) smtp.mailfrom=jhubbard@nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=reject) header.from=nvidia.com X-Rspam-User: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: BAB9414009E X-Stat-Signature: 6ecqmz7us4mxh1qyqm1ahkftkao5w6iy X-HE-Tag: 1658869401-848682 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 7/25/22 11:36, Ralph Campbell wrote: > Add a simple test case for when hmm_range_fault() is called with the > HMM_PFN_REQ_FAULT flag and a device private PTE is found for a device > other than the hmm_range::dev_private_owner. This should cause the > page to be faulted back to system memory from the other device and the > PFN returned in the output array. > > Signed-off-by: Ralph Campbell > --- > tools/testing/selftests/vm/hmm-tests.c | 14 ++++++++++++-- > 1 file changed, 12 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/vm/hmm-tests.c b/tools/testing/selftests/vm/hmm-tests.c > index 203323967b50..a5ce7cc2e7aa 100644 > --- a/tools/testing/selftests/vm/hmm-tests.c > +++ b/tools/testing/selftests/vm/hmm-tests.c > @@ -1520,9 +1520,19 @@ TEST_F(hmm2, double_map) > for (i = 0, ptr = buffer->mirror; i < size / sizeof(*ptr); ++i) > ASSERT_EQ(ptr[i], i); > > - /* Punch a hole after the first page address. */ > - ret = munmap(buffer->ptr + self->page_size, self->page_size); If this removal was intentional, then it should be mentioned in the commit log. > + /* Migrate pages to device 1 and try to read from device 0. */ > + ret = hmm_dmirror_cmd(self->fd1, HMM_DMIRROR_MIGRATE, buffer, npages); > + ASSERT_EQ(ret, 0); > + ASSERT_EQ(buffer->cpages, npages); > + > + ret = hmm_dmirror_cmd(self->fd0, HMM_DMIRROR_READ, buffer, npages); > ASSERT_EQ(ret, 0); > + ASSERT_EQ(buffer->cpages, npages); > + ASSERT_EQ(buffer->faults, 1); > + > + /* Check what device 0 read. */ > + for (i = 0, ptr = buffer->mirror; i < size / sizeof(*ptr); ++i) > + ASSERT_EQ(ptr[i], i); I'm assuming that your testing shows that this fails without patch 1, and succeeds with patch 1 applied? Apologies for such an obvious question... :) > > hmm_buffer_free(buffer); > } thanks, -- John Hubbard NVIDIA