From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D9D1C3DA6D for ; Fri, 23 May 2025 03:56:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B69E96B0099; Thu, 22 May 2025 23:56:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B1AE26B009A; Thu, 22 May 2025 23:56:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A32D06B009C; Thu, 22 May 2025 23:56:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 836B76B0099 for ; Thu, 22 May 2025 23:56:58 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 29D835F728 for ; Fri, 23 May 2025 03:56:58 +0000 (UTC) X-FDA: 83472811716.01.133BACE Received: from out-173.mta1.migadu.com (out-173.mta1.migadu.com [95.215.58.173]) by imf28.hostedemail.com (Postfix) with ESMTP id 3D869C0005 for ; Fri, 23 May 2025 03:56:56 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=S9OzoP15; spf=pass (imf28.hostedemail.com: domain of muchun.song@linux.dev designates 95.215.58.173 as permitted sender) smtp.mailfrom=muchun.song@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747972616; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=u6qNdPv7J8gfgypOptH2B2wxSfGN00CcXcZhVQxMpKw=; b=Ca2Csud5Zqev1hBdV300+TI/XWVOO+GzwPZFEpYuXHInMamfd6eRGF5B3NW1z1lneMopI7 AcrLWsdVIxyrT+y2QSsRRzviVV4pSRB6exsXhBOY0nbm1yqCl1oK/LwBZCDy7JfMy7W7pV 3UDeN5S+qABaXaT5ztSgdf3OoCX+wGQ= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=S9OzoP15; spf=pass (imf28.hostedemail.com: domain of muchun.song@linux.dev designates 95.215.58.173 as permitted sender) smtp.mailfrom=muchun.song@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747972616; a=rsa-sha256; cv=none; b=2a4HMh38/pE3B7D0y+DOwd0LiP1746iVL8jWg9CAYTmgznykP05uWMFCIygtgvh/WwLGSq u4ytyeETfk7zZt20QhKCWSjETo/DoxPWbOSI2/nAaHMAnheae2hCGBiOi8dwVD8l3cyX+k qKZ+3JE9cMqQjWEKpWnI6IU3O/LuLz4= Content-Type: text/plain; charset=utf-8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1747972614; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=u6qNdPv7J8gfgypOptH2B2wxSfGN00CcXcZhVQxMpKw=; b=S9OzoP15OwVpDAPDuHOpq6gcuxnTztYLM95nwFD4B9AK0NZwuCkeMbRE0EBh8cROyAudfN T88Cj2bQRKe0iodB9Lo34vZXtKv8Zoa2alqS/LtQ+5NS4kLuvg4xwkpuyC996wzkPdrQ1s DL+c8yhMEtO6U1+kbnDaI1lCJxj1EMM= Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.500.181.1.5\)) Subject: Re: [PATCH] mm/hugetlb: fix kernel NULL pointer dereference when replacing free hugetlb folios X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: <4e408146-7c77-4f6d-90e8-bb311d7ab53d@126.com> Date: Fri, 23 May 2025 11:56:11 +0800 Cc: Oscar Salvador , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, 21cnbao@gmail.com, david@redhat.com, baolin.wang@linux.alibaba.com, liuzixing@hygon.cn Content-Transfer-Encoding: quoted-printable Message-Id: <299A777D-DC94-4724-BAD7-DD02F7CDBAFA@linux.dev> References: <1747884137-26685-1-git-send-email-yangge1116@126.com> <644FF836-9DC7-42B4-BACE-C433E637B885@linux.dev> <3B8641A1-5345-44A5-B610-9BCBC980493D@linux.dev> <4e408146-7c77-4f6d-90e8-bb311d7ab53d@126.com> To: Ge Yang X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 3D869C0005 X-Stat-Signature: w4g3qdh4ndidbjpg3dfnwjcidtiirjy7 X-Rspam-User: X-HE-Tag: 1747972616-290346 X-HE-Meta: U2FsdGVkX1+OsLzrMjful7skYgIhoPZyp5t7VBDnDyk/yjZxxi3FuH0B/BIDi9LGJaVCxIH0hakEKDwGCsLBbWFLroofuiD7sNadJ1X2dNzSV5bmPsljp0NPyu7sTzkYXhYao5r4weAcZR2MVvor2Z59DLGCpZ57fYIYUhxxW+P7f9ZrprSAycCimnw+F0vFsGaUNmiObgNNzvlgSFjFgsCBhIg4kc1BtAraK3rRvmjFWs4ualtgujt2je16+SB59GH9QBKL5qumYMlD1JloNAJXc1KIkBG2rPiMUNNDc5Icspg4s5ykCKOXiqTNmLmF/hiYduFjR4z0dvLSyYzQrHHXgRnIFuJ9E8eFkm9GvxEcpmpq1BRXUB6Fq9U8dWSJHrFtRW8re19mVqUaRCdRRmGQzVpP+n2Uykztvjxe3+tklRpzTgYWeFMHZNb6EBUN54ZfMConHvShBDZoDAnLQM4EDzsZMIwWFZtJ291Lx/n8nQOTrfgqKirrufrBLkVtZS5so8xAGc6U95lELriLdqr6j0x2lQHROAHEbHXiTCslDILfDMev7uAy9aXmhoD51wRbVioGyZ4ciJa/49Cf2OMEg8iTPTHccucUMJkr5FgrB6SII0UbyKxAdupT8VN21LsrRhBuBRDl6qnTmocGkByVYyIYHjQtZlY48K2Y1D0Qix4Bn5GdoD801Sp6YMlQs4AG2GybrWiR7BZr30pmP/ApOtw76zCym2QOi5fnqLrcG29JxiEgj33dUkjx7mAJelPbNuU0Vb7bivgZRF46stQ1equwozZP4I9TYOr/rn4RrH5mIq4TQOsnSbrZguD5SvV2VU+IcnP/bzdMtnZQrEyuiszH7p7Yr9oxMf/Y5Kq2BICH0p/3Wg6saWCx9l2TU5sesdIvPKaF3oGldvkR4EJshSTb04ktixoafZD37lIkW+bC4KHQ1J3ipXYcxwqQ95KH9lCiJgkO/UOsACO bgfzN3HI WlBVNzIL1NmsjOSn66u7lQzWf5AeGfs3GoEYNPamB+hZPGzAIAZyi3KoSbhu1xpqZ/q5gOINxhbovXJJr9tzHQrAHYuSEkHoDU8olYHsez2Hey4N6WeLZTO4LuEaK4srSNyrykCsEF8TUKaU3I7yAgvMSD4G99UPuP9Yp9NEabcF2k6Agg7f+ulZIb7eCYSv55IusziEXieahjiyOqt1M9JHXZUoh4mc3TZe/UqVBt7pCL742his0l1Uh8UtLDhi130c4QLPEU5yV3YPRqiAyDaFAPGYoaFyWb27P7uWanaqXN5wycoxDbfEIrQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > On May 23, 2025, at 11:46, Ge Yang wrote: >=20 >=20 >=20 > =E5=9C=A8 2025/5/23 11:27, Muchun Song =E5=86=99=E9=81=93: >>> On May 23, 2025, at 03:32, Oscar Salvador wrote: >>>=20 >>> On Thu, May 22, 2025 at 08:39:39PM +0800, Muchun Song wrote: >>>> But I think we could use "folio_order() > MAX_PAGE_ORDER" to = replace the check >>>> of hstate_is_gigantic(), right? Then ee could remove the first = parameter of hstate >>>> from alloc_and_dissolve_hugetlb_folio() and obtain hstate in it. >>>=20 >>> Yes, I think we can do that. >>> So something like the following (compily-tested only) maybe? >>>=20 >>> =46rom d7199339e905f83b54d22849e8f21f631916ce94 Mon Sep 17 00:00:00 = 2001 >>> From: Oscar Salvador >>> Date: Thu, 22 May 2025 19:51:04 +0200 >>> Subject: [PATCH] TMP >>>=20 >>> --- >>> mm/hugetlb.c | 38 +++++++++----------------------------- >>> 1 file changed, 9 insertions(+), 29 deletions(-) >> Pretty simple. The code LGTM. >> Thanks. >=20 > Thanks. >=20 > The implementation of alloc_and_dissolve_hugetlb_folio differs between = kernel 6.6 and kernel 6.15. To facilitate backporting, I'm planning to = submit another patch based on Oscar Salvador's suggestion. A separate improving patch LGTM. >=20