From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1764AC02183 for ; Tue, 14 Jan 2025 17:01:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A0BE6280005; Tue, 14 Jan 2025 12:01:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 96D8E280003; Tue, 14 Jan 2025 12:01:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 80FFC280005; Tue, 14 Jan 2025 12:01:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 4F636280003 for ; Tue, 14 Jan 2025 12:01:32 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D167180B53 for ; Tue, 14 Jan 2025 17:01:31 +0000 (UTC) X-FDA: 83006673582.18.0AA5C14 Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) by imf29.hostedemail.com (Postfix) with ESMTP id BE3F412002F for ; Tue, 14 Jan 2025 17:01:28 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=none; spf=pass (imf29.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736874089; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qxVP2pMrDyOfbdivkk7++xKq+35QXAxiiTIGuyXizI4=; b=Z8kXIxyG2Dghq9t4IknN56FLskLDFe3IQGvxv0MvQAT6176M8PzxCJrNN3xHNYwGLJmFKc AqLp21Gqguryh3964qSH3hhWn6yju4FJ2FVPU6tyF0VTWWuZMGtw3s6NcxrWLTxgRpMS4O tSsPBrZgwZIc4vjmLrX7qG3y20tux1c= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=none; spf=pass (imf29.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736874089; a=rsa-sha256; cv=none; b=OHO4hSQpp+9F25hJT+dw2H/HkTkjBfVONecfvGCINOzPRw62aRHs8ciDTsDMMQb7UsXgbC MsDV+mc3K+LL28O4eA9J2v1gZ/BW8p/y3gu0mSjI1iOmfLsBBp1T+e/aXVrSsp+8wOoP74 0fux+MyqtAMW4+6NL9dQpAx/sBIDaC8= Received: from fangorn.home.surriel.com ([10.0.13.7]) by shelob.surriel.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.97.1) (envelope-from ) id 1tXkDf-0000000008F-0ZN1; Tue, 14 Jan 2025 11:56:47 -0500 Message-ID: <298822027ef468c290a67fe98e228348e2b389de.camel@surriel.com> Subject: Re: [PATCH v2] memcg: allow exiting tasks to write back data to swap From: Rik van Riel To: Michal Hocko , Johannes Weiner Cc: Yosry Ahmed , Balbir Singh , Roman Gushchin , hakeel Butt , Muchun Song , Andrew Morton , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@meta.com, Nhat Pham Date: Tue, 14 Jan 2025 11:56:47 -0500 In-Reply-To: References: <20241212115754.38f798b3@fangorn> <20241212183012.GB1026@cmpxchg.org> <20250114160955.GA1115056@cmpxchg.org> Autocrypt: addr=riel@surriel.com; prefer-encrypt=mutual; keydata=mQENBFIt3aUBCADCK0LicyCYyMa0E1lodCDUBf6G+6C5UXKG1jEYwQu49cc/gUBTTk33A eo2hjn4JinVaPF3zfZprnKMEGGv4dHvEOCPWiNhlz5RtqH3SKJllq2dpeMS9RqbMvDA36rlJIIo47 Z/nl6IA8MDhSqyqdnTY8z7LnQHqq16jAqwo7Ll9qALXz4yG1ZdSCmo80VPetBZZPw7WMjo+1hByv/ lvdFnLfiQ52tayuuC1r9x2qZ/SYWd2M4p/f5CLmvG9UcnkbYFsKWz8bwOBWKg1PQcaYHLx06sHGdY dIDaeVvkIfMFwAprSo5EFU+aes2VB2ZjugOTbkkW2aPSWTRsBhPHhV6dABEBAAG0HlJpayB2YW4gU mllbCA8cmllbEByZWRoYXQuY29tPokBHwQwAQIACQUCW5LcVgIdIAAKCRDOed6ShMTeg05SB/986o gEgdq4byrtaBQKFg5LWfd8e+h+QzLOg/T8mSS3dJzFXe5JBOfvYg7Bj47xXi9I5sM+I9Lu9+1XVb/ r2rGJrU1DwA09TnmyFtK76bgMF0sBEh1ECILYNQTEIemzNFwOWLZZlEhZFRJsZyX+mtEp/WQIygHV WjwuP69VJw+fPQvLOGn4j8W9QXuvhha7u1QJ7mYx4dLGHrZlHdwDsqpvWsW+3rsIqs1BBe5/Itz9o 6y9gLNtQzwmSDioV8KhF85VmYInslhv5tUtMEppfdTLyX4SUKh8ftNIVmH9mXyRCZclSoa6IMd635 Jq1Pj2/Lp64tOzSvN5Y9zaiCc5FucXtB9SaWsgdmFuIFJpZWwgPHJpZWxAc3VycmllbC5jb20+iQE +BBMBAgAoBQJSLd2lAhsjBQkSzAMABgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAAKCRDOed6ShMTe g4PpB/0ZivKYFt0LaB22ssWUrBoeNWCP1NY/lkq2QbPhR3agLB7ZXI97PF2z/5QD9Fuy/FD/jddPx KRTvFCtHcEzTOcFjBmf52uqgt3U40H9GM++0IM0yHusd9EzlaWsbp09vsAV2DwdqS69x9RPbvE/Ne fO5subhocH76okcF/aQiQ+oj2j6LJZGBJBVigOHg+4zyzdDgKM+jp0bvDI51KQ4XfxV593OhvkS3z 3FPx0CE7l62WhWrieHyBblqvkTYgJ6dq4bsYpqxxGJOkQ47WpEUx6onH+rImWmPJbSYGhwBzTo0Mm G1Nb1qGPG+mTrSmJjDRxrwf1zjmYqQreWVSFEt26tBpSaWsgdmFuIFJpZWwgPHJpZWxAZmIuY29tP okBPgQTAQIAKAUCW5LbiAIbIwUJEswDAAYLCQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQznneko TE3oOUEQgAsrGxjTC1bGtZyuvyQPcXclap11Ogib6rQywGYu6/Mnkbd6hbyY3wpdyQii/cas2S44N cQj8HkGv91JLVE24/Wt0gITPCH3rLVJJDGQxprHTVDs1t1RAbsbp0XTksZPCNWDGYIBo2aHDwErhI omYQ0Xluo1WBtH/UmHgirHvclsou1Ks9jyTxiPyUKRfae7GNOFiX99+ZlB27P3t8CjtSO831Ij0Ip QrfooZ21YVlUKw0Wy6Ll8EyefyrEYSh8KTm8dQj4O7xxvdg865TLeLpho5PwDRF+/mR3qi8CdGbkE c4pYZQO8UDXUN4S+pe0aTeTqlYw8rRHWF9TnvtpcNzZw== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.54.1 (3.54.1-1.fc41) MIME-Version: 1.0 X-Rspamd-Server: rspam05 X-Stat-Signature: nt6ipfuugbo9qw6yttguy7ry8stdmur9 X-Rspamd-Queue-Id: BE3F412002F X-Rspam-User: X-HE-Tag: 1736874088-655158 X-HE-Meta: U2FsdGVkX19Ztb9NVH/S2cWBY5DrnsTXRB+HQCL1D39Qa1+jUK7keAepoDfS8S9l7QYNox3VVhU5qG8Uq+chM9i6Ur4rwu0G0xGSPf1wCMkJEHsPo/qU4ru+e0Hn8qkr2lt/eozTmcgViyUKFj7mXr/GmgDtNeIHUM9PduMU8ZdcQDzRUi0BLxNIA0eGLQZW6bk3IoPx++bDivoonCGysFTvzp8UbcKcwMf2qV0cD7gE2rzD8u4KBZSJCLkSKuOTiW4FTkAosB5l6rUZSPoIZ+W7X5xzRr6t4VsEvQ7VLM77n/1wKF/pYg4FDdUZXhitsgl7wcJHUATVEpnrWB8fErk/zpksPs1nJhN3zMpR1q+nflWMTsjLOSVJXmAmDU9IIjLUeCaADMP9fDgEXHIS5PmvRyVaLUv51TuGLBoMus/CJTXamZ9TEuMJPg0Rjlat9qXtFjmpak9h43rlePrUjlRFHBGyKhRCAqfnehhYhiDt+AywJuMMc5C8l3eeUueJU8xs7JqEIs2KqsHMDre+KWhKwJPs1+Upi4EXc09SnihdWL00CCIdE0agDoFuzffjRfrFG+BR5sqDEpgPC3i8Lq4tfmFf+Kc7+/RZ0n0BiNwha57Vq7dpOZezDYO6dOCVwY4h50gUk4gF9UnGOftdQNQYNNByJoJY/3ed2PlCKl5/qslS3DKOTqN2fv/GQ2zoSKx/wptKs3EYxY54vY1EFmMy++a7RztM6VA/syICMU2qUfAnwwqyA5F6qPk4FzNjHUsHPhELx9Knh2F4mIQDjZaBZbf5K2XRj1ul/mwZKirnx8xlM9Pz0r7lMphJTFIj7pMp4XdPS9mMhwVGSz/epid5qVXAJgsp6+Rc69aNscDZ3GgXLqS5b2xYcCjRz1yKzdX7z/hhzEq8mX8kHNZzyyJGnKEa1nN60LK1VvogVCcNHpCFHJ6j/yH5sP2JFQru3mc/FGE5VD0HYW9KuXO riTWNbuh +2+jw/wPaTIPlXrFuUPocJ8hcYQjddv1FpRSnIg+QGsn397IbClQCQPv9nlvn8qZ8MRQLsb6FxSnaRT/yr6XE1vM4Lato33x0jj8ZZxNY4tnRP2yBpj5jWRHXY1Tv9nxmv+91qgk2yLIdKr89jnoTAT4s+T25+LC2XXHoiPUZk9PlsnkTaoH99/7OYTYnHbxXnq8O24qMSXc4UwKfCYwjsHjw+94J0kQRvgzUy9FAkqsZk+jf0aYojXPBhtZp1zGCH1pgILlkh2wDYrzk0Ut/wjMCcHUToVGb7TlN X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 2025-01-14 at 17:54 +0100, Michal Hocko wrote: > O > Btw. is there any actual reason why we cannot go nomem without going > to the oom killer (just to bail out) and go through the whole cycle > again? That seems arbitrary and simply burning a lot of cycle without > much chances to make any better outcome >=20 > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 7b3503d12aaf..eb45eaf0acfc 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -2268,8 +2268,7 @@ int try_charge_memcg(struct mem_cgroup *memcg, > gfp_t gfp_mask, > =C2=A0 if (gfp_mask & __GFP_RETRY_MAYFAIL) > =C2=A0 goto nomem; > =C2=A0 > - /* Avoid endless loop for tasks bypassed by the oom killer > */ > - if (passed_oom && task_is_dying()) > + if (task_is_dying()) > =C2=A0 goto nomem; > =C2=A0 > =C2=A0 /* When we return from the page fault handler, we restart the instruction that faulted. That means we could just end up repeating the same fault over and over again. --=20 All Rights Reversed.