From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85621C433F5 for ; Fri, 1 Apr 2022 10:29:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DE1FA8D0002; Fri, 1 Apr 2022 06:29:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D8DAE8D0001; Fri, 1 Apr 2022 06:29:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C550C8D0002; Fri, 1 Apr 2022 06:29:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0123.hostedemail.com [216.40.44.123]) by kanga.kvack.org (Postfix) with ESMTP id B75128D0001 for ; Fri, 1 Apr 2022 06:29:28 -0400 (EDT) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 69EEFA7C57 for ; Fri, 1 Apr 2022 10:29:18 +0000 (UTC) X-FDA: 79307937996.25.710A92C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf17.hostedemail.com (Postfix) with ESMTP id E16EA40026 for ; Fri, 1 Apr 2022 10:29:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648808957; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QnkWLPWaubJDCgjkk+KSAWH5tkw5z8xC00A/EFIIYy0=; b=Amn9Inm+m5gA20b/ge+ubQImoXBIXNT3KfngFcYLZkGy86gQNYQEUVS9mJwpvY7s2OUcEw 6K0qLM2gqzL+X+hnhg9Y31GF7wwpRYvKhuYfuL6nAGWyZ/RkczR3cMpWZYIBiFLAKFu8oP bqCKulTiEU+cZnVwNXc6pgZkKS9Cwc0= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-601-sdJc05kiNWyUGT_pTKkQQg-1; Fri, 01 Apr 2022 06:29:16 -0400 X-MC-Unique: sdJc05kiNWyUGT_pTKkQQg-1 Received: by mail-wm1-f70.google.com with SMTP id h189-20020a1c21c6000000b0038c8655c40eso992510wmh.6 for ; Fri, 01 Apr 2022 03:29:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=QnkWLPWaubJDCgjkk+KSAWH5tkw5z8xC00A/EFIIYy0=; b=FGFCESWAT2HV+LsuielVnnRLXICXlZjW80FDM/LGsags6EkwX6xY/sKcB2B3ZnwOrZ TVDIRCvoptMCueiySPRBMXzKRmEtcp5h6IDftCYqiDZ+YFh40PBmNVPvb55ezkZrcQ+A sXo08Ui60T5DLAt0GKQpiSeZhDROFUQdG7z1g/+6i7v5lVnUByJLfq4v/IlGTXh4BsLb fXxPX7yGD0BsViYO9L9ZM7CnOEOA4ApX9qmbXuJngRRFSxzKwzPzog38d7HczEwXGSzs nO+l1YMX5D3+mAyRJ020HpXBAjJRGJFFz83XD/mGIYpcMaKp9eh4namU0zfu8bwmkCno 79Fg== X-Gm-Message-State: AOAM530kfkwQr6intj6MHJL2ItqeKuSWkKi2KgdLcjHsWtfbGscuc5CT 8Yz96ySm69iks1gJkW2rFlrliifKFpl79rHarlqQOIhpEM5poV99wxuJw5zRNXt039iLtSqva2J 6vtVeYeKQXag= X-Received: by 2002:a7b:c5cd:0:b0:38c:8b1b:d220 with SMTP id n13-20020a7bc5cd000000b0038c8b1bd220mr8037001wmk.118.1648808955143; Fri, 01 Apr 2022 03:29:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy9ybJOrHbcXO9wX82TpTOQTaJOg6nrZTNTh6CO46+uv792qqm/WZuH6WSFX5+Yz4BYlJk/7A== X-Received: by 2002:a7b:c5cd:0:b0:38c:8b1b:d220 with SMTP id n13-20020a7bc5cd000000b0038c8b1bd220mr8036979wmk.118.1648808954900; Fri, 01 Apr 2022 03:29:14 -0700 (PDT) Received: from ?IPV6:2003:cb:c706:9e00:229d:4a10:2574:c6fa? (p200300cbc7069e00229d4a102574c6fa.dip0.t-ipconnect.de. [2003:cb:c706:9e00:229d:4a10:2574:c6fa]) by smtp.gmail.com with ESMTPSA id 14-20020adf828e000000b00205b0fc825csm1749308wrc.65.2022.04.01.03.29.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 01 Apr 2022 03:29:14 -0700 (PDT) Message-ID: <2981c978-2e00-5e6a-a9c5-4c82f184430d@redhat.com> Date: Fri, 1 Apr 2022 12:29:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH] mm/slab: remove some unused functions To: Miaohe Lin , cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, vbabka@suse.cz Cc: roman.gushchin@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20220322091421.25285-1-linmiaohe@huawei.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220322091421.25285-1-linmiaohe@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: E16EA40026 X-Stat-Signature: omp78pfcbdbiekh5hyp6e3a6afjiikya Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Amn9Inm+; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf17.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com X-Rspam-User: X-HE-Tag: 1648808957-35395 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 22.03.22 10:14, Miaohe Lin wrote: > alternate_node_alloc and ____cache_alloc_node are always called when > CONFIG_NUMA. So we can remove the unused !CONFIG_NUMA variant. Also > forward declaration for alternate_node_alloc is unnecessary. Remove > it too. > > Signed-off-by: Miaohe Lin > --- > mm/slab.c | 13 ------------- > 1 file changed, 13 deletions(-) > > diff --git a/mm/slab.c b/mm/slab.c > index d9dec7a8fd79..81301df47057 100644 > --- a/mm/slab.c > +++ b/mm/slab.c > @@ -619,18 +619,6 @@ static inline int cache_free_alien(struct kmem_cache *cachep, void *objp) > return 0; > } > > -static inline void *alternate_node_alloc(struct kmem_cache *cachep, > - gfp_t flags) > -{ > - return NULL; > -} > - > -static inline void *____cache_alloc_node(struct kmem_cache *cachep, > - gfp_t flags, int nodeid) > -{ > - return NULL; > -} > - > static inline gfp_t gfp_exact_node(gfp_t flags) > { > return flags & ~__GFP_NOFAIL; > @@ -639,7 +627,6 @@ static inline gfp_t gfp_exact_node(gfp_t flags) > #else /* CONFIG_NUMA */ > > static void *____cache_alloc_node(struct kmem_cache *, gfp_t, int); > -static void *alternate_node_alloc(struct kmem_cache *, gfp_t); > > static struct alien_cache *__alloc_alien_cache(int node, int entries, > int batch, gfp_t gfp) Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb