From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A00C5C021B8 for ; Wed, 26 Feb 2025 17:03:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 35069280011; Wed, 26 Feb 2025 12:03:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 32603280010; Wed, 26 Feb 2025 12:03:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 21530280011; Wed, 26 Feb 2025 12:03:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 03E8D280010 for ; Wed, 26 Feb 2025 12:03:37 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 5D90F121E60 for ; Wed, 26 Feb 2025 17:03:37 +0000 (UTC) X-FDA: 83162717274.01.6A8DB55 Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) by imf26.hostedemail.com (Postfix) with ESMTP id 80A7E140028 for ; Wed, 26 Feb 2025 17:03:35 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf26.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740589415; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TLXA1FoRHn2QluKXWO9dXWWYzbhjA3gHd7Gt5zghIDI=; b=XkMlWfZtRam/R4UGrTmNuXOUcfBg9GTkcxzpkJHsgYb7354BMseDiUXGh6wuWSYQRwHbXN jzG/ugWXFGJFZtG1x/cvx6NLDJalVhaMjm2BXqiB63SRmZfCOeT9jfW6MnnC2d377fI+gV 2//uTlJo7bNGnxyP6pJw8jyeuO8SmYw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740589415; a=rsa-sha256; cv=none; b=BaUIOXxiu3jpbPZ03wte8HqlJmXjmqXyRWkThUZAQWnLvPfXRCdJlrZv1sPd2ZpLkYOI8R fi6LQZPAsZhRxN3Xxr2VKFyi0jkGAwdQxT3pHggSh0X1isZMX8ZVQgnCbDtm4T/liNIXxM cYRsQ7qkg/+b0xUcFOsQAkyQ9LkwDH0= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf26.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com Received: from fangorn.home.surriel.com ([10.0.13.7]) by shelob.surriel.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.97.1) (envelope-from ) id 1tnKo3-000000003P0-3dj6; Wed, 26 Feb 2025 12:02:47 -0500 Message-ID: <297b28e9ef9f4cd983ae2e3dd4cf1fce8b74d0f1.camel@surriel.com> Subject: Re: [PATCH v13 06/14] x86/mm: use broadcast TLB flushing for page reclaim TLB flushing From: Rik van Riel To: Tom Lendacky , Borislav Petkov Cc: x86@kernel.org, linux-kernel@vger.kernel.org, peterz@infradead.org, dave.hansen@linux.intel.com, zhengqi.arch@bytedance.com, nadav.amit@gmail.com, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, jackmanb@google.com, jannh@google.com, mhklinux@outlook.com, andrew.cooper3@citrix.com, Manali.Shukla@amd.com, mingo@kernel.org Date: Wed, 26 Feb 2025 12:02:47 -0500 In-Reply-To: <680053d3-4cf9-534a-1c52-c6e259b85452@amd.com> References: <20250223194943.3518952-1-riel@surriel.com> <20250223194943.3518952-7-riel@surriel.com> <20250224132711.GHZ7xzr0vdhva3-TvK@fat_crate.local> <7c2baf33265444089ab780848de29a1336a9a4cc.camel@surriel.com> <20250225203803.GGZ74qK1oZWk8u69O4@fat_crate.local> <20250225210300.GHZ74wBP2ogmM5P5lP@fat_crate.local> <680053d3-4cf9-534a-1c52-c6e259b85452@amd.com> Autocrypt: addr=riel@surriel.com; prefer-encrypt=mutual; keydata=mQENBFIt3aUBCADCK0LicyCYyMa0E1lodCDUBf6G+6C5UXKG1jEYwQu49cc/gUBTTk33A eo2hjn4JinVaPF3zfZprnKMEGGv4dHvEOCPWiNhlz5RtqH3SKJllq2dpeMS9RqbMvDA36rlJIIo47 Z/nl6IA8MDhSqyqdnTY8z7LnQHqq16jAqwo7Ll9qALXz4yG1ZdSCmo80VPetBZZPw7WMjo+1hByv/ lvdFnLfiQ52tayuuC1r9x2qZ/SYWd2M4p/f5CLmvG9UcnkbYFsKWz8bwOBWKg1PQcaYHLx06sHGdY dIDaeVvkIfMFwAprSo5EFU+aes2VB2ZjugOTbkkW2aPSWTRsBhPHhV6dABEBAAG0HlJpayB2YW4gU mllbCA8cmllbEByZWRoYXQuY29tPokBHwQwAQIACQUCW5LcVgIdIAAKCRDOed6ShMTeg05SB/986o gEgdq4byrtaBQKFg5LWfd8e+h+QzLOg/T8mSS3dJzFXe5JBOfvYg7Bj47xXi9I5sM+I9Lu9+1XVb/ r2rGJrU1DwA09TnmyFtK76bgMF0sBEh1ECILYNQTEIemzNFwOWLZZlEhZFRJsZyX+mtEp/WQIygHV WjwuP69VJw+fPQvLOGn4j8W9QXuvhha7u1QJ7mYx4dLGHrZlHdwDsqpvWsW+3rsIqs1BBe5/Itz9o 6y9gLNtQzwmSDioV8KhF85VmYInslhv5tUtMEppfdTLyX4SUKh8ftNIVmH9mXyRCZclSoa6IMd635 Jq1Pj2/Lp64tOzSvN5Y9zaiCc5FucXtB9SaWsgdmFuIFJpZWwgPHJpZWxAc3VycmllbC5jb20+iQE +BBMBAgAoBQJSLd2lAhsjBQkSzAMABgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAAKCRDOed6ShMTe g4PpB/0ZivKYFt0LaB22ssWUrBoeNWCP1NY/lkq2QbPhR3agLB7ZXI97PF2z/5QD9Fuy/FD/jddPx KRTvFCtHcEzTOcFjBmf52uqgt3U40H9GM++0IM0yHusd9EzlaWsbp09vsAV2DwdqS69x9RPbvE/Ne fO5subhocH76okcF/aQiQ+oj2j6LJZGBJBVigOHg+4zyzdDgKM+jp0bvDI51KQ4XfxV593OhvkS3z 3FPx0CE7l62WhWrieHyBblqvkTYgJ6dq4bsYpqxxGJOkQ47WpEUx6onH+rImWmPJbSYGhwBzTo0Mm G1Nb1qGPG+mTrSmJjDRxrwf1zjmYqQreWVSFEt26tBpSaWsgdmFuIFJpZWwgPHJpZWxAZmIuY29tP okBPgQTAQIAKAUCW5LbiAIbIwUJEswDAAYLCQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQznneko TE3oOUEQgAsrGxjTC1bGtZyuvyQPcXclap11Ogib6rQywGYu6/Mnkbd6hbyY3wpdyQii/cas2S44N cQj8HkGv91JLVE24/Wt0gITPCH3rLVJJDGQxprHTVDs1t1RAbsbp0XTksZPCNWDGYIBo2aHDwErhI omYQ0Xluo1WBtH/UmHgirHvclsou1Ks9jyTxiPyUKRfae7GNOFiX99+ZlB27P3t8CjtSO831Ij0Ip QrfooZ21YVlUKw0Wy6Ll8EyefyrEYSh8KTm8dQj4O7xxvdg865TLeLpho5PwDRF+/mR3qi8CdGbkE c4pYZQO8UDXUN4S+pe0aTeTqlYw8rRHWF9TnvtpcNzZw== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.54.3 (3.54.3-1.fc41) MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Queue-Id: 80A7E140028 X-Rspamd-Server: rspam07 X-Stat-Signature: wjhxxy1xgdnrxhabpwo9c48yucycnhi6 X-HE-Tag: 1740589415-397759 X-HE-Meta: U2FsdGVkX18ms7KHt4aw0OOuHvtSLKYCnuzgC4F8RebxbA/Fml5LnwJeip+n22frhsMHy3TSRe6oByWTPD0eLfBztqkKxx7lOov0vZeyP/OxiYBwytDGZVdb70JITGLTsD2P60AvHEZfOOGlZVVwW/XSIeOSqv0T0TNMYU/2Cu+B71ZrNkpgBVvdk2UqMIxt562ax8FanXJ/UjpdO8bvtJlJ3m5DpZyAcdNsmjb6wJnt84LwLDjhgikKOAWxQL1I7IrunD3HFIe7+kOv8kWDGf8qOuqbA68K9XPm8h2EBWVgbaRlHptBGsFRN2I7+Dxt14azUnJEiOXfK6zOsbrjtB9GVvKzRYKOoYwztzGs8l7oS9m8q7hf9JJz5z33ESbVSo+wgP8cews0JMFGoK7dVlcaRzZ3IG9nS9d51xpHpQOYykOsaLx/ApbLferJc973sNWkPVoKLq7w/nnHl+jMm3WGrn4K/GM6rfGihbwLR/8wFvcBth3Q752VduzFRM0hvmbLB3xCuRbpC/+lgadpjSh7/Xd8JmQ0vNKx0JzD0CYAJq+/hcjcH+cv6aB4ndLc8u+jVl05D1qK77Se99txng2UlyjbuNsqUz3/q8RoGoMMnNPsfGuPLUCkPXXZe8iO/DNw3RUPSZgwm4ASJCUkC/gA+Pibd6xvhoLKI3sT1k1lcF3vIGM2Fs8fAUYfSd3UG6wAbHl8hOZU2NECKq2K7MpIREoKxh1UB9p7RXFTMcY0GnGqfdC4WXsvWjtYGKlLP1hx3wFYsk+Y7o99gpz4JnDVUOG4AhKsGw3gPoWeQBayqaPg8Y9YLg/Z0INCD0SfdMC8NGFPDkG+1JoZi0ia7qQrAlI1RN7kQ9IrHTIdvpc03BJi8QnHurOiv2qX8kngMkYE3j62mPSldH6+xvxnwPpHPggW66Yx28n7YSyTQXbnxEegqqLQjVtz1FDmA5DYEk1IwiyURT0T6YEc2Dq I5bBfAxG nmh1UPruEPpEIICeclnBspVXeKrsFxCeBRoCafL1LTYf+RwXkJ49lI2Y+W/UxqH6yuzPhUeOwzSrQrd04YKgmHTkq4aFfac9fTZdvoDWekFMdBlOv18vlfXHRpfWhrBLHvFPo8ZfsRF80PNWsvQ8rpXSBFqhYqz3z2bUiNlTNzjH6DdR4/unLmle9LHQxfWSprtzW/Pe/CMMHPk8XmkddWMX1qXAaorhL7Te2vQAaN+R55DIW26uIlrib/T39C7O7iJgtTvPqPSSp+yMIN7gLRreSEe8wWjjPDkkwvRUicPMg9fLoBrjjOf577EHQ7bRfwCJ1ZCcIqQhFx4tJogUKz0AYw1EAqSWl33xmfGaW8pFwXvE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 2025-02-26 at 11:00 -0600, Tom Lendacky wrote: > On 2/25/25 15:03, Borislav Petkov wrote: > > On Tue, Feb 25, 2025 at 09:38:03PM +0100, Borislav Petkov wrote: > > > On Tue, Feb 25, 2025 at 02:17:20PM -0500, Rik van Riel wrote: > > > > Who do we need to ask to confirm that reading? > > >=20 > > > Lemme figure it out. > >=20 > > Confirmed - that really is the case. >=20 > Hmmm... since this is for host/hypervisor TLB handling, this makes me > think that we should always be setting the ASID valid bit with 0 for > the > ASID value in EDX[15:0] on all INVLPGB instructions in this series. > Otherwise we will also be flushing any guest ASID TLB entries that > match > the conditions, when that isn't intended. The ASID is always zero in this series. We only ever use the PCID for address space identification. --=20 All Rights Reversed.