From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FAFDC3065A for ; Mon, 1 Jul 2024 06:55:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0B2D96B0088; Mon, 1 Jul 2024 02:55:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0632A6B008C; Mon, 1 Jul 2024 02:55:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E1E166B0092; Mon, 1 Jul 2024 02:55:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id C44D46B0088 for ; Mon, 1 Jul 2024 02:55:28 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 3E445A19A2 for ; Mon, 1 Jul 2024 06:55:28 +0000 (UTC) X-FDA: 82290272736.05.8E9811D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf11.hostedemail.com (Postfix) with ESMTP id E4D144000C for ; Mon, 1 Jul 2024 06:55:25 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=c8ZNVEz5; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719816915; a=rsa-sha256; cv=none; b=61UTjiDfedkSN5w51n+OeWdT0hMDPO3c/NrvvfgwSQsV/JKpDEDshHfJzGZB197DJicQjM DUotJjrgvtSEzCN+ePyAOhnnfA7JlfZg32q87Fl3WrMZVViLEEXaoFnskfiNB1kZUdYThM lfw6DQRxbDodokhJfM2Jd1EO6oCxsp4= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=c8ZNVEz5; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719816915; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=glgtNTPZcrTMFuvFQHUSkgAknMIfGdNGOQVZXr6adxg=; b=5pAoHjVMF7gMbcSc+V5T3rlSbZhGjANyhHoxqOmtfaaL/8XXmMWyZDwDueFeKOvcq2q7rJ 1+BOAEERctoZlmlQwDxRAGQTSeukuvnvEP7SnfjrGVSg4Mpxl/eAehmI4l56E/E3IGnN70 KbgZKPJud+oGZ85hJke+BskCT35UuNo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1719816925; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=glgtNTPZcrTMFuvFQHUSkgAknMIfGdNGOQVZXr6adxg=; b=c8ZNVEz5bcfd7kJm3r8GAJm6DZPHlJFpG9M+e2p5QDLg+O1GjR//wMw4eL8o+pLLq0euv9 /cByeZL4beqRHysGSZUSqvW0sPlubkmQF9uPsMb/vQOX4g8Etfttjs/9myTetqE1iprbCM 3xYZQcekcVhObpxCk5MztwohdObC+Fw= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-373-BPr6bb41OAGmEAjXcp8asQ-1; Mon, 01 Jul 2024 02:55:23 -0400 X-MC-Unique: BPr6bb41OAGmEAjXcp8asQ-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-366e84fbd4bso2094083f8f.1 for ; Sun, 30 Jun 2024 23:55:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719816922; x=1720421722; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=glgtNTPZcrTMFuvFQHUSkgAknMIfGdNGOQVZXr6adxg=; b=Zuj5i1ovYZ6RQtIk+ZMQtA8pf1wVnxrzfPVXn4OpQWygtL0BDH6j7vnZwj1UDEhD7+ gXtU1SExgq3J1c5RoXWFcgQ7+8qfW2LXEsCSzIvgYje/bObcU0lpBQEFiczFAMBDwlKw B9W5FZORv784/qJ4eveWCFezabwXET36U9pwm5nEyUB3MoDDMjG19jEGKsxLCzU9Hzdj mXUEYk9q8cp+kB7OLjfG3PB5FGXuXpiGwNgid70uvLOpH7WK/+X92HZgYSpOolUm4hN+ uSAV5uVC9GISLIwr1jLi/tJOT2vfPMYXke3zUqtJAE7su+PgTdFHpHIkLiT+UqLJI4co dnCQ== X-Forwarded-Encrypted: i=1; AJvYcCXogFXJqtoBxeJh5GMEnf9lkzub96UAZDmEWMS4BwBkatgKy9OGfEv5V7t6Uu2DAyBE0YkM3kKop6TTxZG4+Z82wAs= X-Gm-Message-State: AOJu0Yx5k+d4Llew0QDtddlFtAa2y6DTOo5u7OLi31FtU7jjjaQCavKd QojVbbflVjaYs+Y/DQRbA6rN2Noj0/hLV1fH9afApOu+biJI6y69FQq67irL1yrj7TYQoFtVAqx /zRdbu3J5mZ+dpFceECPhRb9Lu7/Y+rASZASNUcrKbAOcEp2l X-Received: by 2002:a5d:49cc:0:b0:366:eade:bfbb with SMTP id ffacd0b85a97d-367757200admr3792703f8f.46.1719816922631; Sun, 30 Jun 2024 23:55:22 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEkSIOwyPwj10OkfDwrxar2pmbAtcFWuP/RXX1gb5+VDZxBO5ZaenQJMxc8kF5JWScZzFwu9A== X-Received: by 2002:a5d:49cc:0:b0:366:eade:bfbb with SMTP id ffacd0b85a97d-367757200admr3792683f8f.46.1719816922219; Sun, 30 Jun 2024 23:55:22 -0700 (PDT) Received: from ?IPV6:2003:cb:c72e:2200:7ed7:c239:d423:3b31? (p200300cbc72e22007ed7c239d4233b31.dip0.t-ipconnect.de. [2003:cb:c72e:2200:7ed7:c239:d423:3b31]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3675a0fb9absm9187238f8f.80.2024.06.30.23.55.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 30 Jun 2024 23:55:21 -0700 (PDT) Message-ID: <2972d75a-ab26-4da7-88fa-81bed955cf52@redhat.com> Date: Mon, 1 Jul 2024 08:55:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] support "THPeligible" semantics for mTHP with anonymous shmem To: Baolin Wang , Bang Li , hughd@google.com, akpm@linux-foundation.org Cc: ryan.roberts@arm.com, wangkefeng.wang@huawei.com, ziy@nvidia.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Barry Song <21cnbao@gmail.com> References: <20240628104926.34209-1-libang.li@antgroup.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: rt1bzhmju7tfayezh6pb7rgxfscq1yy8 X-Rspamd-Queue-Id: E4D144000C X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1719816925-917925 X-HE-Meta: U2FsdGVkX18a7N/pD89MMQlQROoROijTTGQ/tBPzdKIwyFRnJbFUCVYFl6C7FvyW7eW4VXvFgpj3U8eNF3uWMEexN9kbwfCkXlLpGPCAe99G4bPYtJ/GB2J4A4+BqdWuzWlZHduMrrpIFHngbjtQDHOhM8zfnwAMGG7exe8o5wvRSiz4kQxsG6I6iY0urCu3EOixa/iT3HUW8Pxs+HoIWhNCf76+4O3TVbzZvvFB1hsUNT6/6A8R2nDwUYkaO3Dh32HZimUVBl0TIMWTZK1KMP6fG3YgZRln35aXOxUbp+lwHrzU91l06NP8iBUTXH5e5XLjHpzXzJ6HDDeyy4lgHTtluJJA8FlsZ1n58mtSatugdWwHaN9c/ZSStS0zJC5PeXp0Y2IJ+4boyQ6nbNglFIOf2uIjIzANtsQVH0Edz+hhK9XMVaqNojQ3XZvNeE5S+E6KQIg8+iPWAC0ZBLTVP882ZVh+hcXZtbSTothAc6PwIGgVWYPima/1lmaH9GuWGuqNV4Rsm8sERC675dUNhCu6lcPIaXs2qtG4HSooke7gqLVqz/4/L2dMfVJXuyK8HzTmx75ZqecXpr5E0zvcoQ+p9Fo4t4BOxG2oE1w0Q8xfrQV94aczypWRaeepZDCRQFmokYUsnZdfbA+06NASVE4BD2rXYHwaD/IEI72rNf7Pp7X+vmOpQsutoz1YeCGImM7bnrY/15Sn1OcCGNvHBZ+FFaFn7M3I8f/FdikExfqx/4oZkojXK5yrbDNuJw1gJlGAVvIZh0zbe8vzLlpoer28eevRDaQLs5u/xzu0gpftrnM7jTMnpYH6oYQLUqeVpHhnkzkZE1IqWnWjmBjN0n8XPWZJkoWm08AOpTN+D9aNmnBbfXo5KlnhpMsP5NCZ+fMRVczl8ExzCPjrl+SwyFMc0bGQjnNI+qiLLVVeoe4WYeZOAyt6IN40emoAGcFdXD+wAqY5iE40m8Dksjw Hb0PSbFW MxQe+/gSqwN50ABvWKFijYbEVH782loXml63w778vz6GnBuO/dM5AJzuMof3rYZx8cNC7qrdB6m6IvgsOv/5w8W9x/blXJd6X1M/V9YHPRbG65gsFxVp4Htuv6FpMxLFgBmFJZH517wB9vOuAqUwcErCMh5mScbZoL7Pn4S0BAoGZ4rYVUeDyVxY7gUsRDYCtrrT0LCT2wONDzs3Xc47RelpV3VngIzfYNBN0CMViJJ5navVwKkF2Q1OO9RY3KzZ4CqhGFeudlOBQGgVhKsg8FjliL+s9pYa0ooKMXCzssv7bsPztQpQ/omiMp9fxRB32aRKdNw6GL2O2mO34luonRyOWO4nRRuLzZtRAfFkTy6E8Vqgueo1pf8IQJHAF5XAQ8BzsPnpxMeLVDRehuOE4ymezx9XakKKILIwLlg8TcyKNsHwMFTprAan5oE71r3ds02YzLclQDlJgLUY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 01.07.24 08:47, Baolin Wang wrote: > CC Barry. > > On 2024/6/28 18:49, Bang Li wrote: >> After the commit 7fb1b252afb5 ("mm: shmem: add mTHP support for >> anonymous shmem"), we can configure different policies through >> the multi-size THP sysfs interface for anonymous shmem. But >> currently "THPeligible" indicates only whether the mapping is >> eligible for allocating THP-pages as well as the THP is PMD >> mappable or not for anonymous shmem, we need to support semantics >> for mTHP with anonymous shmem similar to those for mTHP with >> anonymous memory. > > I did not see a consensus that "THP*" related statistics should contain > mTHP in previous discussion [1]. > > In addition, if we all agree that "THPeligible" should include mTHP > statistics, you should update the corresponding documentation to keep > consistency. > > [1] > https://lore.kernel.org/linux-mm/202406262300.iAURISyJ-lkp@intel.com/T/#md7a77056110cebcc2a9b3cd7e4a8d682667f6ba5 > Fortunately, documentation (Documentation/filesystems/proc.rst) says: "THPeligible" indicates whether the mapping is eligible for allocating naturally aligned THP pages of any currently enabled size. 1 if true, 0 otherwise." So that documentation is already pretty clear (we just have to make sure the other ones are properly documented, for example as raised in reply to [1]). -- Cheers, David / dhildenb