From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DE48C48BF8 for ; Thu, 22 Feb 2024 14:36:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8B53A6B0075; Thu, 22 Feb 2024 09:36:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 865336B0081; Thu, 22 Feb 2024 09:36:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 72D326B0087; Thu, 22 Feb 2024 09:36:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 61BAF6B0075 for ; Thu, 22 Feb 2024 09:36:23 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 266B680BB0 for ; Thu, 22 Feb 2024 14:36:23 +0000 (UTC) X-FDA: 81819690246.26.6A15FFE Received: from szxga06-in.huawei.com (szxga06-in.huawei.com [45.249.212.32]) by imf02.hostedemail.com (Postfix) with ESMTP id 4353280021 for ; Thu, 22 Feb 2024 14:36:19 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf02.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.32 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708612581; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xqueY89tu+36/pWkASsrsL4bAMFt3shkNGE+YAEBM70=; b=NUg/1vNmwVCazcBNw9fqeilr5Vm7WcVWGReUsM7DTAz5jipOrrSLm0UbGQ4YuQA4CL1W/B kNtBb8xiehtT8MfwlBLEcQFvXX0rgv4bq6Y4nu7FkAxyByca8iFmBQAbTbi1gTHIASxuTP C2xFfojXiRKjrEAAtpQU6h8klEranjg= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf02.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.32 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708612581; a=rsa-sha256; cv=none; b=vx7MNCqkSjvL+hp5zufCLH7FKmrXITRAHwM2+3Lj9zjsoNLL8YJ7il7QyDZUHcMz1wGbfY cvYIFIx+FnOh6bDhunUIlYzPvEludyv/IR8B4C8Z8DbJ9/AFwtjujYfTP0wuCQUk5P/XCZ nbAf2fkjNML3LDp3dB1WyFNNRN5FWzw= Received: from mail.maildlp.com (unknown [172.19.88.214]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4TgbKM50mJz1vv6F; Thu, 22 Feb 2024 22:35:35 +0800 (CST) Received: from dggpemm100001.china.huawei.com (unknown [7.185.36.93]) by mail.maildlp.com (Postfix) with ESMTPS id 5F95F1A016B; Thu, 22 Feb 2024 22:36:10 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemm100001.china.huawei.com (7.185.36.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 22 Feb 2024 22:36:10 +0800 Message-ID: <296f2325-19a2-47ab-a36a-ba4e43fe450c@huawei.com> Date: Thu, 22 Feb 2024 22:36:09 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: compaction: early termination in compact_nodes() Content-Language: en-US To: Andrew Morton CC: David Hildenbrand , References: <20240207095841.1648144-1-wangkefeng.wang@huawei.com> <20240208022508.1771534-1-wangkefeng.wang@huawei.com> <20240208131440.e30a650505fac4068ab75ee8@linux-foundation.org> <20240221143434.5ba9efcf6c4dc534d1f1a9f1@linux-foundation.org> From: Kefeng Wang In-Reply-To: <20240221143434.5ba9efcf6c4dc534d1f1a9f1@linux-foundation.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpemm100001.china.huawei.com (7.185.36.93) X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 4353280021 X-Stat-Signature: ij8kgf4mupe7wq919uebfgz781fxdz7b X-Rspam-User: X-HE-Tag: 1708612579-440808 X-HE-Meta: U2FsdGVkX1+rohYJTIIZObuL83VNHhvg9Nt+k193DcONRk9cAgp6Xyr7fd8uT+Cz40c3URHIrK31tpLOAYol71K5MeQ6MVD76e2N0qWDJss2ASfh65XNMmFAxKhflfhxOsuKurjtDw1vtOdyAyMlueBBAz93fEKy7AzcrjATYfrxJEKX0vpmw8ioEMbN/Traoo2/INPxPHnVUdcp6c4Sjd+TBxFfjrR3kN/9LSKYVHMPb/WMfBFNbaCxjfH09apc53RPfCWglYpp50KXPkNukqgyDKptVJG11LdqFKpeVnsNAzaL+khexmeolSGa+UhtlcLNFvQFB1bvtxO3u5laKnHMgMJ3qDfE4YvndBh7VKypSBwrteyVicVaBQmGuRft8Rcq+c+G0tW0ERFpnCxAL1sqWI5lpwqvmiD1QCH1BGRfniPz6HyE/kkZXARnuio9tIb65/H/nvdXlupyo/z/5/r8vT2y6+QuS01nNqIrBG0UgXGc7SMkQnckxhA2y9+NWQmB/v7c4mPynDMb+11qMl6mG6LXruZEqVSh7rDsRWW4OR38KJxopIqAe9ky4Tw16HW/LxZBZlzyfhWy/qKYbeTlxlGn9KAmlYY7mIjXQL9TwCpMbmNgM6AuM8x0Gt7nCSekIga7fzdByMqRrpEXnWCp0V4hyWFEJAEpdrzI0SVumZ2r8WaVDEP1+LyeoWkmiVmC20/P9/CB0C1B0F/hxK5tdWLlkxl96Y0EuSv7hGo8ZZx9jyh1t41ZqN4FugutloxlZc/5+COSRMbfh44CvCGR/YphauEIXzqtey3vPznBBl7iB2jjTMxtHjhhpRBPFlNWxj5GTh7jx/67AAnRX6ADxJDAistb75h5aRGM4V1pYawVIJmicFt9QodxEX4u+UontKWtXJI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000010, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/2/22 6:34, Andrew Morton wrote: > On Sat, 17 Feb 2024 10:55:10 +0800 Kefeng Wang wrote: > >> On 2024/2/12 22:22, David Hildenbrand wrote: >>> On 08.02.24 22:14, Andrew Morton wrote: >>>> On Thu, 8 Feb 2024 10:25:08 +0800 Kefeng Wang >>>> wrote: >>>> >>>>> No need to continue try compact memory if pending fatal signal, >>>>> allow loop termination earlier in compact_nodes(). >>>> >>>> Seems sensible, but...  why?  Is there some problem which we can >>>> demonstrate with the existing code?  In other words, does this change >>>> provide any observable benefit under any circumstances? >>> >>> I'd also be curious why the existing fatal_signal_pending() calls are >>> insufficient. >> >> The existing fatal_signal_pending() does make compact_zone() breakout of >> the while loop, but it still enter the next zone/next nid, and some >> unnecessary functions(eg, lru_add_drain) called, no observable benefit >> from test, it is just found from code inspection when refactor > > Fair enough. I added the above words to the changelog (this material > should have been communicated in the original!) and I'll plan to move > this change into mm-stable next week unless someone stops me. Indeed, thanks for the update, you're so kind.