From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AFF7E7719F for ; Mon, 13 Jan 2025 13:19:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 35E406B00A9; Mon, 13 Jan 2025 08:19:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 30EB86B00AA; Mon, 13 Jan 2025 08:19:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 188A26B00AB; Mon, 13 Jan 2025 08:19:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id EE7946B00A9 for ; Mon, 13 Jan 2025 08:19:34 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 9D40643DA0 for ; Mon, 13 Jan 2025 13:19:34 +0000 (UTC) X-FDA: 83002485468.15.3FF6EE1 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf04.hostedemail.com (Postfix) with ESMTP id 1E92E40012 for ; Mon, 13 Jan 2025 13:19:31 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=elwoZM0F; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736774372; a=rsa-sha256; cv=none; b=UPGLdq1xBHDCTe39iY2bk+LMH4i7qVATsyA1MpUDGA9EsIblW/gxsIs2PP0e+JQ+y0tYzK DKzz/FBMxf01b1lE1/5InNwhDMUN0nlzrl9ifqEwzCSOXUxYFvFsJVnk1WvsoazX1xIRwg v61KVRkJ2HqqKNyvf+98M7Rp/avi19I= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=elwoZM0F; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736774372; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PttcTbV6q4JSNPDitRHrXVO5rJhcJB2dabUIlHPBpi0=; b=tpnSG/YF3MdQVPK+Qy9xC5ru9CDoM3Ckxihd/Bnr4RK9RWLbpA/5WUoX2TO1a9xIn7zpaY KKQOPrMRgbzeH5FqDiV1UEeGScGqQDJdh2RO4un8D/w+7XeieVUGTAHXUI2aFttt2C6VJS F0gTdjw1ahgzzCpF7x3Bh+Z5AW1ki/I= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736774371; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=PttcTbV6q4JSNPDitRHrXVO5rJhcJB2dabUIlHPBpi0=; b=elwoZM0F/y8X9OZbKnXU2PQ3jIsMRIrtkgsB+K18LHqvcbZ4NORklLBbU5UtZUAfF5XzFo LGBh9vQ1Z4vYm3S1t7+ginloTr2ktaprOAEOfCk7oY4/YHQyPLBbq8xLFz0Jk3css1GlE1 jrscc+fL5Hxtg/Uv71vAQRvgwQyqn0o= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-207-GBE1NLkxPbmBMURx0V7msg-1; Mon, 13 Jan 2025 08:19:30 -0500 X-MC-Unique: GBE1NLkxPbmBMURx0V7msg-1 X-Mimecast-MFC-AGG-ID: GBE1NLkxPbmBMURx0V7msg Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3862b364578so2442617f8f.1 for ; Mon, 13 Jan 2025 05:19:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736774369; x=1737379169; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=PttcTbV6q4JSNPDitRHrXVO5rJhcJB2dabUIlHPBpi0=; b=i7RTCMbgABJDMb2HK36wW3gUHlLIbqLOhh5QIAg3ytFP19eJ2v4+2cwSYVbI7fXdvh I6s+0nEjF/Jm8LZHmVTKbPLbou90pqieWuYtQfIn27qpruuvM5m7uGvpOnxYv+CJ0G5K IRMUqnV6xS2n76//vKDOCbUM4IG57x1tpa0CWYDSCBUDJAxpB4UnY17T5yQv8YdMj00Y Oq+avkTxmnK6nF3L417jWXgQgeht0vY4XleK8bSAFJKo033uUTU496FaD9gTfwZizga8 uXHK6eAhOfswzQNsZK4D9fJJcBML70sDW80KjEFKNuG71SCQtFcC3diO+TymSiuKaOlf bJXg== X-Forwarded-Encrypted: i=1; AJvYcCXTCj7rm9zGEzH46yCCsiibotd4Nxoi011Pwia8YeAhUgndSEF4NE1kskhpG2aoLoZLTfw54UuzLw==@kvack.org X-Gm-Message-State: AOJu0Yzsl4vTLZuPY410SA4kGe8+mB6NGGF0Oi1S9OfpDXIxifyHLULl KCsL98fD9Y3ifZH6OyexKHdh1dBn7pQGOW726wBxjJQrBvyvHko9W8cTV8xansWilB7bMPH22yj OuRNUL4T4k/au2P2vup9ZUPEhOEkk8r8ASl2Mp/pBVsIhgKp6 X-Gm-Gg: ASbGncvaDTPA+A4kteV9xRW6TwqxQnFrS8ECunm3VQEsu2Yt71A3q7x3p6I3jSeje9C sCVMHu2zaHeDD2ZpSUd911j74V0R/1hjUIyMy7QpaCv24hgtNNUs+YuZuFMs5RG2Pu/PWt7A0t6 s+FBUNPZbLCl5E2I2d3i3IswYuQr3Vv0KHq+gx6zkZH3dRvXjBi7ldl0ppzxrKZe1NhPhCOF98g qxM8xrfk4YevWQFlJaAIP6x/MNMIkFcjIAUvycdfRExelCfo3gJzugHxzUyejeatE9v7CYI9JXh cPgWTA4ww+KSGxY= X-Received: by 2002:a05:6000:1aca:b0:386:3bde:9849 with SMTP id ffacd0b85a97d-38a8b0caa82mr14308076f8f.12.1736774368922; Mon, 13 Jan 2025 05:19:28 -0800 (PST) X-Google-Smtp-Source: AGHT+IEmrfLkoC0dheFen0KOd3QX1GBKHjDo/69IXQ3IByuhquzkA2mL2+9hUXz910tsz5nN/hQhSg== X-Received: by 2002:a05:6000:1aca:b0:386:3bde:9849 with SMTP id ffacd0b85a97d-38a8b0caa82mr14308054f8f.12.1736774368577; Mon, 13 Jan 2025 05:19:28 -0800 (PST) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-436f9bc6b9bsm53356035e9.22.2025.01.13.05.19.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Jan 2025 05:19:27 -0800 (PST) Message-ID: <296b04db-9524-48f1-9fa1-0b028bc939a6@redhat.com> Date: Mon, 13 Jan 2025 14:19:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/4] mm: Set folio swapbacked iff folios are dirty in try_to_unmap_one To: Barry Song <21cnbao@gmail.com>, akpm@linux-foundation.org, linux-mm@kvack.org Cc: baolin.wang@linux.alibaba.com, chrisl@kernel.org, ioworker0@gmail.com, kasong@tencent.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, ryan.roberts@arm.com, v-songbaohua@oppo.com, x86@kernel.org, linux-riscv@lists.infradead.org, ying.huang@intel.com, zhengtangquan@oppo.com, lorenzo.stoakes@oracle.com References: <20250113033901.68951-1-21cnbao@gmail.com> <20250113033901.68951-2-21cnbao@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250113033901.68951-2-21cnbao@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: zreJi1Y8Jc6r262gPu0_HAzUFKPfnbJRN6rwjRz2-Dg_1736774369 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 1E92E40012 X-Stat-Signature: c7b35es9zr6gdernano3wcfkod36tcjk X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1736774371-483421 X-HE-Meta: U2FsdGVkX1/k777jemeNDko1VUuIJbUJHV6VN0JW/jNRBE/Mpq8L7+4NyxjB2i6zadE3LIhqGxoMW5ToOzvniuMjLFx7g+YklqWMq/I8MWyFaUzJmAuPojN+NApjT2D4X0cAXkFnlMZnXqJiDhAa51FHjNAK8sphi60ghLYi0zikBEvI4VeksVlaffBiUWbcOHpfAH1iyuNcHeYOEO/KFKv4SDd9U94LzQPBPNzE0ojQYU6zuWGlnaG6WSS9GdqwXrDqN1rLEUnRBaRH4TrG7Zi+mVf1ST9mwzwRrL/5v+HzlYkVCPJGlhagz8fUrlAW3Wmml+rGd025icQHuQ0A8ixCeZU2NAoTy2Ui+DeEGMBPdp+ThvP1LXhoWsiSP4K8xkKq4SbV/9wc32/l4cvkuGfTxdCptrgWV506ku++AUYQ8MXA3LXOEN8Maf9Gu7CtyctvBoQ6lpeUai7MpxkHCPwRcmsuAcKU8RHImR3wng+OnA4jjW6z4NShgEZXVtWDwrav87s95dNbF9M4KFGLgO4ct1xLc1LAlFS9QHQSX6D7CjAYJ2EFo871UPyuWcViuIj6wtaxa6WIvYZ0N8wtX4coObVZewcbOxvgjl67eVaD9kFWTLScfwr+lccJanSQtbgFgGzySP4yai5KGebmlZThPwAausTkDoSEJB8Vpengx5ht7wII4qpluCD8ot0+2z37aUsqYOt+Z/IH3BEKbSJpyJytWeLNJwC+Sn0TVQAPPGmOxJLhVcl3nYjHdFfD9oCCQDzIanJDWw1LbBASY9GyFYQdX9k6YJAwYeLpTekUFgclH3tB1g5akeJxJzlV6Y7w2/+GxOGaA5t4F5gmu3PoVJCgfAJsQ0R/njzYTSYnAgHgS9vlOGZgOShVMxGUN93YaX/72FusIol+IzBewMIkFwfyE/SeYGb0LbJ4cEyW0wDDuRhfFnVbgZSqv0OwwRFnhUX5tYzmPlwsZPe uSFt5TRQ pS9tcspl5YICqOJDtu9x7XomSgSbyeJcpZdYGiqMqW12qEIZroTwH3yQ2rfYVTa4B3u6RJtvBxQ7uYwaTEdUqhaM8Wt3Urhvi/JEtpaVqTMSeP0nGISgsWlu7NJWI9FGx7AFEwXAc5bp9m3I7oNrzd7I04zyELR8z4xDhNvR6WL2XkzSNdyizUB1d2w/E5z4C9bgoInM9XScPcNQFMG5JX6/CiXJmhhJQoW4M85j1BcCdHRxovqKaSzFiP44hks5/NGejmZNL1AY9z0DKXpLwjvL9fBLz0kNSgG3S8iZXRNK369jPvk5xJ5AUW6yIyYbt2MjmMtdawvEmmBRjLdc9P3YzJlQuLWlmr6S0/mErOavtGLlSjrcOku5jl9lTuBJwv78F9PkwG2bJW92AvQ9PJMNYjeqMT/L0yNwLxeU7zAMV+8xZeYQVrGQFFjuQmJc7NPRewmkUYfbmwgD4km9kVsL3KbKLIEkuQc8ABI69dLLdOkHDYwC2pbCkKhZkRz2drzdE4bzl2mheI6c= X-Bogosity: Ham, tests=bogofilter, spamicity=0.080120, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 13.01.25 04:38, Barry Song wrote: > From: Barry Song > > The refcount may be temporarily or long-term increased, but this does > not change the fundamental nature of the folio already being lazy- > freed. Therefore, we only reset 'swapbacked' when we are certain the > folio is dirty and not droppable. > > Suggested-by: David Hildenbrand > Signed-off-by: Barry Song > --- Acked-by: David Hildenbrand -- Cheers, David / dhildenb