From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 738E2C47DAF for ; Thu, 18 Jan 2024 23:05:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D9FFA6B0071; Thu, 18 Jan 2024 18:05:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D50BA6B0089; Thu, 18 Jan 2024 18:05:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C17B66B0099; Thu, 18 Jan 2024 18:05:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id B2E146B0071 for ; Thu, 18 Jan 2024 18:05:01 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 8973640740 for ; Thu, 18 Jan 2024 23:05:01 +0000 (UTC) X-FDA: 81693964002.18.A7D694B Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) by imf07.hostedemail.com (Postfix) with ESMTP id 17BC440016 for ; Thu, 18 Jan 2024 23:04:58 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=eSupIJ6L; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf07.hostedemail.com: domain of tim.c.chen@linux.intel.com has no SPF policy when checking 192.198.163.11) smtp.mailfrom=tim.c.chen@linux.intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705619099; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=e++bOFymtIcBODSWDSEq/iKeAIBozwrCs3xF0JYs6zI=; b=m8966Y/3WZvPrUQBSPtvHdmnfiQT0L9DmbV4H/Lw6QcjfIbzsZlgIpPQ6OjT+si7Sz4T0a iAckVh34OUxzinvq6PnqblS09qx3L15V9tmiVpeZUuVzZgUK3XMOZvM0FxA/4baDn8+Kej 6eoXeXXiDEvppJMuDybUQtaqFWiMNFY= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=eSupIJ6L; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf07.hostedemail.com: domain of tim.c.chen@linux.intel.com has no SPF policy when checking 192.198.163.11) smtp.mailfrom=tim.c.chen@linux.intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705619099; a=rsa-sha256; cv=none; b=yk1ddSa3ehaPx7LIocJE5fwRFszopTzB5UT2tQqxXRu8aLRz/WK1uIXu4cN5v+r9Mo1dcF nlJjofnJT+CHYXgESSWyZtpPxEkLjotldnFHrlWDJkh6wh/D/nKAEsuZt0Xm0SDnt+UDxl IPwLIInZY6qwaZsBufqRg7Rle8LsdmQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1705619099; x=1737155099; h=message-id:subject:from:to:cc:date:in-reply-to: references:content-transfer-encoding:mime-version; bh=pXV1Phm7gXXc/IcPaGLWOcCoYm5um13/FmP8uLYS4j0=; b=eSupIJ6LgfyEMkLEcnsEFKggap/0AdcIgFbJE3JLhbuM/yT8qaedSMBK afSNR4+7lQMZGP3Gp1b8h937GDgN5R/N1bubJWkoCR3cig7CPglCP3AKo U+uBcdtplFTSXuO+tYPqX+1nn+ZEpl/1wm+c2mQ370whoPlqPiOSxnJ9t wgWkTl2TcPTmoiuQ5V6Hn1gCWEPKHm72CDpgnnWfaoETqmida/lP7gV7U V6mMav1loVvQ1uC4Kh3JgJ1Z0CxfBbWDFSyrBIIjeoFdjbV0qYJPcmnT5 Oht2sehQ3j7rqjY2Rc2LcVs2VOXU4D2Q4W05uNE1TQv7n63Sh59GvhDL2 A==; X-IronPort-AV: E=McAfee;i="6600,9927,10956"; a="7310172" X-IronPort-AV: E=Sophos;i="6.05,203,1701158400"; d="scan'208";a="7310172" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jan 2024 15:04:57 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10956"; a="784913168" X-IronPort-AV: E=Sophos;i="6.05,203,1701158400"; d="scan'208";a="784913168" Received: from dbhadrax-mobl5.amr.corp.intel.com (HELO [10.209.111.124]) ([10.209.111.124]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jan 2024 15:04:56 -0800 Message-ID: <29695e89ae2d838c9b7537941b0231c3ff559e48.camel@linux.intel.com> Subject: Re: [PATCH v4 3/7] padata: dispatch works on different nodes From: Tim Chen To: Gang Li , David Hildenbrand , David Rientjes , Mike Kravetz , Muchun Song , Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, ligang.bdlg@bytedance.com Date: Thu, 18 Jan 2024 15:04:55 -0800 In-Reply-To: <20240118123911.88833-4-gang.li@linux.dev> References: <20240118123911.88833-1-gang.li@linux.dev> <20240118123911.88833-4-gang.li@linux.dev> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) MIME-Version: 1.0 X-Rspamd-Queue-Id: 17BC440016 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: gt8bfq4fdn9uc9n5b1kh5se375rtn5h8 X-HE-Tag: 1705619098-360980 X-HE-Meta: U2FsdGVkX19nrLcgc3iJbHhT4sDIsobPDTOvqoKpmvi7l+9vR7nq4od5gJoiattJ3Io1MCafxJyPcmifYBA8u/USGGhMBPNVxdwAr7zxY2SN1TOacL9tpdnSYYiUWRS5kvmQDRpG1Ua9mWrP2MvMNHr9upEfmk+J9h6h0YJZ+WUmu1NjsxFhSdanf+4b8oZdYA0XSQc9ys5SalSWiI3r6WyNcHC8MZjnbLveD88EEQRMkSdqWaM1rdNMsAv+z92uIDG3o98iW4cpCRdc1nHNmU8D8QSQfmYnm2yUk8E9uCy+TVpR8r1aIgJeDRy4mnVKZsfp9WUJ8iU+vSLK2Ka40Ld3zT1+I6Z+ZYlr6FNFlxtBcT2O8vz2S+GxRuhK+N3SXR5GPoqa1RA4aPwEUH9Xxn9IB+RPcec2ly7jms69esj6p8s5MBmnr6ZOV0t3ZN26H+yItXt0cCcjV8Lur36VEX3w1JKCkkYzE3NX4S5gUCIGpySlGp8HR4HjAro2DtZPu5PLaNKPmFrnbVIK2xkfV89+OOLy+K0ZvqMD4Eb6T07H949N1CEUlCjfjbqkbHoPsCzgphac8FZnqak2z+oUcuVtboMl2oKYTd4ZBRPsA/l3PST3XmLjw38XDnOjySVu3Zgjt55mIvbX78Fcb0NwWNl7ShzX/XXKdbd2UAuUrSS6SzMpssK05y/vqOBxc5H9Q9DqIa4vFTLIv6Qovb2qOeEaRNXvmutVpoQWjK2utOEy6lkHZUl0jQsLYUIDXSCbLyFjoLwaB3LmTYNmhe+e4GzJLZGnIpZFIIjIt/oSZjlTNlLs9N6e+CMJcy+9XJE411hmcvGaaHLU0jT4h/yapCFRr0e1JC+y+XnzDfEktvZZxVrgA2Y4Yg5rEae/9ulwGqo8yrHpWF/sood0oI8B+Z/b8GPOMzcTKxLDzEHSIJWsdI50wH+D6K+bfEn9w7/uljee4Vf8HRRIdUgbLpn 319xpKWd gM4l6hUsStt2ykmRHk9kwlxGsfXu4wl79d3DjQ8waZ9cFBXhcXkvr8dWAZaaF8vurGUTRJAeGvavOnvZqzIB3DHX63BeOR9kZGOkoALHkixC16rCd3l56YzUmEz1n6ivPF3qJOjuKHKpoPmXYvL9NN+wZCg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 2024-01-18 at 20:39 +0800, Gang Li wrote: > When a group of tasks that access different nodes are scheduled on the > same node, they may encounter bandwidth bottlenecks and access latency. >=20 > Thus, numa_aware flag is introduced here, allowing tasks to be > distributed across different nodes to fully utilize the advantage of > multi-node systems. >=20 > Signed-off-by: Gang Li > Tested-by: David Rientjes > --- > include/linux/padata.h | 3 +++ > kernel/padata.c | 14 ++++++++++++-- > mm/mm_init.c | 1 + > 3 files changed, 16 insertions(+), 2 deletions(-) >=20 > diff --git a/include/linux/padata.h b/include/linux/padata.h > index 495b16b6b4d7..f79ccd50e7f4 100644 > --- a/include/linux/padata.h > +++ b/include/linux/padata.h > @@ -137,6 +137,8 @@ struct padata_shell { > * appropriate for one worker thread to do at once. > * @max_threads: Max threads to use for the job, actual number may be le= ss > * depending on task size and minimum chunk size. > + * @numa_aware: Dispatch jobs to different nodes. If a node only has mem= ory but > + * no CPU, dispatch its jobs to a random CPU. Suggest: Distribute jobs to different nodes with CPU in a round robin fashion. > */ > struct padata_mt_job {