From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F2D1C433F5 for ; Wed, 2 Mar 2022 19:31:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 784198D0002; Wed, 2 Mar 2022 14:31:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 734868D0001; Wed, 2 Mar 2022 14:31:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5FCAF8D0002; Wed, 2 Mar 2022 14:31:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0106.hostedemail.com [216.40.44.106]) by kanga.kvack.org (Postfix) with ESMTP id 542038D0001 for ; Wed, 2 Mar 2022 14:31:52 -0500 (EST) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 168CB8249980 for ; Wed, 2 Mar 2022 19:31:52 +0000 (UTC) X-FDA: 79200441264.23.3B3EE6A Received: from mail-oo1-f44.google.com (mail-oo1-f44.google.com [209.85.161.44]) by imf10.hostedemail.com (Postfix) with ESMTP id 8F503C0004 for ; Wed, 2 Mar 2022 19:31:51 +0000 (UTC) Received: by mail-oo1-f44.google.com with SMTP id w3-20020a4ac183000000b0031d806bbd7eso3071820oop.13 for ; Wed, 02 Mar 2022 11:31:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:in-reply-to:message-id:references :mime-version; bh=0LF1wYKgHjGezYmNOW2QKX7lPQ0zB+QPf5su1bUaiQI=; b=dHUN7IUYd5ZKWsU6tvYnSadpSOPeeS4Ah84ibEIrlidRvozYI0kzmW45Bj63WhCJm6 wN2VyOhRY64li/FXVFny9db5k/YHZR5vLJz35QXV1BuyrGtA+0BsysroIa4cUGRQ7GIv 6rqiTwhkIt3gwF9PqbWfKXf09QfLDYEjYMoXgMTurIP9Fm6iRNoj3KcaUv4cspf2rTie AcxY0FfuqhTKcpxU05NCpqwfwBqXRaXrr+FTNHx7sQRpZKyfqYOkK0T0jYyQ3FhJG5Um tg22kzO3qJ0uFMyin92iIm6ucQI1oGM0k7SI6VKyUbQqEqjy8+1wnt0UfxI0dfoaadi7 Rong== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version; bh=0LF1wYKgHjGezYmNOW2QKX7lPQ0zB+QPf5su1bUaiQI=; b=PRBFuHvZ/QeU39ryb/8h6NwvD92NZlQytEipOYejoFEOE8eY0Y/9JAuDD6CSS6bp50 HhklN/bodjDmr0Uw48RhQK3ZDcxmolDI8WZJ5jTKTyC2oSRdyLQQUvSNIo5URj/dScU+ uWpXvUWZbu8kLnHFvSxS/XviIsf+GP3ZM5CtYWPkLwRE/ltN9ZMB3UpYFP14Pbz1Sewj GE+UBECsZw8qrqWs+BtYTwr7qyk7UZVplGbbBmWAdpD1d3n9O3qE03K9zdRExLlRP8kk WwBVS08axtomgBEfE+Moz3GK8up4d/s9dL94GCaIwQ9ZXJSIJr1u62TuC6vvtSeGsq4v IWgA== X-Gm-Message-State: AOAM530EMaMBsaEAqQIqHoiNePfNSo1HyQLUaOeGG677VtInt+2ZkxIs 26Kqice34YiPBuEh0KPWqvjNeQ== X-Google-Smtp-Source: ABdhPJwIcbIU1qsS/27zriIq/FggmYAL9ikNBq4S6mZN1NZqoaDKIJ1JXVm5UAQ3G+wKESLcAdt20A== X-Received: by 2002:a05:6870:5825:b0:d6:d4fc:aca0 with SMTP id r37-20020a056870582500b000d6d4fcaca0mr1114065oap.73.1646249510547; Wed, 02 Mar 2022 11:31:50 -0800 (PST) Received: from ripple.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id r9-20020a056870e8c900b000d7133a15b3sm4942149oan.20.2022.03.02.11.31.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Mar 2022 11:31:49 -0800 (PST) Date: Wed, 2 Mar 2022 11:31:38 -0800 (PST) From: Hugh Dickins X-X-Sender: hugh@ripple.anvils To: Andrew Morton cc: Hugh Dickins , cgel.zte@gmail.com, naoya.horiguchi@nec.com, mhocko@kernel.org, minchan@kernel.org, hannes@cmpxchg.org, rogerq@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, guo.ziliang@zte.com.cn, Zeal Robot , Ran Xiaokai , Jiang Xuexin , Yang Yang Subject: Re: [PATCH linux-next] mm: swap: get rid of deadloop in swapin readahead In-Reply-To: <20220301163243.33e8fc82e567512e54a78560@linux-foundation.org> Message-ID: <295e8d2-5bef-195f-88ba-abaebd45118@google.com> References: <20220221111749.1928222-1-cgel.zte@gmail.com> <20220225172440.ec62edf97b405d32061bcb37@linux-foundation.org> <20220301163243.33e8fc82e567512e54a78560@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 8F503C0004 X-Stat-Signature: 5crd9dpk4g86ez9krgwcsqg9b5depjen Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=dHUN7IUY; spf=pass (imf10.hostedemail.com: domain of hughd@google.com designates 209.85.161.44 as permitted sender) smtp.mailfrom=hughd@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspam-User: X-HE-Tag: 1646249511-102378 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 1 Mar 2022, Andrew Morton wrote: > > Using msleep() seems pretty pointless so I plan to go ahead with patch > as-is, with a cc:stable. None of it is pretty, but it's better than > what we have now, yes? Yes, I've no objection to that. Hugh