From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F818C433FE for ; Wed, 30 Nov 2022 16:09:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 20E096B0078; Wed, 30 Nov 2022 11:09:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1BE188E0001; Wed, 30 Nov 2022 11:09:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 086676B007D; Wed, 30 Nov 2022 11:09:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id F083A6B0078 for ; Wed, 30 Nov 2022 11:09:36 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id BF6BA1A0963 for ; Wed, 30 Nov 2022 16:09:36 +0000 (UTC) X-FDA: 80190593952.30.E14CBA3 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf07.hostedemail.com (Postfix) with ESMTP id 2267E40011 for ; Wed, 30 Nov 2022 16:09:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669824575; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bZ5C7tU8XWxdCkvCFAowgU3FU/2N0c+MvJiXmJ8D94Q=; b=SdKwtIVrNYLlFW+O4bRyv0i2EBS9EOkpKir47L9KBWdK1pWyzoMBS6oMeZZ+y3wzPIvZQw p344m4+10rTEgTJo0NNdqrl1J+quoQnZdtEnLAguncjFymE6IGr/0El5G4hrPfOWh7mTcF o1IFctDFmatDxcKpJl9ART/r/toUEhY= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-653-1Yj_3-83OsitPwlU-z_GdA-1; Wed, 30 Nov 2022 11:09:34 -0500 X-MC-Unique: 1Yj_3-83OsitPwlU-z_GdA-1 Received: by mail-wm1-f71.google.com with SMTP id o5-20020a05600c510500b003cfca1a327fso9575638wms.8 for ; Wed, 30 Nov 2022 08:09:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=bZ5C7tU8XWxdCkvCFAowgU3FU/2N0c+MvJiXmJ8D94Q=; b=GbgP8V50J2P7YaMTKF8nBov3EBNaxTvKmtsdiHVaYHI5WTh3u2dngY4TDYLcxOlLdA pE5WywX/LWtuggqMoVYDq+vBDqRexZJyyXCRFvqg9huTiPgUCeOyS6IGK6OEQ74xbKhi LnnOsce1UUplA5d7isxHfc6BWFzlPQZZ/lnP9+9pSodFwdYoKpSPLmtvR9xLw7iq+tB+ cizkZM8pTqIOjnFh0rZt9RYH8TFTJRUR2y0Wlh8ECGFQToey55gInlIpE6L5lkfC3Xjg rtRSO/n1kcqlwY73bQKsiMpNPZxdsf6PpCKB7Ohzh1IDErwWgkxb1D9zAvA/D6TH/UXh QdQA== X-Gm-Message-State: ANoB5plCI1N938Yg2QHNtf6/MSaK05xv4B7dD9tSTCaTBd+G0+ZrMmfA 7EiU/pGv1bdAAgLbkM1aE+1srfnunh10HUdB/GdQmjV4TSjQh5ziZjlHNOmTGfzRNAbkFeUzhYh 9Dm+Fy9oz3sg= X-Received: by 2002:a05:600c:1f0f:b0:3d0:2a82:1cb2 with SMTP id bd15-20020a05600c1f0f00b003d02a821cb2mr31181313wmb.206.1669824573112; Wed, 30 Nov 2022 08:09:33 -0800 (PST) X-Google-Smtp-Source: AA0mqf7WFlDmbNW6fPR2lPbq1LUK8mTwnh55wa0sQ5dTS6ZTadKTFEvLARRhTBEtxUvdNgT3SyrJpQ== X-Received: by 2002:a05:600c:1f0f:b0:3d0:2a82:1cb2 with SMTP id bd15-20020a05600c1f0f00b003d02a821cb2mr31181298wmb.206.1669824572889; Wed, 30 Nov 2022 08:09:32 -0800 (PST) Received: from ?IPV6:2003:cb:c703:7600:a8ea:29ce:7ee3:dd41? (p200300cbc7037600a8ea29ce7ee3dd41.dip0.t-ipconnect.de. [2003:cb:c703:7600:a8ea:29ce:7ee3:dd41]) by smtp.gmail.com with ESMTPSA id v25-20020a5d5919000000b00228dbf15072sm1930695wrd.62.2022.11.30.08.09.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 30 Nov 2022 08:09:32 -0800 (PST) Message-ID: <294d0053-6e5f-3599-caa3-4c60a8b20492@redhat.com> Date: Wed, 30 Nov 2022 17:09:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH 07/10] mm/hugetlb: Make follow_hugetlb_page() safe to pmd unshare To: Peter Xu , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: James Houghton , Jann Horn , Andrew Morton , Andrea Arcangeli , Rik van Riel , Nadav Amit , Miaohe Lin , Muchun Song , Mike Kravetz References: <20221129193526.3588187-1-peterx@redhat.com> <20221129193526.3588187-8-peterx@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20221129193526.3588187-8-peterx@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SdKwtIVr; spf=pass (imf07.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669824576; a=rsa-sha256; cv=none; b=IyP3q2zMGYMFPD0lqi9aU8PU+rpI2BO3jdecvCQVBzlL6muMJIY0d5bbqfXUXD09PRsQA6 aKOxK/ok9NvcJFlYVS2yAVOppBLu4jHsE31YWdkNmR1DOKs5ruZ6RVdKWQ3mClLkcE3Srk J8EQtuzwlizEVRWDWMPRjC9LVs6yjPU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669824576; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bZ5C7tU8XWxdCkvCFAowgU3FU/2N0c+MvJiXmJ8D94Q=; b=AdFXA5Y/jABak52wCrB0c/f6hlIgTBbLh/Hc8gCnehK43PtFy2S0fuXmv9uLq1xS3GYmUG +9Kg+RTl11sD2rmPHgDPMe+mZVENLxVPOqVfAJ8twGklZO94XQOi2bF+9RNTfdq3yLjOaI 4PCY2C1eR+bKwDjuZRPQyrnuM0txdAw= Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SdKwtIVr; spf=pass (imf07.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam01 X-Stat-Signature: ai1tarsz4sg8ekefp11xrwx46ka445sd X-Rspamd-Queue-Id: 2267E40011 X-Rspam-User: X-HE-Tag: 1669824575-746775 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 29.11.22 20:35, Peter Xu wrote: > Since follow_hugetlb_page() walks the pgtable, it needs the vma lock > to make sure the pgtable page will not be freed concurrently. > > Signed-off-by: Peter Xu > --- Acked-by: David Hildenbrand -- Thanks, David / dhildenb