From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 865FBC433EF for ; Tue, 19 Oct 2021 14:35:20 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 304B361175 for ; Tue, 19 Oct 2021 14:35:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 304B361175 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id BED086B006C; Tue, 19 Oct 2021 10:35:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B99C9900002; Tue, 19 Oct 2021 10:35:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A61F26B0072; Tue, 19 Oct 2021 10:35:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0196.hostedemail.com [216.40.44.196]) by kanga.kvack.org (Postfix) with ESMTP id 995CC6B006C for ; Tue, 19 Oct 2021 10:35:19 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 5AF5D32086 for ; Tue, 19 Oct 2021 14:35:19 +0000 (UTC) X-FDA: 78713434758.06.0F27D61 Received: from mailgw01.mediatek.com (mailgw01.mediatek.com [216.200.240.184]) by imf15.hostedemail.com (Postfix) with ESMTP id B4368D0000A4 for ; Tue, 19 Oct 2021 14:35:12 +0000 (UTC) X-UUID: 8f4ca49bce20494baad6894570d250c3-20211019 X-UUID: 8f4ca49bce20494baad6894570d250c3-20211019 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1113352660; Tue, 19 Oct 2021 07:35:13 -0700 Received: from mtkmbs10n1.mediatek.inc (172.21.101.34) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 19 Oct 2021 07:33:55 -0700 Received: from mtkcas10.mediatek.inc (172.21.101.39) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.792.15; Tue, 19 Oct 2021 22:33:54 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkcas10.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 19 Oct 2021 22:33:53 +0800 Message-ID: <294ac8c4fa2e7fcad8376a82193b8e2430a4032a.camel@mediatek.com> Subject: Re: [PATCH] kasan: add kasan mode messages when kasan init From: Kuan-Ying Lee To: Marco Elver CC: Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Catalin Marinas , "Will Deacon" , Andrew Morton , Matthias Brugger , Chinwen Chang =?UTF-8?Q?=28=E5=BC=B5=E9=8C=A6=E6=96=87=29?= , Yee Lee =?UTF-8?Q?=28=E6=9D=8E=E5=BB=BA=E8=AA=BC=29?= , Nicholas Tang =?UTF-8?Q?=28=E9=84=AD=E7=A7=A6=E8=BC=9D=29?= , "kasan-dev@googlegroups.com" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "linux-mediatek@lists.infradead.org" Date: Tue, 19 Oct 2021 22:33:54 +0800 In-Reply-To: References: <20211019120413.20807-1-Kuan-Ying.Lee@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N X-Rspamd-Queue-Id: B4368D0000A4 Authentication-Results: imf15.hostedemail.com; dkim=none; spf=pass (imf15.hostedemail.com: domain of kuan-ying.lee@mediatek.com designates 216.200.240.184 as permitted sender) smtp.mailfrom=kuan-ying.lee@mediatek.com; dmarc=pass (policy=none) header.from=mediatek.com X-Stat-Signature: weiqkr6rr8w8fhj3zaxhp91wgc74x5hd X-Rspamd-Server: rspam05 X-HE-Tag: 1634654112-948794 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 2021-10-19 at 22:14 +0800, Marco Elver wrote: > On Tue, 19 Oct 2021 at 14:04, Kuan-Ying Lee < > Kuan-Ying.Lee@mediatek.com> wrote: > > > > There are multiple kasan modes. It make sense that we add some > > messages > > to know which kasan mode is when booting up. see [1]. > > > > Link: > > https://urldefense.com/v3/__https://bugzilla.kernel.org/show_bug.cgi?id=212195__;!!CTRNKA9wMg0ARbw!374SjX0W47zTqp1xJyIg9CW0T7ggAT1rr981lIRBjQhUk2_495ltG_ZkiW6jmeVDBvu_UA$ > > $ [1] > > Signed-off-by: Kuan-Ying Lee > > Looks good, however, you need to rebase to -next because of "kasan: > Extend KASAN mode kernel parameter"... Thanks Marco. I will send the v2. > > > --- > > arch/arm64/mm/kasan_init.c | 2 +- > > mm/kasan/hw_tags.c | 4 +++- > > mm/kasan/sw_tags.c | 2 +- > > 3 files changed, 5 insertions(+), 3 deletions(-) > > > > diff --git a/arch/arm64/mm/kasan_init.c > > b/arch/arm64/mm/kasan_init.c > > index 61b52a92b8b6..b4e78beac285 100644 > > --- a/arch/arm64/mm/kasan_init.c > > +++ b/arch/arm64/mm/kasan_init.c > > @@ -293,7 +293,7 @@ void __init kasan_init(void) > > kasan_init_depth(); > > #if defined(CONFIG_KASAN_GENERIC) > > /* CONFIG_KASAN_SW_TAGS also requires kasan_init_sw_tags(). > > */ > > - pr_info("KernelAddressSanitizer initialized\n"); > > + pr_info("KernelAddressSanitizer initialized (generic)\n"); > > #endif > > } > > > > diff --git a/mm/kasan/hw_tags.c b/mm/kasan/hw_tags.c > > index 05d1e9460e2e..3e28ecbe1d8f 100644 > > --- a/mm/kasan/hw_tags.c > > +++ b/mm/kasan/hw_tags.c > > @@ -168,7 +168,9 @@ void __init kasan_init_hw_tags(void) > > break; > > } > > > > - pr_info("KernelAddressSanitizer initialized\n"); > > + pr_info("KernelAddressSanitizer initialized (hw-tags, > > mode=%s, stacktrace=%s)\n", > > + kasan_flag_async ? "async" : "sync", > > ... which means this will have a 3rd option "asymm". Thanks for the reminder. > > > + kasan_stack_collection_enabled() ? "on" : "off"); > > } > > > > void kasan_alloc_pages(struct page *page, unsigned int order, > > gfp_t flags) > > diff --git a/mm/kasan/sw_tags.c b/mm/kasan/sw_tags.c > > index bd3f540feb47..77f13f391b57 100644 > > --- a/mm/kasan/sw_tags.c > > +++ b/mm/kasan/sw_tags.c > > @@ -42,7 +42,7 @@ void __init kasan_init_sw_tags(void) > > for_each_possible_cpu(cpu) > > per_cpu(prng_state, cpu) = (u32)get_cycles(); > > > > - pr_info("KernelAddressSanitizer initialized\n"); > > + pr_info("KernelAddressSanitizer initialized (sw-tags)\n"); > > } > > > > /* > > -- > > 2.18.0 > >