Re: [patch] fix hugetlb page allocation leak

["Nish Aravamudan" <nish.aravamudan@gmail.com>]

On 7/24/07, Andrew Morton <akpm@linux-foundation.org> wrote:
> On Tue, 24 Jul 2007 08:44:01 -0700 "Nish Aravamudan" <nish.aravamudan@gmail.com> wrote:
>
> > On 7/23/07, Andrew Morton <akpm@linux-foundation.org> wrote:
> > > On Mon, 23 Jul 2007 17:11:49 -0700
> > > "Ken Chen" <kenchen@google.com> wrote:
> > >
> > > > dequeue_huge_page() has a serious memory leak upon hugetlb page
> > > > allocation.  The for loop continues on allocating hugetlb pages out of
> > > > all allowable zone, where this function is supposedly only dequeue one
> > > > and only one pages.
> > > >
> > > > Fixed it by breaking out of the for loop once a hugetlb page is found.
> > > >
> > > >
> > > > Signed-off-by: Ken Chen <kenchen@google.com>
> > > >
> > > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c
> > > > index f127940..d7ca59d 100644
> > > > --- a/mm/hugetlb.c
> > > > +++ b/mm/hugetlb.c
> > > > @@ -84,6 +84,7 @@ static struct page *dequeue_huge_page(st
> > > >                       list_del(&page->lru);
> > > >                       free_huge_pages--;
> > > >                       free_huge_pages_node[nid]--;
> > > > +                     break;
> > > >               }
> > > >       }
> > > >       return page;
> > >
> > > that would be due to some idiot merging untested stuff.
> >
> > This would be due to 3abf7afd406866a84276d3ed04f4edf6070c9cb5 right?
>
> yep.
>
> > Now, I wrote 31a5c6e4f25704f51f9a1373f0784034306d4cf1 which I'm
> > assuming introduced this compile warning. But on my box, I see no such
> > warning. I would like to think I wouldn't have submitted a patch that
> > introduce the warning, even if it was trivial like that one. Which
> > compiler were you using, Andrew?
>
> I expect it was gcc-4.1.0.
>
> But most gcc's will get confused over that code sequence.

Hrm, I'm using

gcc (GCC) 4.1.2 (Ubuntu 4.1.2-0ubuntu4)

I wonder why it didn't trigger here :( Oh well, I'll add some hackery
to my scripts to make it cross-test across all available gcc's.

Thanks,
Nish

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>