From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by ug-out-1314.google.com with SMTP id m2so1537305uge for ; Mon, 18 Jun 2007 09:51:59 -0700 (PDT) Message-ID: <29495f1d0706180951r2b7d0fe1gdcc0158011baf637@mail.gmail.com> Date: Mon, 18 Jun 2007 09:51:59 -0700 From: "Nish Aravamudan" Subject: Re: [PATCH] madvise_need_mmap_write() usage In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20070616194130.GA6681@infradead.org> Sender: owner-linux-mm@kvack.org Return-Path: To: Jason Baron Cc: Christoph Hellwig , linux-kernel@vger.kernel.org, linux-mm@kvack.org, nickpiggin@yahoo.com.au, Rik van Riel List-ID: On 6/18/07, Jason Baron wrote: > > On Sat, 16 Jun 2007, Christoph Hellwig wrote: > > > On Fri, Jun 15, 2007 at 11:20:31AM -0400, Jason Baron wrote: > > > hi, > > > > > > i was just looking at the new madvise_need_mmap_write() call...can we > > > avoid an extra case statement and function call as follows? > > > > Sounds like a good idea, but please move the assignment out of the > > conditional. > > > > ok, here's an updated version: You should always append the full patch, both the diff and the rationale, I think. Even though it's quoted above, might make less work for Andrew to pull in. Thanks, Nish -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org