From: "Nish Aravamudan" <nish.aravamudan@gmail.com>
To: Jason Baron <jbaron@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
nickpiggin@yahoo.com.au, Rik van Riel <riel@redhat.com>
Subject: Re: [PATCH] madvise_need_mmap_write() usage
Date: Mon, 18 Jun 2007 09:51:59 -0700 [thread overview]
Message-ID: <29495f1d0706180951r2b7d0fe1gdcc0158011baf637@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0706181132020.23021@dhcp83-20.boston.redhat.com>
On 6/18/07, Jason Baron <jbaron@redhat.com> wrote:
>
> On Sat, 16 Jun 2007, Christoph Hellwig wrote:
>
> > On Fri, Jun 15, 2007 at 11:20:31AM -0400, Jason Baron wrote:
> > > hi,
> > >
> > > i was just looking at the new madvise_need_mmap_write() call...can we
> > > avoid an extra case statement and function call as follows?
> >
> > Sounds like a good idea, but please move the assignment out of the
> > conditional.
> >
>
> ok, here's an updated version:
You should always append the full patch, both the diff and the
rationale, I think. Even though it's quoted above, might make less
work for Andrew to pull in.
Thanks,
Nish
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2007-06-18 16:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-15 15:20 Jason Baron
2007-06-16 19:41 ` Christoph Hellwig
2007-06-18 15:35 ` Jason Baron
2007-06-18 16:51 ` Nish Aravamudan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29495f1d0706180951r2b7d0fe1gdcc0158011baf637@mail.gmail.com \
--to=nish.aravamudan@gmail.com \
--cc=hch@infradead.org \
--cc=jbaron@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nickpiggin@yahoo.com.au \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox