From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7AE89C3DA4B for ; Tue, 16 Jul 2024 02:38:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 07D416B0099; Mon, 15 Jul 2024 22:38:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 02CEF6B009A; Mon, 15 Jul 2024 22:38:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E36E86B009B; Mon, 15 Jul 2024 22:38:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id C413E6B0099 for ; Mon, 15 Jul 2024 22:38:03 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 6D531140308 for ; Tue, 16 Jul 2024 02:38:03 +0000 (UTC) X-FDA: 82344056046.30.F346BD6 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf03.hostedemail.com (Postfix) with ESMTP id F1EBD20016 for ; Tue, 16 Jul 2024 02:37:59 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=none; spf=pass (imf03.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721097429; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DIrJpR9o6R74mF31jeeoA5sV6adQAmwbQef1tih22Lc=; b=l2GH4oo1btST49g19ed7walBtSiA6LVEuWwjQlIgYHJ0ia7rIy9q523TUBy38LMPUgARsl WdDt2lrwi81aA6x6TYyPvUdJ5YTTE/VyA7LqnZTJLywIvCFvI8XxVU7gjcW+eyrXe6Kfsq PggHF8QLjUuh9c95ZkOqwlG/fsPEsPc= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=none; spf=pass (imf03.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721097429; a=rsa-sha256; cv=none; b=Xy5QhTxtUTL53zftcAgXhnyENi54yzlZvOJ2Kdi8YuY6LJqiiu5uxtKU7gUrpU7vHNTVQU vC/VUq8EdWZrSFB717X2SxrEfY7HDnnbWat5jBOo7hcPS2GKT1WaC94oyVHLLIGtS9eGEH Lw8MjoHovdNB/acRIRhiribe4RAjzgw= Received: from mail.maildlp.com (unknown [172.19.88.194]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4WNNVN1zJFzdhjF; Tue, 16 Jul 2024 10:36:12 +0800 (CST) Received: from kwepemd200019.china.huawei.com (unknown [7.221.188.193]) by mail.maildlp.com (Postfix) with ESMTPS id 60AA0140FC8; Tue, 16 Jul 2024 10:37:55 +0800 (CST) Received: from [10.173.127.72] (10.173.127.72) by kwepemd200019.china.huawei.com (7.221.188.193) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Tue, 16 Jul 2024 10:37:54 +0800 Subject: Re: [PATCH] mm/hwpoison: reset hwpoison filter parameters in pfn_inject_exit() To: Andrew Morton CC: , , References: <20240715102806.2638849-1-linmiaohe@huawei.com> <20240715133338.fb8b3b9a99f05b086fc54b82@linux-foundation.org> From: Miaohe Lin Message-ID: <29487e61-8785-0064-6208-5044b6419c9c@huawei.com> Date: Tue, 16 Jul 2024 10:37:54 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20240715133338.fb8b3b9a99f05b086fc54b82@linux-foundation.org> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.173.127.72] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To kwepemd200019.china.huawei.com (7.221.188.193) X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: F1EBD20016 X-Stat-Signature: j7omtei6on5t45nj93k33jk6dc3gpa9h X-Rspam-User: X-HE-Tag: 1721097479-344948 X-HE-Meta: U2FsdGVkX18BicMZgK6W27MbsXCmAReIfsnnvRV2NHG7UEnPAP/kkt7/klkAHuR9tsPiUKycjdpFYP+Wjxwa1TgQ2/SeAqPaWVE9bdHbIzr/CyCh5v6YZ4v+0xYNStcxexyBJcuH9/3RCwxI9LuXLLQpyOmtSmHbUFfAyWvKhriKIsFcgquHe08sXnJmprvK/06pKDEmC4C+DkeiDz6uRewSMxrKpEXi0EnJYCGnqV8Q2H1wcIRtAoIOnneesMxb0eSyA7KXD+Yf6oxD6l+Bi90yfZEH9wKaJ8MyUh5BctNpwJ7/24juNI7j3bg1gI39xVxpzmTWpzX7UDHPfcs/Eld7sRz7PWldG1okzbNpHeWIcxYM72+hvXHVObjAmw+fuCCo7uRSGyIXwr+5LP2rdfpvl62qNMxP4GiyLGMa5TyX8v3nT5AhSkbGrKLc6YrO6AQriXKq+zhkeAjqmcPEZq0uz7DsdT0ffVzzseWVWzpDdba7LMzj6uds4CA3VCX8PrcVTJst2yhCaHG87DUZ8hj3JVKOGNo22VUE4zwn5nMNYa8MhLnKBiP6WQo2PDz7OkQpmXRmu2LXRCyv4evwmaBRVKULldW+uPspslrFsmXgkMWxaOCol0RTm0uvSheM4e+AkSsEaS+CwELfv7ESwvlYZDE5mFr8HjgFhlUSRbbBLNZrvsgHWFyYOrJBRL7eyuAHvKNwqAvONe96ygn9e1WRzUznvqMLMsmdOZAh1oV+2OenbSAwHHlk+FGA1RVboBSkc6cf88FKcCgPws0FcRdPKSWMldV5sp1MFfS7RQiKkZSdpl/w6jo5khsRIznBsEDM3ejoGtGamHaYJuo7D5B2x+lANT6Leeeya9w49gIeahRDORKGZ8OHYNOqY41BBBdvzQLyjqg2dMk0Cg/1BEquP91QyN8kbl1BQ5/DcoDsqIkzcRflHtnewA0WSIflpzPA0U4oSp2YF/TSYKv zw8BB9WS zoUDIDj8Fh9kJRbiu/RkJ6GnnK9vcqUOr81kwqJeHVcgjf10thIRC3xIP2JH7QIEWJX2TJ0WugRMJ5fSWuqWkXtNksmNesDclSDCE8qR/3wLKR5VsFEXXVvR4jpjs/WsHEYRW61u+khYnDZeBqrwbdnSv2HdUtlgktj3bsUh6FXiSMF1QnLzRkKD/fP2mjhOEPSYphiWKtMw3x/F5v5k5l0yXREXRtrVjAwem2Qlol8WIoL9pbmIHWCidEmdeYcU4V5AGJsNYJmwx3SKjEr+g90YV3w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/7/16 4:33, Andrew Morton wrote: > On Mon, 15 Jul 2024 18:28:06 +0800 Miaohe Lin wrote: > >> When hwpoison_inject module is removed, hwpoison_filter_* parameters >> should be reset. Otherwise these parameters will have non-default values >> at next insmod time. >> >> ... >> >> --- a/mm/hwpoison-inject.c >> +++ b/mm/hwpoison-inject.c >> @@ -64,9 +64,20 @@ static int hwpoison_unpoison(void *data, u64 val) >> DEFINE_DEBUGFS_ATTRIBUTE(hwpoison_fops, NULL, hwpoison_inject, "%lli\n"); >> DEFINE_DEBUGFS_ATTRIBUTE(unpoison_fops, NULL, hwpoison_unpoison, "%lli\n"); >> >> -static void __exit pfn_inject_exit(void) >> +static inline void reset_hwpoison_filter(void) >> { >> hwpoison_filter_enable = 0; >> + hwpoison_filter_dev_major = ~0U; >> + hwpoison_filter_dev_minor = ~0U; >> + hwpoison_filter_flags_mask = 0; >> + hwpoison_filter_flags_value = 0; >> +#ifdef CONFIG_MEMCG >> + hwpoison_filter_memcg = 0; >> +#endif >> +} >> + >> +static void __exit pfn_inject_exit(void) >> +{ >> debugfs_remove_recursive(hwpoison_dir); >> } > > The new reset_hwpoison_filter() has no callers? I'm sorry but I can't figure out why that's missed. I remember I tested this patch and queued it... Will send a new version and re-test it. Thanks. .