From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2195C00140 for ; Mon, 1 Aug 2022 02:33:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1AB488E0002; Sun, 31 Jul 2022 22:33:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 15B128E0001; Sun, 31 Jul 2022 22:33:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F3D4D8E0002; Sun, 31 Jul 2022 22:33:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id E161A8E0001 for ; Sun, 31 Jul 2022 22:33:39 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id A7541A0224 for ; Mon, 1 Aug 2022 02:33:39 +0000 (UTC) X-FDA: 79749452958.09.99F93C9 Received: from out30-44.freemail.mail.aliyun.com (out30-44.freemail.mail.aliyun.com [115.124.30.44]) by imf27.hostedemail.com (Postfix) with ESMTP id F160C400F0 for ; Mon, 1 Aug 2022 02:33:37 +0000 (UTC) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R371e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045168;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0VL-EnUW_1659321212; Received: from 30.97.48.40(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0VL-EnUW_1659321212) by smtp.aliyun-inc.com; Mon, 01 Aug 2022 10:33:33 +0800 Message-ID: <294083c1-2049-350c-52a8-5a39a7a7d229@linux.alibaba.com> Date: Mon, 1 Aug 2022 10:33:41 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] mm: migrate: Do not retry 10 times for the subpages of fail-to-migrate THP To: "Huang, Ying" Cc: akpm@linux-foundation.org, ziy@nvidia.com, shy828301@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <1658405108-100658-1-git-send-email-baolin.wang@linux.alibaba.com> <875yjhoj7g.fsf@yhuang6-desk2.ccr.corp.intel.com> From: Baolin Wang In-Reply-To: <875yjhoj7g.fsf@yhuang6-desk2.ccr.corp.intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=alibaba.com; spf=pass (imf27.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.44 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1659321219; a=rsa-sha256; cv=none; b=nnniVe0mPxNGr3XOydPrQm+elSCysXZsi1oogBm6cK3QRnkc/61MZK0wJOMLABCaKmh1Jc 67hYjxbyxdSkMfshA//WsDdBQsSpRWTOZ+QqZW85/nbKQSfPWvp/AXQmT+v4xOX9nrbEzz DxRyPTsV0L7gmgyBqIn0Nwh/y+gT32E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1659321219; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/f3/wAc/Lh5OKIv9YiPTMenQt/5WuXTmiolPCixw+jY=; b=6Wsh9q4jejIjOnGnGWef02oZeNw3pNqARq8zv7gbN4wqGvUGbR+iVUVfdsQIZv1wTIVBYb 4x/ddEqUQ/GRnQX0LPesOiZZCTU8uaZ/815LZZE7EcUQAX9GPDtH85laGoqwYtHI+rEX9E 4X5jgkojzWcqgpo9c5Gy0GqjRL6DQC0= X-Stat-Signature: dntbmso7x1mitchw4s5fsp5yxkmzp9nq X-Rspamd-Queue-Id: F160C400F0 X-Rspam-User: Authentication-Results: imf27.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=alibaba.com; spf=pass (imf27.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.44 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com X-Rspamd-Server: rspam04 X-HE-Tag: 1659321217-296712 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 7/28/2022 2:16 PM, Huang, Ying wrote: > Hi, Baolin, > > Baolin Wang writes: > >> If THP is failed to migrate due to -ENOSYS or -ENOMEM case, the THP will >> be split, and the subpages of fail-to-migrate THP will be tried to migrate >> again, so we should not account the retry counter in the second loop, since >> we already accounted 'nr_thp_failed' in the first loop. >> >> Moreover we also do not need retry 10 times for -EAGAIN case for the subpages >> of fail-to-migrate THP in the second loop, since we already regarded the >> THP as migration failure, and save some migration time (for the worst case, >> will try 512 * 10 times) according to previous discussion [1]. >> >> [1] https://lore.kernel.org/linux-mm/87r13a7n04.fsf@yhuang6-desk2.ccr.corp.intel.com/ >> >> Signed-off-by: Baolin Wang > > I have tested this patch, and it works as expected. > > Tested-by: "Huang, Ying" Thanks. > >> --- >> Note, this patch is based on the patch set [1] from Huang Ying. >> [1] https://lore.kernel.org/linux-mm/20220711084948.274787-1-ying.huang@intel.com/ > > Please this patch is based on my patchset that hasn't been merged. I > can add it as the last patch of my migrate_pages failure path fixing > patchset if you don't object. Sure, please fold it into your series. Thanks for helping.