From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5A83C83F16 for ; Thu, 29 Aug 2024 16:16:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3A31E6B0085; Thu, 29 Aug 2024 12:16:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 352F96B0088; Thu, 29 Aug 2024 12:16:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2421C6B0089; Thu, 29 Aug 2024 12:16:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 084296B0085 for ; Thu, 29 Aug 2024 12:16:58 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id A3D79120E1B for ; Thu, 29 Aug 2024 16:16:57 +0000 (UTC) X-FDA: 82505786874.30.32F63B5 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf09.hostedemail.com (Postfix) with ESMTP id 0B66114001B for ; Thu, 29 Aug 2024 16:16:55 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=rBwpJXxC; spf=pass (imf09.hostedemail.com: domain of broonie@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=broonie@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724948195; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vIfDg6+86JXqFZXXwkgT2lAhGXfy0iYhn+O9aNgu0II=; b=yV/9PCmU6+1w8Aeit5fDOxXRSI3bpKlmgUZMJvg/i8nXUTu1r1teLbhXQkN+q53J/+RRcV fN709aOgBVE6bMQ1Sb/AhBHJHehGgKfb4PlAhVqzJSnKIf48yN9AuPSUvWrGACtbHMXX+5 ENv+QKe3NgDtYxyzU2AkhtdVybOindo= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=rBwpJXxC; spf=pass (imf09.hostedemail.com: domain of broonie@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=broonie@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724948195; a=rsa-sha256; cv=none; b=G/MSZFnRnM4HdYWafgJAbNnoAN0jj8FbrPePrCmtBJj/ECWjZl1STQ5CK0bwhsXzRjfHxX JVsmQJ/xyxYdeGNXmReIZ7UEFDXhsWsXR8DUhIkwY9ISzY/3a8GA+0d3hdzx1UaU6SjX/i 9KaoedpGr/ISbJ03YPvy3zjGZN+iUEw= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 50A08A40099; Thu, 29 Aug 2024 16:16:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 26529C4CEC1; Thu, 29 Aug 2024 16:16:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1724948214; bh=vIfDg6+86JXqFZXXwkgT2lAhGXfy0iYhn+O9aNgu0II=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rBwpJXxC475L6gtzuSz0dziTR5saTkGcwJxmo7V8Q2lrUcg+ksrAQbw2EjSzNKMHw OhnKb5N9icz9xx9wkZhSye6k4LIy2dXBykbZfUBLgDsoFAhrTwVEi/1ryhdpqex71s yK/jN4SGf6gby76+vFiCkQOh8NsC11KjAtiNQnsMWYAEzy4SoRqE4voAb6IBnmpXnP 5FB9tUdnPLesZtQzfmhC88Ouao1uwAoJBrB1WLNyWsWfqzpfDQcpJ+yeP8Us1pnP8m s7N3tCNrQNoPpTQmkkJa5jyTLj5bzxZvShcKrCG/a3kDra1kW7rWCsvL4dKT6XjGnK dSjGRJIg6NqLQ== Date: Thu, 29 Aug 2024 17:16:50 +0100 From: Mark Brown To: jeffxu@chromium.org Cc: akpm@linux-foundation.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, linux-hardening@vger.kernel.org, pedro.falcato@gmail.com, rientjes@google.com, keescook@chromium.org Subject: Re: [PATCH v1 2/2] selftests/mm: mseal_test add more tests Message-ID: <293ce8ff-10c3-46b8-a56b-a1bddc7aa37c@sirena.org.uk> References: <20240828225522.684774-1-jeffxu@chromium.org> <20240828225522.684774-2-jeffxu@chromium.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="fk2NVf2lDvQOFni9" Content-Disposition: inline In-Reply-To: <20240828225522.684774-2-jeffxu@chromium.org> X-Cookie: Baby On Board. X-Rspam-User: X-Stat-Signature: qtpm3dehekjktju9djq789tde4ubs67x X-Rspamd-Queue-Id: 0B66114001B X-Rspamd-Server: rspam11 X-HE-Tag: 1724948215-698812 X-HE-Meta: U2FsdGVkX191fbXzaongVt8n+M2M62TEJxLEYVlRJBR1xVfRxlM/gnyBA0uIE5/SNhyAEzaOYTYdsEUSsGRS3Xi6O0Nooe3z6vrGxDaPoCAT9pBslmXrWeWSvhQeekYZzXwMM+7A/QRL1kPyCwy6ufsp+d3Efw8as9ds5K/yPWnS0jQJID+VppyyfJCUmArvYegMeQmN9rEHhjOQNy10Xv95FtpQhM7AyJG8J+N/xl9AHmzLzUA71ZpxR68BT1+0BXOj+gBQhzpp09a8vVXUxcIlWvsqrPJqe0/mTayy5LoNfjXZw2cJO+QKEkVM/CXouB4oUSQ/VlzPtmDNG6BFcjbyHCnAKhiUeGV6aSbZgKm8/VRVlT/c3bReGsi0pCunXfNjf0J/DIFo+RS+uqSIVM3R2EKB8eisIgaQ8pRpVxVSdcz2A/5DSr8K1Z+8koUXgULonlrMFboxk1cnRbca4vkFs/hjx4EgByce7ufTIinqWdaDNRvOMktKh8RD03RgbmwUOR+F8PhCPEVCf/57Xtn45bzQxJm2hq+H7OckeVF/M6DA81lQKgbLSGqYm+G7dawxA8o5XsIzvwvqfn/j/Qmt94S54E50Ta2j1LAUtnUz0nWB7fKr8nNEEjC8e6wvHlFk0pdYz5Hu1NuD/r4h2/9xM0FxhzYXVJIQsXkzzh3DdY0Xf1ctSyY/hYHRMM+4mm43CweEbQs3R+l8zzOmaqqKIVh0sG4b1kAj52cSbV3tdwaYtrHTdJwO+cfSETopRg51qKaYGns0Ho82uMpEfBKJ0M4kErQaxD16UcHiev6O3uPDmp/sbNDbqYjM2/laHp2A+P4V4WqpTmh8CSPBmJprJkdy5fiNry+B+rsbvLwD2IhRCdRANKx1S/17QJ0iDLwifvkv/Z7Q+nDL1IeH7UrqaoASKgXBwk45V+0KBk0gofvRa7noPJYuryOEqlBjV1jcMT4GBlXB94zLKez gqUWt6X5 ody1nuTd8BCW/eZ/HLXZb4nQx4AYxLY4dcxDzxHCxm+Eig03U0NpZG63iCeAdUHbF8THa5X0u3Q27RG7T3kDzwT0ksDtJtZYTdj27PHRhBzXXKDmTQgVfYgxKAWOnjQSCa3RyQYEhB6UfRMrckDuCSmMFO6R3bVjyP7U9z2NAPNBO8B/KCMoYSyvK/EmMTkSABQ22xUoeMzXsvHqDD8dWLtWTrrOCS2aPWdpJWTpV2cv/jhMnnvsP7mmXsC377BvV9jBsKTwfbN746SxJH3iyWxXCbsqy0LTAlB7mJAC+RJYLFeQdqEgv4XvUOnNkRLNqeHl0wPf7EJQmATnVmCd81MEqlcmOErpx77zUamDxnNiCgYRLEgHb9t+vXjncsrBmj1zHok4CBvBiyaqZVIFhP36rCPaBxR86ijArtjc5qawVSzl7//Ep8EDdnx7mLhfVoC4OQpawcdyxMDn1nSDTRjBUM0Q0wbzYzi2vW6fuN2CMGZc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --fk2NVf2lDvQOFni9 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Aug 28, 2024 at 10:55:22PM +0000, jeffxu@chromium.org wrote: > Add more testcases and increase test coverage, e.g. add > get_vma_size to check VMA size and prot bits. I think this needs to be split into multiple patches, for example the new test cases done separately to the additions to the existing ones, possibly as multiple patches (eg, should the size changes be split from the prot ones?). --fk2NVf2lDvQOFni9 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmbQnvEACgkQJNaLcl1U h9BvhQf/Vi/ekKe6Yq/5eKAJnz2APhu40fJaFN87eHbuBkbXvvVWQqasDXn7h3VU OVWDdiFk3j95VYErDfiZSG3XckxdzYwzjSIhSvtrVrst85zuUxD7CYcT00e9vaK1 EX2ZrrFPnD8SwbtEmK5OsPllGkQNi1GdyDwUs1x+kw/nO/A75bwKKluBj1aCAtP0 FDHTSCtfGIDV61U/7CbfxpW6ucPqcjOrWiVIflRDGaEz9C+PSBOO2WjxtTa0cWbj VJZeof3ubm3OijFV+fUplRewFUjG3HXZY3a1fEGJ+zb5frQTzqxSSx0umHLnyesh 0JamzgLhg4JjPBkC2lZAXId9gMXGzw== =69gj -----END PGP SIGNATURE----- --fk2NVf2lDvQOFni9--