From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BA8EC7115B for ; Mon, 23 Jun 2025 14:01:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E20CB6B00BB; Mon, 23 Jun 2025 10:01:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DF8CE6B00BE; Mon, 23 Jun 2025 10:01:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D0EEF6B00BF; Mon, 23 Jun 2025 10:01:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id C077E6B00BB for ; Mon, 23 Jun 2025 10:01:54 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 7B6651211A2 for ; Mon, 23 Jun 2025 14:01:54 +0000 (UTC) X-FDA: 83586828948.25.17BE5CC Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf09.hostedemail.com (Postfix) with ESMTP id 28760140021 for ; Mon, 23 Jun 2025 14:01:41 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=feJywIrm; spf=temperror (imf09.hostedemail.com: error in processing during lookup of david@redhat.com: DNS error) smtp.mailfrom=david@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750687301; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=y7Ci6GAY7NgNa/wDuDrw3HTWAKtIQSbtFXEH8SpJlTM=; b=feJywIrmVCBVbVK+I9Q7VsfH8kD8wb3WBsm5I/2oeFUpaq4KfABsNmvGK+YSZ4YSU7SetL EV7PfG55w03jRcFwOLShRnV7R8yVmAdNl0pSFhv+YTGglXznbEG0jkvDKNIekmPGBdNymj IfqYAznBxpeBKc5uQRneyJSHuR0W7Ms= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-160-MM_-uHAnNzGsAl2ejO0R5g-1; Mon, 23 Jun 2025 10:01:39 -0400 X-MC-Unique: MM_-uHAnNzGsAl2ejO0R5g-1 X-Mimecast-MFC-AGG-ID: MM_-uHAnNzGsAl2ejO0R5g_1750687298 Received: by mail-lf1-f71.google.com with SMTP id 2adb3069b0e04-553decb7e3cso2600186e87.1 for ; Mon, 23 Jun 2025 07:01:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750687298; x=1751292098; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=y7Ci6GAY7NgNa/wDuDrw3HTWAKtIQSbtFXEH8SpJlTM=; b=cT/MmVtHHEYeQBgb+wfaWqHA6hOhTlzOQxs44XViPeu9BA/qRYzx8rZ7JzOTg3+PK1 QMuEAdWNqy8RgJnRHoyQg8r9eYLnV/0UoC7ZgNk/iFo52g60iD4o5RN43lDkckWRbKSf 9WTJAO9aL7tFvnJbwet8ldNZzVXVfK11ymOogIfyyv++9OCYdeOKWwjttwqYmgOwllPG QObIa5nTQ+Ei13tcx6WaA+Q/zm3onr+G3tdwm8fL5QTCg8ksz9vzr2UZVzOuVM89YPuu sobVJiRtEJ9fs4y1jWKAm+F6ZuUHZNxOYoZ+HT2pYT3RgSIqXfNYEoD7v4f/bxZOMflz 9JUg== X-Forwarded-Encrypted: i=1; AJvYcCVzsrcMntcEyJwqwOVuG0Q1NrhA+FSdpH/fSa+WI26M0pwjScLE8MW60qa9OGOPw7BQlsVun3vewQ==@kvack.org X-Gm-Message-State: AOJu0YxV/YgmmOgnruKZVX1EleWoqtLiZAqVIrKy7xhEZXOgwR6nsobX 3CKb7ywrFVYsMkyUprU/My8siDVrCdRoRuHRhPvHs/P13uaCAuLZma4w0tqeJAEmVq/4Q6/WH5t DkgQilEjhIGo5UlVnZmez8webyJ4BdfYJ03E14+G+CGJNeWuYm5oB X-Gm-Gg: ASbGncttF7STFaGKahWFUHWel9f86I0MynABxdsBx54vqUK5bpIBF2ulqqQRAfDZNeI TS6ePVfDM61JVmQolKC1Fron5pSv30iBUVdpjfMYx7V1VRbmYyFcImpUi6bj6XJwLPQt5vhKbt+ JWI7oSQEBF0c5sLonn0Rh5Vp5ZA+oFloXmMFFrSmnMHm7/8cb5PczNq8FHks80EnuxAQLaJC3FF rKtgnjHPfptnBVFQWCUVWYWyOtuQ3TVWNNbFFGsjxAoxsBzjtj+zrOQxY5ootobSQqBgSm0vukZ zVLgjue/zsA64Cln2D3bDwa2bZP7qtAt8/af9PfMt3S8vtWKdpbpyg2Vjo2KvCJUoFdVcuc5a0X 10CHIecI8jBMCdvXNLWtxkqH752/BlVyQ2sSGdfQANMAEMoxaxw== X-Received: by 2002:a05:6512:3f19:b0:553:cc61:170b with SMTP id 2adb3069b0e04-553e3b98f84mr3747069e87.10.1750687297707; Mon, 23 Jun 2025 07:01:37 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG89Rz9PqrL0f3vMDfXPPWwQBkTuKiA1M8G8745Tdu2WmKymzZAXhOuTGumkLVsU5sTP1V8JQ== X-Received: by 2002:a05:6512:3f19:b0:553:cc61:170b with SMTP id 2adb3069b0e04-553e3b98f84mr3746924e87.10.1750687296534; Mon, 23 Jun 2025 07:01:36 -0700 (PDT) Received: from ?IPV6:2003:d8:2f4e:fd00:8e13:e3b5:90c8:1159? (p200300d82f4efd008e13e3b590c81159.dip0.t-ipconnect.de. [2003:d8:2f4e:fd00:8e13:e3b5:90c8:1159]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4536470903asm113858015e9.40.2025.06.23.07.01.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Jun 2025 07:01:35 -0700 (PDT) Message-ID: <2930133f-371d-4846-968f-6137ae1b3156@redhat.com> Date: Mon, 23 Jun 2025 16:01:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] khugepaged: Optimize collapse_pte_mapped_thp() for large folios by PTE batching To: Lorenzo Stoakes , Dev Jain Cc: akpm@linux-foundation.org, ziy@nvidia.com, baolin.wang@linux.alibaba.com, Liam.Howlett@oracle.com, npache@redhat.com, ryan.roberts@arm.com, baohua@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250618155608.18580-1-dev.jain@arm.com> <164d06b5-1640-4b0e-bc60-cd886bc5a98a@arm.com> <023a65d4-5f69-42fc-ab43-b73e44d6cd10@lucifer.local> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <023a65d4-5f69-42fc-ab43-b73e44d6cd10@lucifer.local> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Yk8gQLbGfywW6XI-yTnlhXxqtffIyuIMPJHFMKGvFE8_1750687298 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Stat-Signature: oncugtnnydywteiqmkkifir5cnwyhwua X-Rspam-User: X-Rspamd-Queue-Id: 28760140021 X-HE-Tag: 1750687301-823498 X-HE-Meta: U2FsdGVkX19SAhgz4lt0mqq8vq/hA1qOW56c0Yc2cTpsYuKW+t0yHzbom/xcNTHtLDqHfiGR/O0PqeDp7qAB+jHBfG5kx9hEsb3kvNazY/+9IlwVPZP7CRMtwORDJSVNJSqvjSeBpTItdnp2A9XHPyKkFyum4lXjPRIb4PxQygmEmV5CXT6I8H+K2VfqHBRCnnzF+p0I7MFB+aG1QRvoFC3N4KYAH/N9ojdgZpaapJ425jG/5NrWFZP+aunKPw6lOeT2NGryIw0u3CzSuiXsZJzSwT6a8YfmrpKcwGn8mxrStKnV5z0DA42+24jZ0tK13y9p/jC9LxEK7E3fNEiR+41dxIVXFGIuGUcYu5KLM7RUOWm2ilY3FSzVjfewYlPREKcReJtuUJw7anxu8SwhZLi2LAXurX2/qkprjETEyR7hVJFZ2sEh4+R+1PN6JFMDA8jd2NAPBHTQhnpLYXOA28j+BvMaz/xG545HMN0GMW27HXIXLPt52wbmW99kL2bnecSOQMetgU/OQ+KvL4CeH6AD1YeewETBql4Di1d8ho9D0a/ecYMgP5obWUzzfmctU7QEcjDYJX03ih6zY+0e6qT86tULNXt4GSMz85L63fD7SJzYq/GhrgX0lex+ep1Bq1WCBN/n01xLMUkqhlUmhVFBEcTJcgGSqZZBr+iHTFwvACcoj6ecM4vHPo/ZZOfal04WNY1KqPQzluP72or6mvDQqVRYSDC2fXCCtPG0u4Bd+2NC7J2WO8+cHHttkFxpLNw27LmTAiRACy3Clz8cS313+tBtUPswpyDHtUu3bgY7+gBg4KA7p1M83YNX8uteINKvoS+5U0wc4f+AzNPbx8jV4lxi9SBdONgLTXbkfgarK6OnSA3JvT6988Le10HOwxL4jm02S1JhcRqbUiZ1qeT+QMGXyMojs/CVzADaq+Dl5+CiOj7NoZHThndVyp6cp0l2bxWeoLTjZj9k1v2 pD9Jv2S9 yR+uC+/27stZs0gOr8L/pnNuCtpiQuGFngazCmqdcA3LayieLCMZLq2eAMkIy6+w7aimzsW0LCwcX1ExBQnPBI1gjk7hLvBduH6ySRElrYMwnvdmXIhIOrjOGbkji/Sk9nYxewNEh4V9Fz/MXDldFsejsaf6UkggvJnsVRnsiiGf1PCvDkHNibZzm3ovbO6mpZk4rSTDnuel5Dfk+LuLbv8112/8hqyj1wdFLvx7/qnIW3X9mMOYPecqur55ReHtmrAITpPelKG6vP5z8nFvXN+kTn7+v4yJKhfRvhCFKLV5E4KK++fVeQS/h1AOkGUdaHBkNvh8Tj30/IJAOKNMIGXrJ9AOBH6H7wjto X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: >>> >>>> mm/khugepaged.c | 38 +++++++++++++++++++++++++------------- >>>> 1 file changed, 25 insertions(+), 13 deletions(-) >>>> >>>> diff --git a/mm/khugepaged.c b/mm/khugepaged.c >>>> index 649ccb2670f8..7d37058eda5b 100644 >>>> --- a/mm/khugepaged.c >>>> +++ b/mm/khugepaged.c >>>> @@ -1499,15 +1499,16 @@ static int set_huge_pmd(struct vm_area_struct *vma, unsigned long addr, >>>> int collapse_pte_mapped_thp(struct mm_struct *mm, unsigned long addr, >>>> bool install_pmd) >>>> { >>>> + int nr_mapped_ptes = 0, nr_batch_ptes, result = SCAN_FAIL; >>> NIT: I don't know why you're moving this, and while y'know it's kind of the fun >>> of subjective stuff I'd rather the assigned values and unassigned values be on >>> different lines (yes I know this codebase violates this with the pml, ptl below >>> but hey :P) >> >> To maintain a reverse Xmas fashion. Now I know that the declarations are already >> not in an Xmas fashion, but I wanted to make sure the code I change maintains >> that for the part I am changing :) > > We have no such requirement in mm nor do we particularly want to establish any > conventions around this. Well, if we already do have reverse xmas tree, we tend to maintain it ... or when adding new code. So in MM it's actually very common to do that. But we avoid doing that just for the sake of it when touching some code. -- Cheers, David / dhildenb