From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D09EC531DC for ; Fri, 16 Aug 2024 17:56:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CD2748D00A4; Fri, 16 Aug 2024 13:56:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C82818D00A2; Fri, 16 Aug 2024 13:56:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B4AB08D00A4; Fri, 16 Aug 2024 13:56:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 95ED08D00A2 for ; Fri, 16 Aug 2024 13:56:02 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 45B19120166 for ; Fri, 16 Aug 2024 17:56:02 +0000 (UTC) X-FDA: 82458862164.30.2FCE3CB Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by imf03.hostedemail.com (Postfix) with ESMTP id C0FED20017 for ; Fri, 16 Aug 2024 17:55:59 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b=Fpfs68zu; spf=pass (imf03.hostedemail.com: domain of quic_jjohnson@quicinc.com designates 205.220.168.131 as permitted sender) smtp.mailfrom=quic_jjohnson@quicinc.com; dmarc=pass (policy=none) header.from=quicinc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723830886; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Yq9OAduvY4S8Jeg2Pa9Vlbb2Uon6I6YSTXJyX8g/M2c=; b=WB1neIJ4p5o7Tlbz/7WjPLp+TnWYFbjw/6mNRwmUFWTLtQlBihIcAnhWzhD9Fl/DrzPJKq A6+8uugdsmhovxl6dHn15bZhZ/oWECZgNvzPlRf8cmWEyO0vWR8pyQfOuq6KxEnE3Nkid9 ZN8IoA2hIBh7Zg9Tj0I/CC191BMs9PI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723830886; a=rsa-sha256; cv=none; b=tWOpFKejjOa0uZPacvZHgfUu1Co/1ObYBti9gy7Hd2wE0ax+P6kedQQTGQaw8E48cVi/20 zTD+5rIxt7llRHtSqwaifZzsw3lXko8DwwB/7GS7ow+LDSa3dh8z3R63D2crwoBubgVkBQ Wig4zjfQ84vhDZXeI0e7rYLDiQUo4Ok= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b=Fpfs68zu; spf=pass (imf03.hostedemail.com: domain of quic_jjohnson@quicinc.com designates 205.220.168.131 as permitted sender) smtp.mailfrom=quic_jjohnson@quicinc.com; dmarc=pass (policy=none) header.from=quicinc.com Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 47GG68I7031130; Fri, 16 Aug 2024 17:55:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Yq9OAduvY4S8Jeg2Pa9Vlbb2Uon6I6YSTXJyX8g/M2c=; b=Fpfs68zujjffosGq pJm+yg89t1zQd3+CI0xvix9M5KmhTmTYem7h8+wSDywVSNpMGUVXWry7KRAx/6d3 u8o0yvrOLNSHAz03bxvmFdkwUOchc8hJ3Q0Kzt1Ese5GQqVOjf/2Yy6iXgC+sDGd OtQqIu8zZXZCoB21obqQ3FMtfmdTZL3ZobX+WWRrkWWcKZKCJaMgohBlBCXwHeU+ YUgOkPyeRdVxQoK6dGKMJLk6lxEauuW3zpO07fTM9i9dx15jA3Q53aSlhb0YOuDl M1fXtz+8XuxKpcfQ38v4qopMqWldSuAPHwPV/Mx8fPUMps9jKqYc+UomdBrUYCyr iBQovg== Received: from nasanppmta03.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4103wsb4vp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 16 Aug 2024 17:55:52 +0000 (GMT) Received: from nasanex01b.na.qualcomm.com (nasanex01b.na.qualcomm.com [10.46.141.250]) by NASANPPMTA03.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 47GHtplv020165 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 16 Aug 2024 17:55:51 GMT Received: from [10.81.24.74] (10.49.16.6) by nasanex01b.na.qualcomm.com (10.46.141.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Fri, 16 Aug 2024 10:55:51 -0700 Message-ID: <292a7ed2-a2a0-4dce-9741-b7169402b290@quicinc.com> Date: Fri, 16 Aug 2024 10:55:50 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 09/16] iommupt: Add a kunit test for Generic Page Table and the IOMMU implementation To: Jason Gunthorpe CC: Alejandro Jimenez , Lu Baolu , David Hildenbrand , Christoph Hellwig , , Joao Martins , Kevin Tian , , , Pasha Tatashin , Peter Xu , Ryan Roberts , Sean Christopherson , Tina Zhang References: <9-v1-01fa10580981+1d-iommu_pt_jgg@nvidia.com> Content-Language: en-US From: Jeff Johnson In-Reply-To: <9-v1-01fa10580981+1d-iommu_pt_jgg@nvidia.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.49.16.6] X-ClientProxiedBy: nalasex01b.na.qualcomm.com (10.47.209.197) To nasanex01b.na.qualcomm.com (10.46.141.250) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: ZNfrWpnORYMPty3y6Lmw_WiVp1j4NNZP X-Proofpoint-ORIG-GUID: ZNfrWpnORYMPty3y6Lmw_WiVp1j4NNZP X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-08-16_12,2024-08-16_01,2024-05-17_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 impostorscore=0 malwarescore=0 mlxscore=0 lowpriorityscore=0 spamscore=0 mlxlogscore=999 bulkscore=0 adultscore=0 priorityscore=1501 clxscore=1011 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2407110000 definitions=main-2408160126 X-Rspamd-Queue-Id: C0FED20017 X-Stat-Signature: 7wajgbg85q8n8bni699fopydfj9hz4iw X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1723830959-256667 X-HE-Meta: U2FsdGVkX1/0xLiZgZrJ+kAN+7K2neIzCZf3oqiU2NTsyBpoaCopC2gtwAOn9M+ObExfFMnk7QiA5r1/qw0zT4NhmQTPEv9JdQvgjTLGYW6aM8wTr8knWJnN0Pb3SseM6eIpjnhtVwV8QlGscNnWgP7+jxAjqTm9nYXKzmvjhUGkqfQQ8ACLuKf3LJTlV6Qm6PkkXE/aNMk5I2iEDcMMfEaGSKRZtYwjC3+c0etacYmcAfM1PVrDkHvfw5VBechoxEz8bhZrZVwREyNS+m0W7AlrTo+yBvj6DL4z1d+ksz5zYXYRc/LFGXIS7kV+AnJkGfQvH129JgutfCCyVXuJZso2qgudaNORidtISjLa/aISx9da9yEZt+XvOCi0WZSydyxjnt495i+7GDDIzckXjXIHqj5Ktss4/hvXA0rglJceV/4czH4IaoPLn8ePW6rm+KOgR9soIc38Rl3UNieXDHL0q2rAg4lgWyD+wiJ632jibMUY2Hrc1N9DtbkXDPBDS7Ksn1tznmjkaSnIMf+WRXJLvGq5DgTIPtvf2qhNTjKal6OwiJf/DupwyyxJuBeBfHk9u+sK5Wqf7jf45xBVw3sOxHtnSxe8RVAJxi7+rohvcQ5p88zyJGYMA/J5m13KIOdPNNZ1TOHDUAxTk8c2Vub4SBEefG4qTKN2lL45iVKmlslK93t1BfYMmQLIFOieYUgPi64yi/cFy+FSx+ni5jsAHhZkvVKIwnvlo5pwrNV3F+9mcOOtwruuCLBWA97MGEfVufXZ2y3DcgbD9ujQljMfG+n6mGVs0AodB+Kvpy6hJrHKULD7n2m+uT3R2Z5AQoHCu1/Ks7nRUR+6H2A1vC+BbvQhXx3fCjnzHam+Ybj53GqWTD33SZy/m8ArYwOFTbO9G4mgmSbaixflcyzrWCoB9/YR0ciSTUNbVuk/rNL1AJKLelpEsakcProo8lf6bOc5dkAcJtv6Om6zQpE a0r9i7Ba 5iX8yDMbLSh/gk7XdalLeTiB4Gh/XLul83cqQl0N1ilixEDecsxnc95DFbkSn7ctKbJpXCthxH+xrfWeHH7x8NXSBB8PpY6OwFH/O3k+gtgtBuQg/4ZyYV0ugBeE1tiq4r0xDAvuFwyP2ddznntvjyQ2FjJ77P74Pd2x81KJVcgshOQd1VS/GO88FjXpbXV31zLDfAzXphM/ML8Yqy9BB+P7Qrk3YziUx3HKGHuRnPeBBQjZPckqAulBA3368QJR7gKWMrXV9CMVzo0AY3EgdDWxnaYHc4+YH1Uu/ula2r56N7uxN68pN+Fv5v6esPtp6VBPFrpu+igjf137Sb8xXoB8oqQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 8/15/24 08:11, Jason Gunthorpe wrote: > This intends to have high coverage of the page table format functions and > the IOMMU implementation itself, exercising the various corner cases. > > The kunit can be run in the kunit framework, using commands like: > > tools/testing/kunit/kunit.py run --build_dir build_kunit_arm64 --arch arm64 --make_options LD=ld.lld-18 --make_options 'CC=clang-18 --target=aarch64-linux-gnu' --kunitconfig ./drivers/iommu/generic_pt/.kunitconfig > tools/testing/kunit/kunit.py run --build_dir build_kunit_uml --make_options CC=gcc-13 --kunitconfig ./drivers/iommu/generic_pt/.kunitconfig --kconfig_add CONFIG_WERROR=n > tools/testing/kunit/kunit.py run --build_dir build_kunit_x86_64 --arch x86_64 --kunitconfig ./drivers/iommu/generic_pt/.kunitconfig > tools/testing/kunit/kunit.py run --build_dir build_kunit_i386 --arch i386 --kunitconfig ./drivers/iommu/generic_pt/.kunitconfig > tools/testing/kunit/kunit.py run --build_dir build_kunit_i386pae --arch i386 --kunitconfig ./drivers/iommu/generic_pt/.kunitconfig --kconfig_add CONFIG_X86_PAE=y > > There are several interesting corner cases on the 32 bit platforms that > need checking. > > FIXME: further improve the tests > > Signed-off-by: Jason Gunthorpe > --- ... > +kunit_test_suites(&NS(iommu_suite)); > + > +MODULE_LICENSE("GPL"); > +MODULE_IMPORT_NS(GENERIC_PT_IOMMU); Since commit 1fffe7a34c89 ("script: modpost: emit a warning when the description is missing"), a module without a MODULE_DESCRIPTION() will result in a warning when built with make W=1. Recently, multiple developers have been eradicating these warnings treewide, and very few are left, so please don't introduce a new one :) /jeff