From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16260C7EE29 for ; Thu, 25 May 2023 10:52:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 28D706B0074; Thu, 25 May 2023 06:52:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 23CAD6B0075; Thu, 25 May 2023 06:52:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0DD516B0078; Thu, 25 May 2023 06:52:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 0148E6B0074 for ; Thu, 25 May 2023 06:52:42 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id BB0B2AE0D1 for ; Thu, 25 May 2023 10:52:42 +0000 (UTC) X-FDA: 80828464164.23.8660FA5 Received: from wnew4-smtp.messagingengine.com (wnew4-smtp.messagingengine.com [64.147.123.18]) by imf29.hostedemail.com (Postfix) with ESMTP id 6619612000D for ; Thu, 25 May 2023 10:52:40 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=arndb.de header.s=fm3 header.b=MOQIz0md; dkim=pass header.d=messagingengine.com header.s=fm1 header.b=EflHhJQg; spf=pass (imf29.hostedemail.com: domain of arnd@arndb.de designates 64.147.123.18 as permitted sender) smtp.mailfrom=arnd@arndb.de; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685011960; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DUFYLgNR0P3iMDujbNPJ6zcWMVF2ZDhcLM/UDfvQ7oE=; b=4SY63ztfDRUjBYtpLjAtRjO/k3HW7pzrOXwcduiqKiFvBxHrhaeEdqVu/hMY4+VLj5Fp0+ LxFKk6xx9/2xYqQKBytmdGQrwm8bSg/xd/mMd653pgxln3iF2trD38FXMuVChFZCXJsc52 KALQ9A0H4Dnx2A4KoeQRPJgRj0jj9S0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685011960; a=rsa-sha256; cv=none; b=jpEsROboR78lZJaC/yzkAmUchDKgtLX/b4ELT79gQrrIqerbaltY2yBPLsp6TeE99LXdvP R8eJQ+CDQYJoutUTIUYU3GN//R9cg3d/0xiUfvCk4Esd0v+xnQkkLBgZlu9i+KCywznIyH mmp+NfsuTzM5pjyGPKbiLQPqu2jYgPw= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=arndb.de header.s=fm3 header.b=MOQIz0md; dkim=pass header.d=messagingengine.com header.s=fm1 header.b=EflHhJQg; spf=pass (imf29.hostedemail.com: domain of arnd@arndb.de designates 64.147.123.18 as permitted sender) smtp.mailfrom=arnd@arndb.de; dmarc=none Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailnew.west.internal (Postfix) with ESMTP id 6FAD52B0681B; Thu, 25 May 2023 06:52:32 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute6.internal (MEProxy); Thu, 25 May 2023 06:52:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1685011952; x=1685019152; bh=DU FYLgNR0P3iMDujbNPJ6zcWMVF2ZDhcLM/UDfvQ7oE=; b=MOQIz0mdsCpzsJDpOT 8ymmHxd6/8U/1WrSlAu+26J9rPY+bl/QIyP7HlCrsPmJUlV8qXrewBBWaZM/zPbl Avlzez1zIuARarFB8Q+CSpanGgDvavP3UvS7jOZjuO8BEJC5Skq+WhgsPSE7BYso huvQr31ejgwQADplhhctQIrYZoiYvP65bWrP7Ep2/ENITKCKFjM+ORNVQInWBB/U e1xnq3JiYlOQMGLPzi2Gn4d5fn7nPmSS0o6PhQUi+JS4X88aY797/1dcU900mr0r b8dxJ/azB1vY1PWRzlUrX+dxP0NYO2gi5TQFJt7KPkijRDPkRNSWoC8W0yTowW0l f+Mw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1685011952; x=1685019152; bh=DUFYLgNR0P3iM DujbNPJ6zcWMVF2ZDhcLM/UDfvQ7oE=; b=EflHhJQg9wl2mG7bcZk8ETaFCFS2e +KCM2ZXWihEVKvLhonnr7dOUeqG2bh5qJx2FysmmLCMzUPG+HlbFcFxvGE9Yt6Rg c1Zq4zh4OEYt+Q71eWIJqiin1aNt49jXbiLQh9SJE62wFNAo911XNBoucik+Gzc8 cspfKUzRXOjWxDMSK7p38IylIxc/LuzE632/sGzGIEm6R1Y34aKYTzNNhuewVS6x mPkAw7cYASaqD4haDeYKF5F8Li1HLZYnk6WFDdHQJiPyYzjJou5z/uFu4KgXX886 wVCJOeYCov0f/WDjAlcaoDUMGPabIC66aH+QqtLdoHG3Q/7JEQQMjfKGQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeejjedgfedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtsehttdertderredtnecuhfhrohhmpedftehr nhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrdguvgeqnecuggftrfgrth htvghrnhepffehueegteeihfegtefhjefgtdeugfegjeelheejueethfefgeeghfektdek teffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprg hrnhgusegrrhhnuggsrdguvg X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id C3EA8B60086; Thu, 25 May 2023 06:52:28 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-441-ga3ab13cd6d-fm-20230517.001-ga3ab13cd Mime-Version: 1.0 Message-Id: <292934ce-73fa-4077-9051-2ad909828f4a@app.fastmail.com> In-Reply-To: <20230525102946.GE38236@hirez.programming.kicks-ass.net> References: <20230515075659.118447996@infradead.org> <20230515080554.453785148@infradead.org> <20230524093246.GP83892@hirez.programming.kicks-ass.net> <20230525102946.GE38236@hirez.programming.kicks-ass.net> Date: Thu, 25 May 2023 12:52:06 +0200 From: "Arnd Bergmann" To: "Peter Zijlstra" , "Linus Torvalds" Cc: "Jonathan Corbet" , "Will Deacon" , "Boqun Feng" , "Mark Rutland" , "Catalin Marinas" , dennis@kernel.org, "Tejun Heo" , "Christoph Lameter" , "Heiko Carstens" , gor@linux.ibm.com, "Alexander Gordeev" , borntraeger@linux.ibm.com, "Sven Schnelle" , "Thomas Gleixner" , "Ingo Molnar" , "Borislav Petkov" , "Dave Hansen" , x86@kernel.org, "H. Peter Anvin" , "Joerg Roedel" , suravee.suthikulpanit@amd.com, "Robin Murphy" , "David Woodhouse" , "Baolu Lu" , "Herbert Xu" , "David S . Miller" , "Pekka Enberg" , "David Rientjes" , "Joonsoo Kim" , "Andrew Morton" , "Vlastimil Babka" , "Roman Gushchin" , "Hyeonggon Yoo" <42.hyeyoo@gmail.com>, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org, iommu@lists.linux.dev, Linux-Arch , linux-crypto@vger.kernel.org, "Stephen Rothwell" , "Michael Ellerman" Subject: Re: [PATCH v3 08/11] slub: Replace cmpxchg_double() Content-Type: text/plain X-Rspamd-Queue-Id: 6619612000D X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: xxhwz7ruds5ds8qn18jao7a5psaet7xy X-HE-Tag: 1685011960-219100 X-HE-Meta: U2FsdGVkX19rgdCtJffvjEovieEAjGUp7QXGOZY1NXQmfbZGTN3zRE/5qDXSAkN+PE7e5ZlYs0qsK0miHygOtNO5lApO7VS5kevZytxYuFk+XSIechNcnwu83W4AWO1tmcwPItvK5/mTJj3wMAk2IkoG3OO7rulGY87DeJhBS1ejMjxnS3j1rp+S4jp+wwmm0RD/aGoQLjTjyCJfEQtsk0kByPxSE7SNoOFQZRHbBCqHt7HzNgipL2aOiefm2VJUHU+cqRgiBBfYwjbxdN1nOnQp0Atm9XxvMitsa/mKXCa6KAfyNQViPLKffBW/5zQFYUuPBTz/NqPxgMtJWceadj7JQYqRTY+h3lzudPNhxTq9wt1b5mnkxBXdi7UKaIysAPZifrgTtvr0B/upLk8lIJ/R6eB3cWSERC+TQ9632TdgJ56fckAJFRYTTqNGT3nR4Q52Hd5j48lKAdc1Q94epI1MNnla+J+z//i6m13ijVn9pdULZEN971/FeGMHIUOhicKMnAeJsyKRuMh9yUrSVuTs/0s8/PdbAheLN6+dzRbhTyEJsFVRxNqMJFgKRoAYd7UbRC0nJm7UHIlNlvCixreDDisShm5sTszJpuwIS2+IK8NbcBjj9d/XE5zYlqDVyFqxxWYwOmLn16e4lg1kEpAI5Y1g6tV35hpJVFZPjjjsEdAXydp1UBzixX4VuO1EfTyBPmNeUCqnMCNO7tLlwQBpCH4OlHMhNgJ/4R9LzrG+EOfUcsNj/cmtgqBb9HC2rKFCatVZNWUA7pVmH8+jxRelgH1vFClqghKm0A/LWomkrNSJaxgUbOtNXlQ5cbj5Zfxo8XAhv54XEPCGhZfkQJBqHTHeiOhPjImxxSycgfpIFJEmzeHOE1lkKAQuUft0ywUiDNxZfohaFh5cdHN3BT5HetFFYveOPkXIS7BNpcI+00jdmGQz1DSiTtp1ej43NPGS3X/Y9Sk606oO3dm xQUqgq7A OR7zTN2XQQ6PclsH2lXlNXF3HImdbu0pqOioWyibKKxhKl5hpJ6ka3rzhq9NyuO2gds8Y15a4zzkI36bRCgr+9xasoZKdEjzEAbd5HeK8LkPlmXAc9AWB6seojAsjLazpr77fPK1l/iD604AVrQ4kSk1GdPqqC75ASxhwRaoZQKr0WzIgK+SAgoJA2OQZZWcvwFk0gvqAJ3HADyHWeKYu4JxzQWYYjCw2d8Er6k3Wu/8IjdNW3eNT5oviqXH0zf0/J4mE X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, May 25, 2023, at 12:29, Peter Zijlstra wrote: > On Wed, May 24, 2023 at 11:32:47AM +0200, Peter Zijlstra wrote: >> On Mon, May 15, 2023 at 09:57:07AM +0200, Peter Zijlstra wrote: > > This then also means I need to look at this_cpu_cmpxchg128 and > this_cpu_cmoxchg64 behaviour when we dont have the CPUID feature. > > Because current verions seem to assume the instruction is present. As far as I could tell when reviewing your series, this_cpu_cmpxchg64() is always available on all architectures. Depending on compile-time feature detection this would be either a native instruction that is guaranteed to work, or the irq-disabled version. On x86, this is handled at runtime with alternative_io(). this_cpu_cmpxchg128() clearly needed the system_has_cmpxchg128() check, same as system_has_cmpxchg_double() today. Arnd