From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BCB1CF58F0 for ; Fri, 20 Sep 2024 08:53:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 50E4D6B0082; Fri, 20 Sep 2024 04:53:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4BE7E6B0083; Fri, 20 Sep 2024 04:53:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 35F286B0085; Fri, 20 Sep 2024 04:53:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 18C016B0082 for ; Fri, 20 Sep 2024 04:53:10 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id BC96C12019D for ; Fri, 20 Sep 2024 08:53:09 +0000 (UTC) X-FDA: 82584502098.06.6171DC8 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by imf04.hostedemail.com (Postfix) with ESMTP id 5696C40004 for ; Fri, 20 Sep 2024 08:53:06 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=HfZPd65Z; spf=pass (imf04.hostedemail.com: domain of dave.hansen@intel.com designates 192.198.163.7 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726822236; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nhARQUzeLHka2rrc4a/Wa3lO6uoK+jMS0PGShSYt8HA=; b=5a4uSEQ9B87Vjx+eTvAqQjPmLACTdYxZNZTqVOOw4/lCgQiz3M5lNJUCz2Nj6TDllhliUZ +c4YpcflfqLWCKgwSKZPAhrh430y60hYfSE4lSWGfb3P1m+LNQfqmM7FKe/L1nfet8ImuH zJTLFL+8qltQv5wbeOYP1T0re4QPH8E= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=HfZPd65Z; spf=pass (imf04.hostedemail.com: domain of dave.hansen@intel.com designates 192.198.163.7 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726822236; a=rsa-sha256; cv=none; b=k6Wyx7+lMblVhssdmcFFK5i+ukE/+qQmcap8D24HYDDWuWl1oD2YS1B7QCveFEvsxl4vPd 5lbiW3WaoMMUtOxLcdK3xU8EOVmLGjgPMfeuLt4Nxw7GGeaIMPop65C069ZXmjL3CSksNZ LDggfZaYQVTPgLr+evh1+wxFUB/FJKM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1726822387; x=1758358387; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=U62G/ng4OCDBCfNaF3t7d607ECXcemW0hgJpnqy08cA=; b=HfZPd65ZsvaqsAfjTqZ8NhHn6I7LWhEdYtMox3GcimZgMkPETnV6l715 Esw9Xb+Yz0VJRggCbTR0j3QWnopWbQTKD3TfUAHF5kxPfePZo8D6S+asH +OpSdc+CU2DY4G0yMDkayPS+UPFM7r7X8anSeSqr5mlVAQAkitiPQGHMC o/T6Ob/yrk4gcPmykFcuXSuOYpwjoZ3pxix1fD9ARtkz3u4uAQl/YZBvj DvivCHgu67ZHTmEqoG8peGYhEWTsnoRg4AxDn6HHykOIaqr793S911cK2 HhYxjC1L+9432IN7QECxC+Nddi2+aU/yyGpHCSqVS2qi6U2WVBCGpvF8P w==; X-CSE-ConnectionGUID: 3+M8obJ5TmG7EN88zSZ7jQ== X-CSE-MsgGUID: MFfdPVgXQu26/qcKY+Xajg== X-IronPort-AV: E=McAfee;i="6700,10204,11200"; a="51238959" X-IronPort-AV: E=Sophos;i="6.10,243,1719903600"; d="scan'208";a="51238959" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Sep 2024 01:52:44 -0700 X-CSE-ConnectionGUID: ac+7hOJWSuOke2n3RrMbqw== X-CSE-MsgGUID: VOdUS9/6SfC60J+b/3Jqmg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,243,1719903600"; d="scan'208";a="70540520" Received: from dhhellew-desk2.ger.corp.intel.com.ger.corp.intel.com (HELO [10.245.245.29]) ([10.245.245.29]) by orviesa006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Sep 2024 01:52:40 -0700 Message-ID: <2924c274-2b01-4b33-87e7-5b66aceba3b0@intel.com> Date: Fri, 20 Sep 2024 01:52:34 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: Move set_pxd_safe() helpers from generic to platform To: Anshuman Khandual , linux-mm@kvack.org, akpm@linux-foundation.org Cc: Paul Walmsley , Palmer Dabbelt , Thomas Gleixner , Dave Hansen , David Hildenbrand , Ryan Roberts , x86@kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org References: <20240920053017.2514920-1-anshuman.khandual@arm.com> <3309e9ca-458b-4b10-8409-9fe315b60ae2@intel.com> <925a26e2-bd53-4bf4-b22d-7a0e11581376@arm.com> From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <925a26e2-bd53-4bf4-b22d-7a0e11581376@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 5696C40004 X-Stat-Signature: rhpyhery9951a763bpoi67n35ej63rwm X-Rspam-User: X-HE-Tag: 1726822386-278757 X-HE-Meta: U2FsdGVkX18uK5ZXANw0551bDX+AmRaAQXJp3sJzitegxLQo6NeH+dSy8ts+Q4KYW9WUzi+ahW2JhGC3UWuKkrBezkYzMGbdlOS0yN3ifZ/HELiL4T0QceyaqjZOm2o6tYRCR/q0n8wEfVkm+QhS3q0Mrgi9Dulxf/mCu+KHLZmB5Bplh6W6hHcK1hI0j7TaMqToSJWFDJpbu1wQulFJptGXMbdqwzYPVm8qo5ot2hp3TWn0iQY+/bI6A8SKdY/iOOmhmv+3mZIw/FbD9dhQcLa0xymKZW80dcXAdejnjQjzBamYIyfASzj8paZGZoPeCR2tIOo+avn2qV5OB54XZNKuIt02S2MDgbK5nLfDnfVwWsfaXpndtnKnxWik3B7+Zyyeug6ehjWbRHcFvI3sVW8gsK1e3p4+cmkoSV0R5F9XTfga56wkrmyH4XwFNDceVmEUT0+0U02TMAfFGUchCKgfNd8zzTFqvJol0mQNAWQtUlCSTIBqNTOv8ycXVRblus2Bav658+4mBOEj2jK2AC2937iqC2xjQqRQsa7BAd2Z5GJDpJ1ORAnn34lHJ4G9Z6JaZ6Pn6kkRZ9GqtfAHyTD8usk/3cZ+f2beW/rVZxELPANroZYVAnCnFFtlir2GVdfCNK0zs7IGdhrgoGPn5m/IXkkfLM+dEUKJzybYuDqu+egRmqKzLrl0iHQRxVsSxLt2pqzcxla3W41O+PJlS8aDUjqqYZVR5sIitKVAFF/JRzjr+0ovyJ0vmHffOkJd3BddGD5aIb911X/2w7MZ/I41JrMZ9wwWjVdcY2L4jD5uGhVdgDX0yh29Q+ahsvqZK6f/NfAvJJyexA1qMY6XdaIcqmie32HIRhBfMn/ZJDEd29GhKG5tbjq3BXcyB7WVOrx/uU9XGVLM0FanQfQz53j7BFEY2WZPDH6kgSF8hvTE5ZB/q+aALrQgrdOkrV2XXXo/a83e0hWKbrWsuqg /suSDViI R3UqOgbMM0bEGmq28ZT9zok85WtPCBgCP3/PqHXUNLxwuo+q6CiSbInrrpT/ARzClAiSbZ8NzREA/XgMv8GCgHHejqaJXvRQcz9uRkRp2MAGfNrbuJSmrDXT6MAbzKdJox9KGr+BkE7biOsmBJ8LKLNFDQojniubofnPZ/BUbsXXjCIQwwLaXpnKGaxqFBcleRIQf8+l3WBmqMQr0pkcH4kfWcpWOq9/e1I3bjtQDIPp+taSQz9UnkRou7Z+f/UDi7AmW X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 9/19/24 23:42, Anshuman Khandual wrote: >> I just did a quick grep and don't see any difference between the _safe >> and normal variants. A quick grep didn't turn up any actual users. >> >> Did anyone actually double check that these are still needed on x86 in >> the first place? > arch/x86/mm/init_64.c Ahh, the #defines make them immune to grep. :) Long-term, we should make sure these are still necessary. Short term (in this patch), please just put the #defines in init_64.c if it is the only site that needs them.