From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E3C1C3DA4A for ; Fri, 16 Aug 2024 19:31:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A31D26B0294; Fri, 16 Aug 2024 15:31:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9E1116B0295; Fri, 16 Aug 2024 15:31:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8A8666B0296; Fri, 16 Aug 2024 15:31:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 708DE6B0294 for ; Fri, 16 Aug 2024 15:31:20 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id E386B80276 for ; Fri, 16 Aug 2024 19:31:19 +0000 (UTC) X-FDA: 82459102278.23.FCFBAB0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf20.hostedemail.com (Postfix) with ESMTP id F02D51C000B for ; Fri, 16 Aug 2024 19:31:17 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=M6hGxVgF; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf20.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723836595; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dAUVeRgH13oxbvE6MJ/L04r2yM6YzE3o8WtEBRvyajM=; b=EISYS+QbQNsap8mDTtp4rAEAgUhb7YP9q2pP2pg+5mbTUTC2e6n9EnfI6JfGa7unePRs+3 jId8mZCveQZOoy+/CSVR4ECiY7SVjEiht7nsGWGKjXWjGMzhMN/iFxgzjG5tcHqAgrOvT2 BTuDSHjfghY5AF7Bn65VqKRZ5gMkkD8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723836595; a=rsa-sha256; cv=none; b=DPKGdyMLt3ffgKho3PhJCQ2JRhUIC+OgoX6VC9ICgjwtigvCSmNbPPxa0LMX+dJ43x8klq wxIaRAFeVnHaIvmg3ECnbNinyPcBTaSXE6f/6M5V8944mYmw9hbRv7kIXK+n9TCuf3H+CA hB6+ClEGP0Xbvz0UPYepWQQEkU1z2z0= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=M6hGxVgF; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf20.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1723836677; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dAUVeRgH13oxbvE6MJ/L04r2yM6YzE3o8WtEBRvyajM=; b=M6hGxVgFJEta0cjoiJyCPgnuSOB+oIW3S9LNhUh8qBsLSfopcZLxt59ay75sA7QURAb1MO xmEwV46VUj5tqfOL3JZzplKD5lO4EzdLSG4xV7LeerWqUAZVV5WIG/OhBoGKGA0PDJm4fd uQEIjb2ikykvu4hs/ALuIFvFSZNZGB4= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-610-KiX_NkxMM_erpn1TlFqLZQ-1; Fri, 16 Aug 2024 15:31:15 -0400 X-MC-Unique: KiX_NkxMM_erpn1TlFqLZQ-1 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id CBF101955F45; Fri, 16 Aug 2024 19:31:10 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.30]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 6593719560A3; Fri, 16 Aug 2024 19:31:04 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20240815090849.972355-1-kernel@pankajraghav.com> References: <20240815090849.972355-1-kernel@pankajraghav.com> To: "Pankaj Raghav (Samsung)" Cc: dhowells@redhat.com, brauner@kernel.org, akpm@linux-foundation.org, chandan.babu@oracle.com, linux-fsdevel@vger.kernel.org, djwong@kernel.org, hare@suse.de, gost.dev@samsung.com, linux-xfs@vger.kernel.org, hch@lst.de, david@fromorbit.com, Zi Yan , yang@os.amperecomputing.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, willy@infradead.org, john.g.garry@oracle.com, cl@os.amperecomputing.com, p.raghav@samsung.com, mcgrof@kernel.org, ryan.roberts@arm.com Subject: Re: [PATCH v12 00/10] enable bs > ps in XFS MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2924796.1723836663.1@warthog.procyon.org.uk> Content-Transfer-Encoding: quoted-printable Date: Fri, 16 Aug 2024 20:31:03 +0100 Message-ID: <2924797.1723836663@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: F02D51C000B X-Stat-Signature: 776785krc9g7msnh3ep18qxcox8swygw X-Rspam-User: X-HE-Tag: 1723836677-123356 X-HE-Meta: U2FsdGVkX19zm3ywY7WoJSmG1SU4W0a2WFTbh2hB8ikGsKpHdJDvn+nXF5LOB023Ydn3m6XZRV6XUQkoSuPDBxG8ljQKAimEXHol2FQj3TYogu8sGZGcfgqQqYpSIEELhA4MY9RZJTRqXDpsSVl7pPIq0RvFV7jQ4Ma9JXHUD//A7XszkbMGS4Wba6QKpQ1c2JwtC9pSaHZte+a8KDd7tJArfUg61g0OM8vTXfTsy8ZjxRYdXMr91bdMn0Kfo3yiBgApnsKlFiZDm8g+8izXDzoVuo0GyDOpCKsDPXY9nG0EMtuGUiNfaEfOaBY9HSygF9CQIbVV7eW+Tq7i27Aoec1f8D78ZHblt5eIWsDbZv/yT7ijXK0tZeB9BH1MhRsgYDbyk/9DAM4y3dTMc26ts0A1eboDXs1eMZmahMrxaXzBpp7g5Fr/BheAhFYETp7g7Q714MSJQzswEM2nWUr1qXRGz+7uYfMGOdIe+N5GmI21ZhKwESX3GcaCBURA6Nbl8R1MFAK+47ZPfwViGeSo7nr1j29k4FVK1C3rz9p/k6Enmcl8bueCa0pO9e9oWf9w5FALmdBMAaD/Qw7Gprwyg7Les3QTBuKZ7A18p/gVPkdjitM5U0OdMl+ZGRMvzxOwuhxV9i1/5kDTDrxdLfXrgYeu29Lkl+zHI8lTNBkPvex+aqw+xfbJKGMS/B7CyoFBVY9IviyATS4muIezn/0rVMtzR3K3c8shSAyx7cNk/mYmQE0PlLaLxKowqXE6S1mnN4u79vY+L68zlMtA7fN2C/pzUsCkbbRJdFBBLyy6ctqK1mxfKiAr5BNM5Olnx61Xd8HC2Qv0OCFzyUGKFV0o024T/LEi3+ia5vv80/u2+Am7QYiXFU7fpga3di11eakxvyazg8RsxL8Jkp8B8L60osFk1pQqCcg04V0icyYSwWCdGEJQ1xJXHeg77EgV4Ftc/404GtX0DT/vTiBoUXI DOiu6cT0 dFG3TrPfJ7pFaopCkYiXQQmqpbx1t1mPVXQpsctn6aS1nvUGNErAtHxLj2OZsxFk2qUVYGyjm9OUgBWMY+o8buRwZg/fZw0LBp17IejmGqYZlWxv9QHVt5ubXgdD654ZC4+DlfofyV22G1vuMLtiAmC4cn2xPSPVnHhRnFUUmAZrxPVXLVGgGKvG3wWxOe9DY8dHriMZE4quFqXKRYx/jJ4rY5plqkuDFpewbSY1UXB2c8vWCXguC78oHaYTjZloVTuS+MMvjq7rcGDgQ4R84bYHjrImtpLv9zW15d0/xAtt5ChslmbmkXXC9F2Qa/bCpwPngotm093FIdb2PitMS9YmvDcoV6BLXWpmkppT07zTJTjo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Pankaj, I applied the first five patches and set minimum folio size for afs files = to 8K (see attached patch) and ran some tests. With simple tests, I can see in the trace log that it is definitely creati= ng 8K folios where it would previously create 4K folios. However, with 'xfstests -g quick', generic/075 generic/112 generic/393 fai= l where they didn't previously. I won't be able to look into this more till Monday. If you want to try using afs for yourself, install the kafs-client package (available on Fedora and Debian), do 'systemctl start afs.mount' and then = you can, say, do: ls /afs/openafs.org/www/docs.openafs.org/ and browse the publicly accessible files under there. David --- commit d676df787baee3b710b9f0d284b21518473feb3c Author: David Howells Date: Fri Aug 16 19:54:25 2024 +0100 afs: [DEBUGGING] Set min folio order diff --git a/fs/afs/inode.c b/fs/afs/inode.c index 3acf5e050072..c3842cba92e7 100644 --- a/fs/afs/inode.c +++ b/fs/afs/inode.c @@ -104,6 +104,7 @@ static int afs_inode_init_from_status(struct afs_opera= tion *op, inode->i_fop =3D &afs_file_operations; inode->i_mapping->a_ops =3D &afs_file_aops; mapping_set_large_folios(inode->i_mapping); + mapping_set_folio_min_order(inode->i_mapping, 1); break; case AFS_FTYPE_DIR: inode->i_mode =3D S_IFDIR | (status->mode & S_IALLUGO);