From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDA2DC5B549 for ; Fri, 30 May 2025 10:45:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 463B76B00A6; Fri, 30 May 2025 06:45:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 414716B00FA; Fri, 30 May 2025 06:45:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3035C6B00FD; Fri, 30 May 2025 06:45:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 10C206B00A6 for ; Fri, 30 May 2025 06:45:54 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id C033FC02C9 for ; Fri, 30 May 2025 10:45:53 +0000 (UTC) X-FDA: 83499243786.17.8B49B6C Received: from relay.hostedemail.com (unirelay09 [10.200.18.72]) by imf07.hostedemail.com (Postfix) with ESMTP id 35F3740009 for ; Fri, 30 May 2025 10:45:51 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; arc=pass ("hostedemail.com:s=arc-20220608:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748601951; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DwdYkxH5NWexRNTuYD3BgdlNehQBcazh9M5V2TAF1Ww=; b=jC6sUVodsBBPRxPjVTo7OVndgVE39ZImixAK/2oj3YXuR/QqorT9GJbzfCsL8PTn6hk6to HUllWs9tJZTe9+B153j1NERU+uk0YOi5/DhanrezUjxnxcqXKCC4adpixs/+81kv00X9ND 6FxVdoi7YF6n21I29osO+j011RNkMyc= ARC-Authentication-Results: i=2; imf07.hostedemail.com; arc=pass ("hostedemail.com:s=arc-20220608:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1748601951; a=rsa-sha256; cv=pass; b=lHUzUWtuugVMCnsS5wTEWRqnKg9gGM+OBTkiKANhyZjiFXX8TAMbOJ16bSYzd/eInplw31 Ym3lDxAi8+ZWYj+VpUAVT7VTZvx/bKWl6K7HVC+mZMSSBGhoCsdQN61sPBmCVMEICstPMK qo3HSdsayescJAPbVxzbtdSm7orMmxE= Received: from relay.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id C030280299 for ; Fri, 30 May 2025 10:45:50 +0000 (UTC) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 872B1140303 for ; Fri, 30 May 2025 10:45:50 +0000 (UTC) X-FDA: 83499243660.13.EE24915 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf15.hostedemail.com (Postfix) with ESMTP id DB136A0007 for ; Fri, 30 May 2025 10:45:47 +0000 (UTC) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748601948; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DwdYkxH5NWexRNTuYD3BgdlNehQBcazh9M5V2TAF1Ww=; b=Hpa4ps1wTegrSZcJZhjfsamiT31g1p1J4K4qXeahhetb1qnLuJlmuMugjTe3wHQjsyWFft xj+tKd7d3Wg61UI2fSs6a+78P+A7BIFOySckd5eoccqVS+CznOhBIh0akVgoARfe+MNMDL yTz8a+p9yiR+FUltiOKAIFrD/qtjwPs= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=i8TCd30f; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748601948; a=rsa-sha256; cv=none; b=4IuDhWebqcVvRFIpoUz2+o4rLd5P+gQE9RTxlfO+SdIF78DBypimqYlHu9tefRDTO9vLnF 1WEH8XG6kSuc88xAteUcjGbAtQvdS6kiQR37Uzm19Wq/J9SqeAf0ftjlGgaW6UwjWM18T5 EIIMkX9rE5hBD96ItagAz1K4S4wFG3A= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748601947; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=DwdYkxH5NWexRNTuYD3BgdlNehQBcazh9M5V2TAF1Ww=; b=i8TCd30fn3Hb4L+2QIGJ/Ege03mhNEQv5bg9HKCKEhHtzdGBOwHiFVyzWSO9Iz2gjVHosR 2Q5h29EeQQPW3PqKtPwSCdDdkB/b9WIUo3fwqmsEkQJb5AKwfQpfrFLOZ9V5n181G4ZTtA KsilfnSQIEVnIcfpoFw7WilC0bReGds= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-572-Wtatdkh2OheO_cGLfMByDA-1; Fri, 30 May 2025 06:45:45 -0400 X-MC-Unique: Wtatdkh2OheO_cGLfMByDA-1 X-Mimecast-MFC-AGG-ID: Wtatdkh2OheO_cGLfMByDA_1748601944 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-442f4a3851fso16101735e9.1 for ; Fri, 30 May 2025 03:45:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748601944; x=1749206744; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=DwdYkxH5NWexRNTuYD3BgdlNehQBcazh9M5V2TAF1Ww=; b=du0CARvBnlGxm0b+Dqi/W5Grjk988wnMGHKimzkUvcIfWOe0M0Y0qwKd3Htu0SznaG K23glCbaFejaldxhT8pnzRPikn7L4jynp4/PBYM5Fco9xQotqWvKLxJ5Tm1tAo/sDsEc nl7nJA3boBn7bxx3s/ug7M2kpzSIu3/mkLy3IAiFJPwcWZAaDb5wzL9qpsy+oHR9xWLL 0ApZiy0pyuWQIEPxe+Uao8AL7UctojJYHjj6ke96T/YfNu2oJYun2YEdNy/4YsTtyALR A8hIHZ/ZfDtW2NELZ9Fd1GNc7JVBZt13jNN79D9SO5xOBBQChfxtOceu3lktAYFnYFOy LzRg== X-Forwarded-Encrypted: i=1; AJvYcCWPGreYfwWObZvvcbYkSVysc5yYXkNmzdaykWTbPrj6K+Fg30vtdAtdm71qht28TUAlaOumJvukNA==@kvack.org X-Gm-Message-State: AOJu0Yx5/KNoHlM4eEojLrPHJkGglQ7Ei3i3Y0wACA15FIvfIzrtZrLA lo/jZjvUxdUot9hlcSjunTBZWMWnPpvKngHIf+/Z7/sxpBSTpdImVxFN7JKssf9oty0i+tTibIg 6HHmZsa6dH6rBhrg+6Ka+XKvISZeVdn6SnVSR2xL5kOtIYVWjx39P X-Gm-Gg: ASbGncuZywW76am+Oo6J0AELknVw8Zg3QbYQ0f6yjC9DKxy4qtCz4mV0bDCSZWfvp5f RIDLtc014xYMZNs7hrsWE5kEmgtXxDUsKrpTOhnsF0gqeGoQ4TFd3qjptPr2kXyq/YUCVs7Xiiq OBrxIUlMNNXqJWx76I2HIz0qPZ9NfZPaJe9CU7rn+MHbjIaff+hsoxlW0GvT8GnO9YQTCQPzGHs nYId0bebre6Jq+5bU8cFg4vICJ/qDgI0acFMB7ET7oij2MlEar+H5gH77yMJfuqN3Orw3wV8gQ8 8X+UF7KuKzIp+DdFOaWzODXhZaxeN+KmB0PJMzWUS4Ua0CvqoYJBXQMi+7xkMlV4OGIOzAa1gn4 BMxLBlDg2hWZE1ckpW/o4O4t1iCctPGNIncF7Jlc= X-Received: by 2002:a05:600c:198e:b0:43c:fa52:7d2d with SMTP id 5b1f17b1804b1-450d885e395mr13897815e9.20.1748601944282; Fri, 30 May 2025 03:45:44 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG7p1KosJBoxSnA52uUHO8zNGeB7yLg2OEBif2rtf2efs00yVeVP3ublBcCm3+TNu4PeFchmg== X-Received: by 2002:a05:600c:198e:b0:43c:fa52:7d2d with SMTP id 5b1f17b1804b1-450d885e395mr13897625e9.20.1748601943913; Fri, 30 May 2025 03:45:43 -0700 (PDT) Received: from ?IPV6:2003:d8:2f03:5b00:f549:a879:b2d3:73ee? (p200300d82f035b00f549a879b2d373ee.dip0.t-ipconnect.de. [2003:d8:2f03:5b00:f549:a879:b2d3:73ee]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-450d7fc281csm14756015e9.40.2025.05.30.03.45.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 May 2025 03:45:43 -0700 (PDT) Message-ID: <290b753a-47be-4c3a-b775-f2c10a0bc536@redhat.com> Date: Fri, 30 May 2025 12:45:42 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/2] fix MADV_COLLAPSE issue if THP settings are disabled To: Baolin Wang , Ryan Roberts , akpm@linux-foundation.org, hughd@google.com Cc: lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, npache@redhat.com, dev.jain@arm.com, ziy@nvidia.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org References: <05d60e72-3113-41f0-b81f-225397f06c81@arm.com> <9b1bac6c-fd9f-4dc1-8c94-c4da0cbb9e7f@arm.com> <6caefe0b-c909-4692-a006-7f8b9c0299a6@redhat.com> <19faab84-dd8e-4dfd-bf91-80bcb4a34fe8@linux.alibaba.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <19faab84-dd8e-4dfd-bf91-80bcb4a34fe8@linux.alibaba.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Kn8QvSPQERiR_Gmq-d94LUSYA9Hnl3yL7qjnSkPPyQs_1748601944 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-HE-Meta: U2FsdGVkX1/jGUZ+ESwz26fysGkU76RBoLELzeUOBcIN+lISLekDubWbUrNpjnr66wklQxfJ4uC0bbOaQzRqldoF2rcL9EAcK19rjpi6bFrHc/6G+0f7+IzlaaKvv5tM37KO5EIgnvq3V/kP3q8gqOJ6oV5zbwEl/m5V3GwZMaj+6KZzn+hWbfgOgw8A0tfh30fI6Kq2tu8JtF4wcfgP9dJ2jBwIc6D4+49My9MsJLt0EB3TwNRScEKxhf7fBA+2i5kKkdFZ+PPfb8uD8WeOPTq9NFsPgai7woNmiAcIqrMDYoj7bLrnsA8y3eacsnNSemhguglvUs1xhn1RZhZRQ6g3QsNl5xF5++MEpulTUk8+YLKWQrmv8U17cwgzT3RCdSs7jY5hOQYwKvNifOjti40LVkCb69jC3MpMMwg62SAaNbijbOEXh2lxtQv8ZNJAtDyIB3NS7mGx5M5+KbPgi4OZeUeJ4l++heOVVc6KXNBw6ys0bSmWzQR6hpYZe7Un10r4Ur+TocaFstXzPWSvX2ZsTzpHns5MNgdvY7iBQaLNG1h3btLeaSek70+uH3fAMpzTO5l+SPrImttdnaDk4TBSVhMCnguAWp6SCOgL+gxmoykzUE0XtymlaTET+y4OLR1QQkxyLHiBnwqKphDg2ClH1ZrLuaqaM8hDRZJIHSLhU+jK2Az0y2ym6tjs45PFcFskIRG+eVFuZUFKRYPabo9iNQqIIZwCGbEr23xYynBf9Too0qNPHCgvlRh+Jp1zqL49rnxvNxy94KNKPg91Icf7CsBaOwPZcqlFSUbiRIyrhKroaKtH09blJIVb1YBg9LZXNhrd6yKxxlFrezKtmPqTJoMGJ+aC/6W5JB/+i3XJVleTsWSze89glL8h8TMyTeak+ya6IeVW3bimSyK+ud1cVFhTjVZNEc2qVzRC3dDnBzp7QZ7/bAcZ7kyXesj2WckxP4MocPa7g1NWBvv CxqmDNeN vnQZrUF1PjmaU2NRfhY6xzTPyYNDGJ0fBKj0BXRhJS3lDRB9LACoeWjYtPgGLy0PseE7PhVHyh3SyWcFjjGVTVUDVN+9IzlSUXY80NcXMuXDLpd+RKvAkFHDc8OlvVTHfnvTjmo/rBM0DMu7YYKWdYjM/5h8+tG4gdYlu5aW77ctp3x7UBxPOUJNT5h709UwTIcRYP1oTYeJKBw1TJNgQDhw/pRnKh2vFfsrlFKdUfxmSVI5fUabhMNcwItFhZvoTRkpjGXpTp0CQTgV9C9C4Ms+aezIAMiPV2i6x8F+A6NmbUc70eUlAgYKpzdp7N8bVGs8M32KGb4WovIkLIAmgs2mCfmL2oZDrgR2sP617lQJqFq2oHLfGIgLSvpcxZW9qqJcnqBDsWLDZyIDIipwwdNdm2uI5EdyNOFMkvDKMgGX/5XBVUHiLpySrMVv7e+WHU9cQBU1OJmVrETQ= X-Stat-Signature: 6tk1x6qxe3jf7bf9xm7ptjft8kuhozcy X-Rspamd-Queue-Id: 35F3740009 X-HE-Tag-Orig: 1748601947-296818 X-Rspam-User: X-Rspamd-Server: rspam02 X-HE-Tag: 1748601951-307715 X-HE-Meta: U2FsdGVkX1+j5hgLV+hU4FZ+8Vs1KVjv/5+sk1FElSTQVP2Mh94XxjZwrLLLUUCVtIR1TH5wtujv5kIwpF6SzR1aABqGSafHlWOOU0bhcmy1yWlt+1Sxp+6QHsoLkk8YOF50wAHgXAfVQnEuJoDzdc7jr+bbuQ0N2N3SBGYHxFAqQbKI6VMlijNy61IlwI3muLLA/TIoO6/7wK3X7q9Qg1kmZCMw6JbXC0H22qCzljvnhCU3oX2yYPoRtCaS7nMwg9ewFSEnBFyL2xYEXf3j2SEgNYDU7auteiyoIRf/1x9M9F66KYCC79y75s4wQ/qccOZ41XkWn9/bY9rWzsV/QfRTO37p6Tyb0x9otIv6+iTtrnEU75MOEVcVd7T0zi82DVgPXZNjTrXlFoDLd5/Vj5v9b+oQ2rK6n2obIDO1XoIx++2hgYE1rZ+do4QRky0XIhenaanY/TWK4NpJUhT0PucV/n/qPD7nGTFtn549yy/RNtN3xR/1EdiJLe2KfkUxZzJphIlX2/AMVFSp6aQkThYGlR3i1zfj8xgoQKKOzUxBplCYmE6FJF1VVwY4xDSEdy5CcbRUN0R0iLP8Yor78D1R2w5UG08ODJd5lA17GGayIL8qAL3lRYQZgYwt0B30m+TGSYaZ7yQXYnk/w2D4L3F2aUv/8vPCUAHlDFsYEDnhocOriulZrDG4aH6tPw6nhlVv2kt3vSH2hNKgBEnpfi8ePKO5rvLvJMq2CSGeVnbSy3xunsfMw4ci1e6kFCXVjgBiwN+cgGHxL4qtnjNena39tmQXwK6ag6KNpo7/pZnVZpcRzjiM2A8VFM2FcjDi+OUMshWodk0Oj9qmIcbO+tJRorRlTV7DaUJFSAvzv4wqQnWyj8/pa0+bOGLfONOJqYudNlNWjmUzudXMwjsl/AOFendExKnRcep+mt35Bf8ucqW57KEZhskExMhAOHoC7ufHIhze4vU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 30.05.25 11:52, Baolin Wang wrote: > > > On 2025/5/30 17:16, David Hildenbrand wrote: >> On 30.05.25 11:10, David Hildenbrand wrote: >>> On 30.05.25 10:59, Ryan Roberts wrote: >>>> On 30/05/2025 09:44, David Hildenbrand wrote: >>>>> On 30.05.25 10:04, Ryan Roberts wrote: >>>>>> On 29/05/2025 09:23, Baolin Wang wrote: >>>>>>> As we discussed in the previous thread [1], the MADV_COLLAPSE will >>>>>>> ignore >>>>>>> the system-wide anon/shmem THP sysfs settings, which means that >>>>>>> even though >>>>>>> we have disabled the anon/shmem THP configuration, MADV_COLLAPSE >>>>>>> will still >>>>>>> attempt to collapse into a anon/shmem THP. This violates the rule >>>>>>> we have >>>>>>> agreed upon: never means never. This patch set will address this >>>>>>> issue. >>>>>> >>>>>> This is a drive-by comment from me without having the previous >>>>>> context, but... >>>>>> >>>>>> Surely MADV_COLLAPSE *should* ignore the THP sysfs settings? It's a >>>>>> deliberate >>>>>> user-initiated, synchonous request to use huge pages for a range of >>>>>> memory. >>>>>> There is nothing *transparent* about it, it just happens to be >>>>>> implemented using >>>>>> the same logic that THP uses. >>>>>> >>>>>> I always thought this was a deliberate design decision. >>>>> >>>>> If the admin said "never", then why should a user be able to >>>>> overwrite that? >>>> >>>> Well my interpretation would be that the admin is saying never >>>> *transparently* >>>> give anyone any hugepages; on balance it does more harm than good for my >>>> workloads. The toggle is called transparent_hugepage/enabled, after all. >>> >>> I'd say it's "enabling transparent huge pages" not "transparently >>> enabling huge pages". After all, these things are ... transparent huge >>> pages. >>> >>> But yeah, it's confusing. >>> >>>> >>>> Whereas MADV_COLLAPSE is deliberately applied to a specific region at an >>>> opportune moment in time, presumably because the user knows that the >>>> region >>>> *will* benefit and because that point in the execution is not >>>> sensitive to latency. >>> >>> Not sure if MADV_HUGEPAGE is really *that* different. >>> >>>> >>>> I see them as logically separate. >>>> >>>>> >>>>> The design decision I recall is that if VM_NOHUGEPAGE is set, we'll >>>>> ignore that. >>>>> Because that was set by the app itself (MADV_NOHUEPAGE). > > IIUC, MADV_COLLAPSE does not ignore the VM_NOHUGEPAGE setting, if we set > VM_NOHUGEPAGE, then MADV_COLLAPSE will not be allowed to collapse a THP. > See: > __thp_vma_allowable_orders() ---> vma_thp_disabled() Interesting, maybe I misremember things. Maybe because process_madvise() could try MADV_COLLAPSE on a different process. And if that process as VM_NOHUGEPAGE set, it could be problematic. -- Cheers, David / dhildenb