From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 50087CCD184 for ; Fri, 17 Oct 2025 05:25:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A695A8E0028; Fri, 17 Oct 2025 01:25:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A19D08E0002; Fri, 17 Oct 2025 01:25:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8E10A8E0028; Fri, 17 Oct 2025 01:25:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 7CA7A8E0002 for ; Fri, 17 Oct 2025 01:25:58 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 2E9EAB9DD1 for ; Fri, 17 Oct 2025 05:25:58 +0000 (UTC) X-FDA: 84006469596.13.4D3007F Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf02.hostedemail.com (Postfix) with ESMTP id 87C5480012 for ; Fri, 17 Oct 2025 05:25:55 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=HObBw0uN; spf=pass (imf02.hostedemail.com: domain of donettom@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=donettom@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1760678755; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nN7TiAZ/MGjE7/97TqtyN6BIKmWAZdJXWKjKQPiHAFo=; b=vnXyeqeiXex4VqsPcRkQMURQIDTd6q38OvNwMAfB92gH4rY8Gw1ucVFN0GFnzlbVXqaGub 20LjhvF7noxjCzmo4GsLRIIHccANqjpWZ8eb+ePG1UzKuUch7Mszbjsyqwnobp38O2MGP8 Bjg/OMUNVswLnHQGN/D0LV9GTItkE3M= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=HObBw0uN; spf=pass (imf02.hostedemail.com: domain of donettom@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=donettom@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1760678755; a=rsa-sha256; cv=none; b=SMMs2e9yucdziP4AFZMrQXpK9rxtIF0IOLh4xOu2lmpd3H26RvnU8IP6rfXSCz1YlS+zdQ MIZWQzMFrEN6oO1SnzfjqVZvhGFmcQw9OVxXT8E9H6Y5wlz5pwLmXVfG2Pe3/a7BeU2Wap uKBUKrpenEv1XXQVPTnOiu2ElxsYn5M= Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 59GIm0tQ021709; Fri, 17 Oct 2025 05:25:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=nN7TiA Z/MGjE7/97TqtyN6BIKmWAZdJXWKjKQPiHAFo=; b=HObBw0uNuMIMUfvHVlr9Ah QbdYTWYTsEt4SVh/I2jPSi5ADASxYNCxVZ/Xcd+YmacvwhmlRsFesXpdfpp5RlL5 Qta93r8srROcm3niCb7DYJTT0VNkpM6d0vemO0lf3wdvpIrDTPHvYCHqBhNNKCrw w8O281tKaB4VoCyoaysNqNDlYpVsCRCOkaODZrlgRG2csCPAXD58DchPT8bFgi5k ky+wueyruJh2kE4j9ky4DOHMXyfg6CsNMohUWrbR9/pPFNk/ovK1K/9z0Yv9M+SW A3VdY9xaCXp9BuaBQB/zwyGcJgEAYRoXSZ//ByPqIjQ4m1EV5oT/8FTGri0mRfyQ == Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 49qey96ynh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 17 Oct 2025 05:25:48 +0000 (GMT) Received: from m0356517.ppops.net (m0356517.ppops.net [127.0.0.1]) by pps.reinject (8.18.1.12/8.18.0.8) with ESMTP id 59H5PYws022298; Fri, 17 Oct 2025 05:25:47 GMT Received: from ppma11.dal12v.mail.ibm.com (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 49qey96yne-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 17 Oct 2025 05:25:47 +0000 (GMT) Received: from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1]) by ppma11.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 59H0i75i028035; Fri, 17 Oct 2025 05:25:46 GMT Received: from smtprelay01.wdc07v.mail.ibm.com ([172.16.1.68]) by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 49tdg9gp4k-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 17 Oct 2025 05:25:46 +0000 Received: from smtpav03.wdc07v.mail.ibm.com (smtpav03.wdc07v.mail.ibm.com [10.39.53.230]) by smtprelay01.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 59H5Pipc33620358 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 17 Oct 2025 05:25:44 GMT Received: from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id BA6F058062; Fri, 17 Oct 2025 05:25:44 +0000 (GMT) Received: from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C1CED5805D; Fri, 17 Oct 2025 05:25:38 +0000 (GMT) Received: from [9.124.220.117] (unknown [9.124.220.117]) by smtpav03.wdc07v.mail.ibm.com (Postfix) with ESMTP; Fri, 17 Oct 2025 05:25:38 +0000 (GMT) Message-ID: <29051a26-d0c5-4ec0-97e8-e32e17a9a6ba@linux.ibm.com> Date: Fri, 17 Oct 2025 10:55:37 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] drivers/base/node: Fold register_node() into register_one_node() To: David Hildenbrand , Andrew Morton , Mike Rapoport , Oscar Salvador Cc: Ritesh Harjani , Aboorva Devarajan , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Madhavan Srinivasan , linuxppc-dev@lists.ozlabs.org, Christophe Leroy , Peter Zijlstra , Ingo Molnar , x86@kernel.org, Greg Kroah-Hartman , rafael@kernel.org, Danilo Krummrich , Dave Jiang References: <910853c9dd61f7a2190a56cba101e73e9c6859be.1760097207.git.donettom@linux.ibm.com> Content-Language: en-US From: Donet Tom In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: xL6UujgZrapbJuP98DZf3K-Jzahsg6az X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMDExMDAxMSBTYWx0ZWRfX6tW0gdb9eF+u NAv4+LuGdkIRfOPXperOzmunxpsCGYvs/UJGU92YP4QtUt+QStkTILJT4rcRXedz5AvvgAG4K8w l5TT5j4wIm8gfPXwkbOub8335Xa9FUK863fVMC8VrU0R6dsOa2+fK4zr9gLnPlYRXlnTwnQOGBo HJPyrGlr+Hd6OZYk5AA7zh2IF2vNenv0zsyVlJIh6ljdMv5jZeXGLk+k32VYAVLjwc+1yb/8MI2 Kj5c1xWYTC/9FkD6SC/4luGVgGisdYQuK5fQSEstlBolValozO12Cypk7aI0/hCZL0xupWtP7Mx ishjIZGV9M2M2Hp8xO1OJGRb/rPPgMC96LymYUccHn/yO+l6asMkscjJLTtF5A0+bd6ASk8xoPA 5TLwDPLELFXOCDAEtuwD9aWqcgP0oQ== X-Proofpoint-GUID: MRs_fUSnLc8GKSOeDOtnOPvNauEZyTiz X-Authority-Analysis: v=2.4 cv=QZ5rf8bv c=1 sm=1 tr=0 ts=68f1d35c cx=c_pps a=aDMHemPKRhS1OARIsFnwRA==:117 a=aDMHemPKRhS1OARIsFnwRA==:17 a=IkcTkHD0fZMA:10 a=x6icFKpwvdMA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=VnNF1IyMAAAA:8 a=20KFwNOVAAAA:8 a=p1EqsZHEuOmFBkmSmkgA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=cPQSjfK2_nFv0Q5t_7PE:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-10-17_02,2025-10-13_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 priorityscore=1501 phishscore=0 bulkscore=0 suspectscore=0 spamscore=0 malwarescore=0 impostorscore=0 clxscore=1015 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2510020000 definitions=main-2510110011 X-Stat-Signature: yj5ns87wb7rk1oi9owxh5155dx53cjcu X-Rspamd-Queue-Id: 87C5480012 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1760678755-451049 X-HE-Meta: U2FsdGVkX1+a2IYruOnIFyFoB/9jzSb+JqwgWnnCleS5+cgERztup5ngCvB9gQLWD+QzD79gBTTL3jH86BwIQclNx5yQkuRhdl0wWSAai680PAcFesOLrpKHwPadF4aZJkInbKFATOjJhPA/CUejVtn6xFIQlaqLip1z4UmfzHwQwVX1QbtJV8iHgyv3rsftBWOP9IpoISVNxNPo/h9s7Fn8OwX522/5YH3D9/O0ZgNXUUvEXpId5WzTF5CuzdLtQAHll52optZ0PQU1WEzsmwdFDfw6KiqE6K00u5zewGufdn+TtIgOz81uhXao3dmhjcvd8kfHWCjEvsTBlZqqEbu1o1FJBElJzEz/M9tlnoXVkoWy3pAwbMFkJ55IWH0BUTP5Skw+QTahyv6x3/sfmURQixC10X6mxE/mbsts3E9vgW9Np16zZI12ReGywF22VcCsF89EI1oD3Vtj78L+HUjDs1nlf9DFIWowpWvfcKjjH2XYOCgKQMnoaMFfPoxaH81+tQvTqVOvcZSirPKoSo/AZCrHnpV4+BnydYO7K228jWSNLKBhR73bI0snNINeYLfHNONCgb/Kw95h1p91gtFf8uQIJWTGm94oKeyWuuwypBIahuOrUqoBRBeq72OwgXTd/DKLwKUcdhNLVnEUdb668s4B0ouiSQbRSL2/gQEEFmHCBjpOf0BF6jtYiq9cFP7mWwY9S0VL3cFTv5GZ2A564y/cwMhjqaRSXIulkoM8FoAxM01CVxwqIrqEu0JQhW4dRpEOIioUCaorahIZ5GFKFYiu1Xbreo2e4mOpsodXdEkexQDPH0fWkILtwM4TM0tCuA6KmQ0ax02b2pjIyPtVoerNlA8GA1CkArBAt+LgOZhaXYrPdK8jAVhWyjwGINyWjwmkPwfXncnhRtIH+gpbcdXHNPpbYgv9mZ7CzlkG8roX6mqkROuTB75JNcnvyoK1MhKmtf+Yf16mHGN uYJWkOgT /ZNeJhnFut9MPL/fXAxScaU+8Y/fT5qLGeKKw3GIghHPo/b394F6FNpiUR7BEem94XNZITXzFsJM+ihY4m5kFRUPs6nibQfnZIKISifOTrcAXogz9ckcU+fwDZ+XJAolrxLquttjSpXf8eYDMOGW80QzNvY6q4AdXQ0TvMujpx6G2vjid9aMXB89ua3906+qcYugaZwrzraf77g0CVaSnMpNMJEOtH8K/SW+xkVOqfzFwQyPjiECEHbfwtxG5kYiqSxCAyiR3WBpAJuXgxGXrwuwhWVQCJ9CGaC1ERnHPlrIIC+ZE2dysfMRBya1JtYfmIKGX+KpWmCU4HLU1OOoHgXvi+lle4nPLlm0/6EJmunFORq44Mat4IRFZf2qQUfgkIcoxUUHZuQJzJpa3CiFDiN0p7IeKWxxsNZj9o6iNV4IDnOjcUBhwPThS4TSy6HsUBSZ+3+36pP40SEizEZ8JD8K0uSeOciKqfYiGuyWtjfN0wpFrNJ2ThWtqEhAPK0czsYvyqNXczczHw3YTkmtmdeuZbSEU2xff2rWrK8ZAUdQgAOZfdc7SEZWan+xyu9/zXQ6B X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/15/25 6:06 PM, David Hildenbrand wrote: > On 14.10.25 17:39, Donet Tom wrote: >> The function register_node() is only called from register_one_node(). >> This patch folds register_node() into its only caller and renames >> register_one_node() to register_node(). >> >> This reduces unnecessary indirection and simplifies the code structure. >> No functional changes are introduced. >> >> Acked-by: Mike Rapoport (Microsoft) >> Signed-off-by: Donet Tom >> --- > [...] > >>   /** >>    * unregister_node - unregister a node device >>    * @node: node going away >> @@ -907,7 +880,13 @@ void >> register_memory_blocks_under_node_hotplug(int nid, unsigned long >> start_pfn, >>   } >>   #endif /* CONFIG_MEMORY_HOTPLUG */ >>   -int register_one_node(int nid) >> +/** >> + * register_node - Initialize and register the node device. >> + * @nid - Node number to use when creating the device. >> > > I assume that should be "@nid: ..." to silence the warning. > > Thank you, David, for pointing this out. Andrew has already applied the fix. > > Acked-by: David Hildenbrand >