From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AC08C83F17 for ; Mon, 14 Jul 2025 08:18:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C013F6B008A; Mon, 14 Jul 2025 04:18:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BB3876B008C; Mon, 14 Jul 2025 04:18:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AC7AB6B0093; Mon, 14 Jul 2025 04:18:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 9A34D6B008A for ; Mon, 14 Jul 2025 04:18:12 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 600255859E for ; Mon, 14 Jul 2025 08:18:12 +0000 (UTC) X-FDA: 83662167624.29.1AE10E3 Received: from smtp.smtpout.orange.fr (smtp-71.smtpout.orange.fr [80.12.242.71]) by imf27.hostedemail.com (Postfix) with ESMTP id 81B3040005 for ; Mon, 14 Jul 2025 08:18:10 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=wanadoo.fr header.s=t20230301 header.b=flZG0Dqm; spf=pass (imf27.hostedemail.com: domain of christophe.jaillet@wanadoo.fr designates 80.12.242.71 as permitted sender) smtp.mailfrom=christophe.jaillet@wanadoo.fr; dmarc=pass (policy=quarantine) header.from=wanadoo.fr ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752481090; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SRoyxxc9lckftvVfA80h43wgqXVemUdnuvpgTZAWo7o=; b=xL5evn8QNd3CblNHxIYJV62b7/uZcFr+UOh4ZvBTVxCmYhqpubd+a+yZloTkJRUYxtaD93 VGbKSwMbAVxgwaj2lEpAxV2sCwjbTz0QJpqS4NsOwYDAtjBx+HEvFqdRb9bUrRpxOl9hwm lukODsVTi/6tLYqglzQL0+6Vn8L/wRI= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=wanadoo.fr header.s=t20230301 header.b=flZG0Dqm; spf=pass (imf27.hostedemail.com: domain of christophe.jaillet@wanadoo.fr designates 80.12.242.71 as permitted sender) smtp.mailfrom=christophe.jaillet@wanadoo.fr; dmarc=pass (policy=quarantine) header.from=wanadoo.fr ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752481090; a=rsa-sha256; cv=none; b=EwmiG4ObZpT9Ciz0TH58jJq2snRtWXI3JFjmQP71OENHdZv/U8PaBqoLMbujMp2pUYJXAG 9virjeK1e7OV0v4Aqoxrqx5dc3oJEZ2xWzjEoy81vmsJ+kMzi4nG/jbKBLPPrNpOQItwi+ CW9h6FZaXeQuI8vYlCndfzSZPNE02Tg= Received: from fedora.home ([IPv6:2a01:cb10:785:b00:8347:f260:7456:7662]) by smtp.orange.fr with ESMTPA id bENfuHN2LILtwbEO1uVIhr; Mon, 14 Jul 2025 10:18:09 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wanadoo.fr; s=t20230301; t=1752481089; bh=SRoyxxc9lckftvVfA80h43wgqXVemUdnuvpgTZAWo7o=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=flZG0DqmobXXkShk7UcxXMb3kQSinB+K3lKz0wJrw2KzzTmM1zsf6MNEQV50Ci2yn AKPNTAR5/w/tk/yN9MAyPrzFBZu+J6KDo6mchBxET2D8YI9fHhRoBrovtdza+ouWVc AfgrNdUVAzPRmfzePpThV7XFtaFgZSCWAtx4QPsZHi+fWKDZs/lkS+sLLYzuHBrCoy sF4DXpaz0lG1TMiMUw/TTD5OzZSY+16MbxRY1sgFfqMOxEYR88mWIOb6MU+asBKHmW 1PpivOYli+YwZhoqzgdb5HhHnvknhLDr0ZClu0qtGUmMDgJ8WZPZYu5k21haMcPp6G +jYsK+rsnsqZQ== X-ME-Helo: fedora.home X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Mon, 14 Jul 2025 10:18:09 +0200 X-ME-IP: 2a01:cb10:785:b00:8347:f260:7456:7662 From: Christophe JAILLET To: willy@infradead.org, srini@kernel.org Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET Subject: [PATCH v3 1/3] idr test suite: Remove usage of the deprecated ida_simple_xx() API Date: Mon, 14 Jul 2025 10:17:08 +0200 Message-ID: <2904fa2006e4fe58eea63aef87fa7f832c7804a1.1752480043.git.christophe.jaillet@wanadoo.fr> X-Mailer: git-send-email 2.50.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Queue-Id: 81B3040005 X-Rspamd-Server: rspam06 X-Stat-Signature: ebnqhmg6k493ipnbnnqnhg9ye93o3i16 X-HE-Tag: 1752481090-777308 X-HE-Meta: U2FsdGVkX1+9QB4H7lUdVTgaFvD9qZtHBLcQY3y9oWgfL+0txon91xOl4SH35dEX1/p7rJ5tEWScllypcaw/drbXMww/Pq+Ivv8OvZCSaIQG60iOYWw/MwKfzmcWRCuVTgbdq+TYA5X0GrgNe42nIOaCcvZMTlRd5k4PEvysGWzTPVH3pZwlztzuqyrcadh7SRLbSxdw9sVI5m21Gr3dm0ShwzPV8x7lpWnSGdj7vmxWWWPirueHsav8B6Fx2lsqW5c5Ys3gGi6hQpnZ9F8vdz5zy77AF/CDm3lyp0Ig32T+FhpeCMuX27YrIsL82y8RD9wVZHX8goY7Zf3AHl9feTvY102MvhWz56m6OjvpOBh2fsJK4x2mxc5k7qTKvOswaHLsBjjkpk8CugqBz1/l/oqtGj4S2fkBOxEDXMtAKaQhSTWDiJ81PD7DgUU1YeB+QPEufxttreuWCPgM/+CPT9Ihb+wN0octNtsFJYbqOoKI8bvfdjaT9c7fhQrXHjvKg6MYRvZZMWzv+QQL5BQBCD0PalBqrg0E5H+JdWm6H7vBuvh6B+sVAVSndnsYE0A5h32/nyc/3HodBj747311z4FhM7VMIzz7F7yTxgLh5BjhDTD0I8LUaINpWGownayydluF5gLe85c6VEmyW1ifu8SYDpdmb8MkmZ5K04c2sGDuv7Sdim1tm0jZ3Y7yLA6r5h+sKpY1k5m/69yeG4Trp8ohXtMK8kbAQdFHuoxoDRAM1QmlzlaKXvuUKcOFcZqpt/al2h92G928sEXHVsfUKlX4lBoHZ74zUbff0a7PWzamHrxbMm3O/BPTkWbVWeov1h/qaihnmc42FTmI2+ZojiagJ/vyt6gwYqxSEQ8nyS97NATbT3yIVb9g7RS5vCbhQbF5WfqivrL3tzQG3tP/4abBPKMlCtguoKl/n1eoyCyh+2ppsfrWlGSUX2x7xady6PYH/tBFGgRQldQcKty 6cmBupIj 16skpJKhvIDHzSz7F2oaptqpAAgZycxwzLSUHqj+Go/Mw5rUyvldGEJNEMntfqNnBVBR1bZoVsTL62pMJAJtfd2FgSIJd4M13NTd3P189GRU94hg02NoNoknPC0dWESChHCZ44lGbefhrKJvenxXZ+cmGjXDU1sM5VnxZXCJ50/fXMuEjC9nhlIRRoXL8hekLV6vtCv1JHhrEsHxsz48/y7h+8V0c5Al4vm2JGx0moYG4G9vTklNA894laX1VoMr7klngEBT4W7FYYzdv0LzIgh2CWPPnKWA5+ZMUZcmEdvqVDthYIzkSQLqdELJ7TQz4P115bcHF4CDY7kGBrT67Ytdzg93DTUNkW/J1FYMBen6q3tLC9bug0W4rFbw+laXjgLeO3iAEDU39/DCnhtilebq9sLBfLYO7qUTKLpyoWupKsmCBenp+9RQPWQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000747, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: ida_alloc() and ida_free() should be preferred to the deprecated ida_simple_get() and ida_simple_remove(). Note that the upper limit of ida_simple_get() is exclusive, but the one of ida_alloc_range()/ida_alloc_max() is inclusive. But because of the ranges used for the tests, there is no need to adjust them. While at it remove some useless {}. Signed-off-by: Christophe JAILLET Acked-by: Matthew Wilcox (Oracle) --- Changes in v3: - No changes v2: https://lore.kernel.org/all/715cff763aa4b2c174cc649750e14e404db6e65b.1722853349.git.christophe.jaillet@wanadoo.fr/ Changes in v2: - This patch was already proposed see [1]. This one also rename the functions used for the test: s/ida_simple_get_remove_test/ida_alloc_free_test/. I've kept the A-b tag given at that time. v1: https://lore.kernel.org/all/81f44a41b7ccceb26a802af473f931799445821a.1705683269.git.christophe.jaillet@wanadoo.fr/ --- tools/testing/radix-tree/idr-test.c | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/tools/testing/radix-tree/idr-test.c b/tools/testing/radix-tree/idr-test.c index 84b8c3c92c79..2f830ff8396c 100644 --- a/tools/testing/radix-tree/idr-test.c +++ b/tools/testing/radix-tree/idr-test.c @@ -499,19 +499,17 @@ void ida_check_random(void) goto repeat; } -void ida_simple_get_remove_test(void) +void ida_alloc_free_test(void) { DEFINE_IDA(ida); unsigned long i; - for (i = 0; i < 10000; i++) { - assert(ida_simple_get(&ida, 0, 20000, GFP_KERNEL) == i); - } - assert(ida_simple_get(&ida, 5, 30, GFP_KERNEL) < 0); + for (i = 0; i < 10000; i++) + assert(ida_alloc_max(&ida, 20000, GFP_KERNEL) == i); + assert(ida_alloc_range(&ida, 5, 30, GFP_KERNEL) < 0); - for (i = 0; i < 10000; i++) { - ida_simple_remove(&ida, i); - } + for (i = 0; i < 10000; i++) + ida_free(&ida, i); assert(ida_is_empty(&ida)); ida_destroy(&ida); @@ -524,7 +522,7 @@ void user_ida_checks(void) ida_check_nomem(); ida_check_conv_user(); ida_check_random(); - ida_simple_get_remove_test(); + ida_alloc_free_test(); radix_tree_cpu_dead(1); } -- 2.50.1