From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84CC6C43334 for ; Fri, 22 Jul 2022 07:55:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 26DD08E0002; Fri, 22 Jul 2022 03:55:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 21C2B6B0073; Fri, 22 Jul 2022 03:55:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0E5418E0002; Fri, 22 Jul 2022 03:55:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id F30846B0072 for ; Fri, 22 Jul 2022 03:55:00 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id D4824140B9A for ; Fri, 22 Jul 2022 07:55:00 +0000 (UTC) X-FDA: 79713974760.15.6375446 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf05.hostedemail.com (Postfix) with ESMTP id 7A9EA100073 for ; Fri, 22 Jul 2022 07:55:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1658476500; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Up7/fSgr7O1nlWjCNCtBbDk3ASUql8ZVCx93hpIvzYU=; b=HbSyb827RgTCsX1FsOP+odgz/4MWjW/LWJ11ndmXxAWpItogo9fJpdE/3I91zH25G/XTkM /gXdwbqnXDRQuti2+5MY6nOJ8zI6sa66sqgR/aHm9/f7qkKoxz6pRwSNLbitG7/aGbCfPN aOCsXTo4EzrD1C53JSjmpufBsdAECj4= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-179-G8n8lsvLMz6oCwFbEbYyLQ-1; Fri, 22 Jul 2022 03:54:58 -0400 X-MC-Unique: G8n8lsvLMz6oCwFbEbYyLQ-1 Received: by mail-wm1-f70.google.com with SMTP id n30-20020a05600c501e00b003a3264465ebso3127983wmr.1 for ; Fri, 22 Jul 2022 00:54:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent :content-language:to:cc:references:from:organization:subject :in-reply-to:content-transfer-encoding; bh=Up7/fSgr7O1nlWjCNCtBbDk3ASUql8ZVCx93hpIvzYU=; b=3Wuc7Sp87s/F/CaN3D6vvEbTvQ9gBLXT/eRSGvxiTs/A1KyFEQkoRqaM9I04uuRFF/ Isu1hP4p1bkXYjnakbOv4eOqBrtEJm8UgpQvs05ZluguPhekKmZEfEy7SSWFWkNAJWE3 BZxnCUVuR+m6BbBgW1Bj3PTgrOnxstpvsVGpdlw8ZZodqhaozzemMxvv7G5wZjYSfrwW fXQJ3X902ReIg6FDNgPoeSTNiwMrzJMgQn3GChH82d0zVMWsUjzEplgYmIPWyw91itvM EPlkB3r7PogfOctsbT24e6EToJj3TRyTGybROTugtkllUilrUG3NkUVCCR4Ye53Dxa2Z 7K4g== X-Gm-Message-State: AJIora9CbFPiviA1zwkM0IIoI3GC2HBCYJxDBKORC7Crll3VIyJxII3u 2X59BJPiZZZFHsmxKTCavAn3mTbdzy7BL6/kPJ7a/K118j2TiP0ePiDZRzhmVMwFJWXR6UAX6yo kRhS4tburC+s= X-Received: by 2002:a05:600c:4f08:b0:3a1:99ed:4f1f with SMTP id l8-20020a05600c4f0800b003a199ed4f1fmr11246096wmq.199.1658476497618; Fri, 22 Jul 2022 00:54:57 -0700 (PDT) X-Google-Smtp-Source: AGRyM1t/e6eiMRLV4T7iMgwrMmqM9ZsLmbt1r5zTBJKVGy19TE3tst6MiUqjj2ZhuCxOX73j6JTmew== X-Received: by 2002:a05:600c:4f08:b0:3a1:99ed:4f1f with SMTP id l8-20020a05600c4f0800b003a199ed4f1fmr11246074wmq.199.1658476497211; Fri, 22 Jul 2022 00:54:57 -0700 (PDT) Received: from ?IPV6:2003:cb:c707:cb00:cd6b:7964:cc7d:b0e6? (p200300cbc707cb00cd6b7964cc7db0e6.dip0.t-ipconnect.de. [2003:cb:c707:cb00:cd6b:7964:cc7d:b0e6]) by smtp.gmail.com with ESMTPSA id t7-20020a05600c198700b003a30af0ec83sm5723640wmq.25.2022.07.22.00.54.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Jul 2022 00:54:56 -0700 (PDT) Message-ID: <28f4cf6c-1770-8628-0fc9-5d7982ede319@redhat.com> Date: Fri, 22 Jul 2022 09:54:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 To: Nadav Amit , linux-mm@kvack.org Cc: Andrew Morton , Nadav Amit , Mike Kravetz , Hugh Dickins , Axel Rasmussen , Peter Xu , Mike Rapoport References: <20220718114748.2623-1-namit@vmware.com> <20220718114748.2623-2-namit@vmware.com> From: David Hildenbrand Organization: Red Hat Subject: Re: [PATCH v2 1/5] userfaultfd: introduce uffd_flags In-Reply-To: <20220718114748.2623-2-namit@vmware.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1658476500; a=rsa-sha256; cv=none; b=iJb4jcdnkOyXiU7mt11RYl9Chk9gBILvDZEb5MbXmQZNd6BE3LEA3CLt4Je0x5v1IOaDWT rGRsxCmLK2H6sjMIgIB8IkfO9lFDDocGQsvJ8Z5ux3d6zhBBhMdut4l04h2c30Qi2pg1z5 Raf64WC78JP7MmD0Ps0j3u3YYF8jEQ0= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=HbSyb827; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf05.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1658476500; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Up7/fSgr7O1nlWjCNCtBbDk3ASUql8ZVCx93hpIvzYU=; b=QxDBqne+sLXxbBYOM50nmMq8eYEFmooPPcKrjI+SsASa0IrgEt/A/1IHpameo0RIiECfcI imfsDLXp/aCFenmmMqlNQLWho2EOMXUyzCBlGTbZwY2qYC1z8+LvkUubSoZJQmx5MLifbM oCYmU3BTHprqXIl6driKePE2ZiCocuk= Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=HbSyb827; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf05.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 7A9EA100073 X-Stat-Signature: d14az9izehdgfdsecgiyw7ib5b4fgn91 X-HE-Tag: 1658476500-249936 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 18.07.22 13:47, Nadav Amit wrote: > From: Nadav Amit > > As the next patches are going to introduce more information that needs > to be propagated regarding handled user requests, introduce uffd_flags > that would be used to propagate this information. > > Remove the unused UFFD_FLAGS_SET to avoid confusion in the constant > names. > > Introducing uffd flags also allows to avoid mm/userfaultfd from being > using uapi (e.g., UFFDIO_COPY_MODE_WP). > > Cc: Mike Kravetz > Cc: Hugh Dickins > Cc: Andrew Morton > Cc: Axel Rasmussen > Cc: Peter Xu > Cc: Mike Rapoport > Acked-by: David Hildenbrand > Signed-off-by: Nadav Amit [...] > > int mwriteprotect_range(struct mm_struct *dst_mm, unsigned long start, > - unsigned long len, bool enable_wp, > - atomic_t *mmap_changing) > + unsigned long len, > + atomic_t *mmap_changing, uffd_flags_t uffd_flags) > { > + bool enable_wp = uffd_flags & UFFD_FLAGS_WP; Could be that this will trigger a sparse warnings, but I haven't fully understood yet when/how sparse will start to complain. If so, this would have to be bool enable_wp = !!(uffd_flags & UFFD_FLAGS_WP); I stumbled into something like that in https://lore.kernel.org/lkml/202202252038.ij1YGn0d-lkp@intel.com/T/ Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb