From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D8E2C02198 for ; Thu, 13 Feb 2025 01:12:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C8B296B007B; Wed, 12 Feb 2025 20:12:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C3AEF6B0083; Wed, 12 Feb 2025 20:12:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B025C6B0085; Wed, 12 Feb 2025 20:12:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 917646B007B for ; Wed, 12 Feb 2025 20:12:58 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 0C2E5C146F for ; Thu, 13 Feb 2025 01:12:58 +0000 (UTC) X-FDA: 83113147236.10.72BEDCC Received: from out-184.mta0.migadu.com (out-184.mta0.migadu.com [91.218.175.184]) by imf24.hostedemail.com (Postfix) with ESMTP id 1D680180019 for ; Thu, 13 Feb 2025 01:12:55 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=BG8Ykno0; spf=pass (imf24.hostedemail.com: domain of yosry.ahmed@linux.dev designates 91.218.175.184 as permitted sender) smtp.mailfrom=yosry.ahmed@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739409176; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DCvt8acAjM6dGUvp/uJWfVH+KiIFeLo3NXreay/RMQs=; b=lykrMiPask7qA5BGa2DcFnWueObAIgtCy20L+GYRygrgRSQ2BV6he2gdzh9lpc48dOOFgL Ldbx9JeQDA/z6nLs6Wi60CNwwtJfekiOhYzCBa5HYJOKzuHlZKiaVeRdffVFPwZGM1LsMq EAN/+NjhNUSJZ7fd3wGdwB5q2EAKWo8= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=BG8Ykno0; spf=pass (imf24.hostedemail.com: domain of yosry.ahmed@linux.dev designates 91.218.175.184 as permitted sender) smtp.mailfrom=yosry.ahmed@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739409176; a=rsa-sha256; cv=none; b=1OaNVuUaUp21B6KXd1nTnuwBxtSABOe09WhFFksKBdz2f0QCkjYbKpLB4uOLip/7t9YhIt FtFkaVcz6KRmqQXUOnWmapww7a+j8i+YAnaTJlMdE6CPnsRcrwSFpu6IIkXBFN8IDa4osg GickbYMWCosNj2ts7XpVA9adY++C0kE= MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1739409173; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DCvt8acAjM6dGUvp/uJWfVH+KiIFeLo3NXreay/RMQs=; b=BG8Ykno0D9tc88+oJYPGgHmXPqe04tXla0kMjoUYlIPOCplUpScQqsg+F8XNn5blfwzCxS gQXBj2GIcih2tOLtky3WnhKm8u7ruzYy6UTnBFrkHySoNgRzcBeCsAXKktpivTG010c/rc T0joKnuusOLKBcmOxoABKVmd50kqCa8= Date: Thu, 13 Feb 2025 01:12:51 +0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Yosry Ahmed" Message-ID: <28ed23c00effdd531a9e027feb0bc08e22fc677d@linux.dev> TLS-Required: No Subject: Re: [PATCH v5 10/18] zsmalloc: factor out pool locking helpers To: "Sergey Senozhatsky" Cc: "Sergey Senozhatsky" , "Andrew Morton" , "Kairui Song" , "Minchan Kim" , linux-mm@kvack.org, linux-kernel@vger.kernel.org In-Reply-To: <5htndqx74yv2lq2zr2odozrrbi5cz6zizn3vk4uosobn4ceoji@5zuknjmi26f6> References: <20250212063153.179231-1-senozhatsky@chromium.org> <20250212063153.179231-11-senozhatsky@chromium.org> <5htndqx74yv2lq2zr2odozrrbi5cz6zizn3vk4uosobn4ceoji@5zuknjmi26f6> X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 1D680180019 X-Stat-Signature: o1f33ijdigk4m8w91xjsms1unenaxqyk X-Rspam-User: X-HE-Tag: 1739409175-408489 X-HE-Meta: U2FsdGVkX1+o6g015rV8vvsWbZTnz7hqIu5gRhoXKS8qeJjqtYIxLqFPhRP3mUS+GJt+//wPP0c+U7rmCXGnI6toy8UFug6W6SE5pdp3gDvT92vYX3qjSKdgfEAHaD8EU1lVcQoT/fR/qp+qScbRDt+oe6cVgYXOf0yqHPCjOh1gPxvrkGU+Q4Un3GpBoVdJf5znmTkQw1Kmf/1E7dRFOsocLKr3ZHQ3trKOury6kYqc4i/R32v3KBwoXxv+8D4wQs0mdd9GrLQmgWrEASI4PV7bbKr4BlraCh1rumWbPOrmKR9PRSuM2WWtEav28Xlav14hPrbe1CaBsJYL0EOTv5wCBibv6ycpC+TfE4EzgGKwa97qzLX5RZisn5OxlTQa21NDkQtySskEQNr4i9wtKVn9+jm+4pmyOFta33xy7Pk2FupENrFZaxwtMFLT/ooIL6Uzx4GHR8VwEs530A4L2k1iRNiQuo8MuiXcs7SroadzFh5MQwxHNVZhR49eT9fGQFbkfm7HOYa67RCGGyB4upLcfDx8maaGN/EgEyMI43CNExBBmS2Ba012RbTQRa454sCVKzkA8zY8M3W8bKbBLUObURycogn5ScG4ZVlP2dmdM8R+VprmUnyveQ/gXxF5X7Kc/VpKfwBNPjqxk+zYWEwqkV49ibwrM7EjQDyWNsnbhO8ulmjsPH+W1Cu/aXh6hcnOSHj6Bs0dtQ/NXQkCQ/8gEoRGwUzqMY5vy7rE2iFByFYZXqMJ9g8VrJRn7swQIWzI68kvvjjfhBYt7F0P2W0IC06QUVhpr5eg/gcBHxGw0mffE7B3ieJ5FQu7mCE2XRKAK1HgbZUs3kQwZo6mSgP+vgQff4Pz8biXv1uUieNU+TeV0NuuQSKEx1S2vFLIPYDMxDFCtjEPAZAiFvyNboUKZkkrpLQo9WIU6pecPZFjlUo8hnrZ2aHWsjdVvj5c8oBf1uN2csz6joZssgw TOicB93i yK4I7pQ5zfnMUsK+e8atecnyBVokMFiNtxx6XPgi3/mxFfKKm4Lw4rDijUHgFfFoESSlc1gKBL5wus5H/ULGkb5a4CEXyvXcdjxeXsS9gguyT10rsFKVKdp5ETIMan1ItDL5XVZaULoDxamGTHUko6eYqrLBsYK9Yp3ARIrezG4vgukZbgGby1wupjJxRXYt9MrBxIXmpHnSxGA8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: February 12, 2025 at 4:57 PM, "Sergey Senozhatsky" wrote: >=20 >=20On (25/02/12 16:18), Yosry Ahmed wrote: >=20 >=20>=20 >=20> On Wed, Feb 12, 2025 at 03:27:08PM +0900, Sergey Senozhatsky wrote: > >=20 >=20> We currently have a mix of migrate_{read,write}_lock() helpers > >=20 >=20> that lock zspages, but it's zs_pool that actually has a ->migrate_= lock > >=20 >=20> access to which is opene-coded. Factor out pool migrate locking > >=20 >=20> into helpers, zspage migration locking API will be renamed to > >=20 >=20> reduce confusion. > >=20 >=20>=20=20 >=20>=20 >=20> It's worth mentioning that zsmalloc locks sync not only migration, > >=20 >=20> but also compaction. > >=20 >=20>=20=20 >=20>=20 >=20> Signed-off-by: Sergey Senozhatsky > >=20 >=20>=20=20 >=20>=20 >=20> FWIW I don't see a lot of value in the helpers (renaming the lock = is > >=20 >=20> useful tho). > >=20 >=20 > I want to hide the details, keep them in one place and at some >=20 >=20point *in the future* have the same "locking rules" as for zspage >=20 >=20lock. Also *possibly* throwing a couple of lockdep assertions. >=20 >=20So I'd prefer to abstract all of these. I'd prefer to introduce the abstractions when they are needed tbh. Right = now they just make the code less readable.