From: John Hubbard <jhubbard@nvidia.com>
To: Randy Dunlap <rdunlap@infradead.org>,
"Song Bao Hua (Barry Song)" <song.bao.hua@hisilicon.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: Linuxarm <linuxarm@huawei.com>,
Ralph Campbell <rcampbell@nvidia.com>,
John Garry <john.garry@huawei.com>
Subject: Re: [PATCH] mm/gup_benchmark: GUP_BENCHMARK depends on DEBUG_FS
Date: Sat, 7 Nov 2020 20:55:59 -0800 [thread overview]
Message-ID: <28eb72a6-37de-6e60-9127-d1678aac5f5c@nvidia.com> (raw)
In-Reply-To: <e08c812d-80bf-12ec-794e-a726a1b37433@infradead.org>
On 11/7/20 8:11 PM, Randy Dunlap wrote:
...
> Look at kconfig-language.rst instead.
aha, yes.
>
> One thing that could be done (and is done in a few places for other reasons) is to add
> a Kconfig comment if DEBUG_FS is not enabled:
>
> comment "GUP_TEST needs to have DEBUG_FS enabled"
> depends on !GUP_TEST && !DEBUG_FS
>
Sweet--I just applied that here, and it does exactly what I wanted: puts a nice clear
message on the "make menuconfig" screen. No more hidden item. Brilliant!
Let's go with that, shall we?
thanks,
--
John Hubbard
NVIDIA
next prev parent reply other threads:[~2020-11-08 4:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-04 10:05 Barry Song
2020-11-07 0:12 ` John Hubbard
2020-11-07 19:05 ` Song Bao Hua (Barry Song)
2020-11-07 19:16 ` John Hubbard
2020-11-07 22:20 ` Randy Dunlap
2020-11-08 0:03 ` John Hubbard
2020-11-08 0:24 ` Randy Dunlap
2020-11-08 1:10 ` John Hubbard
2020-11-08 2:58 ` Song Bao Hua (Barry Song)
2020-11-08 3:14 ` John Hubbard
2020-11-08 3:22 ` John Hubbard
2020-11-08 4:11 ` Randy Dunlap
2020-11-08 4:34 ` Song Bao Hua (Barry Song)
2020-11-08 4:55 ` John Hubbard [this message]
2020-11-08 7:35 ` Song Bao Hua (Barry Song)
2020-11-08 7:53 ` John Hubbard
2020-11-08 4:05 ` Song Bao Hua (Barry Song)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28eb72a6-37de-6e60-9127-d1678aac5f5c@nvidia.com \
--to=jhubbard@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=john.garry@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxarm@huawei.com \
--cc=rcampbell@nvidia.com \
--cc=rdunlap@infradead.org \
--cc=song.bao.hua@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox