From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 447AEC433EF for ; Wed, 23 Mar 2022 17:22:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 876B66B0072; Wed, 23 Mar 2022 13:22:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 822F16B0073; Wed, 23 Mar 2022 13:22:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 675AB6B0074; Wed, 23 Mar 2022 13:22:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0037.hostedemail.com [216.40.44.37]) by kanga.kvack.org (Postfix) with ESMTP id 58C586B0072 for ; Wed, 23 Mar 2022 13:22:18 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 0E1A21828D82E for ; Wed, 23 Mar 2022 17:22:18 +0000 (UTC) X-FDA: 79276319556.23.FF51D20 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf16.hostedemail.com (Postfix) with ESMTP id 5CF95180031 for ; Wed, 23 Mar 2022 17:22:17 +0000 (UTC) Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 22NFJMPv032682; Wed, 23 Mar 2022 17:21:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2021-07-09; bh=OnAis6fAq8Ulpu0uRruoL1MVvks1PMXCBRmVRNgVL0I=; b=Hw2I8prUe4gmH6KsnjQTlFBSwpHAdnKoP82/UG01VYh+9Hu5bBZu/sO6KTA8RtdM2XVQ bKCzfXNPcR4M2Ji3DGE8W7wC+x9BQIPjSbMOUowhE12IK3wJg8LRARMP2fsYgCZ0NyFu fRFh3iJzf/jkGwF/pqTjgTpPMv9u6g3NXel7cXrM1Ond1wjr5TIOyfOCvIJ666WbBAyx aNwkQhpAwZ/1u2D5SbSilOGnk4Q8fiHYOet9Ca2ry/U1iYgZyRfb/ai2Lmd30dV80WZK PRwL3uByqldlEkDl8vCx2PfBmNp/eY+Fcal20mL+hlEu3kozTjCp+27tMn46mlosGgHQ Aw== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by mx0b-00069f02.pphosted.com with ESMTP id 3ew7qtabut-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 23 Mar 2022 17:21:42 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 22NHGRxg082933; Wed, 23 Mar 2022 17:21:41 GMT Received: from nam04-mw2-obe.outbound.protection.outlook.com (mail-mw2nam08lp2175.outbound.protection.outlook.com [104.47.73.175]) by aserp3020.oracle.com with ESMTP id 3ew701ppsh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 23 Mar 2022 17:21:41 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aubinwqFZg6E6LAr6zSgSBY21cnfgWoyZ6TAOor0gMF4vOnBiNgwYF5l+G6EWWddK/vvbV4G2pKVvJeWT79DBIGhvVsIeXayGHBRg3tWlydMw+mNBiUG0I3Hxo6BdamqFofLMzCSOaksCYa+IfP276S5uybqpWrRtkHw2N1roc6QjKhOmp//Miqll0EhxPf9pSnwvxZI4JAO3uyobLMGxksB+YFfk++11HgG3yrBpjsQ4gtnRAhICEbSH9A+1Li6zZyIAO7AHkgECDYEtkzB38BA5E0CnXaDs78aOWBZQMS1pzybJE7AJgex1SO63QYbpc4k12t/VwYCT89UZdTjvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OnAis6fAq8Ulpu0uRruoL1MVvks1PMXCBRmVRNgVL0I=; b=NVo3e/c3SMxMdqaDniKKt1MwqRy73l4JGq19ETHxtgBzpkN3z+6LlyO2NYAn/k3i9cKPAPqx95ixg++2eUaycIxGvddB+nPZ3ox8ubq2a0pLGls76S4xe7/dxgd8FWkGumYEcpzN8RsSngSPR7RQR0WkAgskPajllO2Umo0vtK6bI5BUiGJNNN0bp4gEnwEyGxbt6jXY6pFvimGC6RG9fSEVhN6O1lOQs+QVkfdjYt4Uxr9qgwcw2WEPOFJQy0mTJzuiJrRmOGYyDNDx7/gyr8TQ8lTWqGY5ci+vGN/PC08GSIv6enki7p6Vby/hqiYNvVFH9te9w8vGZS1yFYT2SQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OnAis6fAq8Ulpu0uRruoL1MVvks1PMXCBRmVRNgVL0I=; b=aIgROmJAkVzap5JBp3JnKxrDNwvhG4B+DDavlZuAQ4X7K/p5cV0ZEX7pPBY+x0VC4g546kOa0wu76p2Kxd3kfusw+ki4NEdOttNiW3ZS/PDbklWmnfUqskxGDz5TePZWYNHon5dJrUxJOzQfACenxA0AdDFpwq9TQ8gjOI4BCRs= Received: from BY5PR10MB4196.namprd10.prod.outlook.com (2603:10b6:a03:20d::23) by BN7PR10MB2499.namprd10.prod.outlook.com (2603:10b6:406:ca::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5102.16; Wed, 23 Mar 2022 17:21:38 +0000 Received: from BY5PR10MB4196.namprd10.prod.outlook.com ([fe80::245f:e3b1:35fd:43c5]) by BY5PR10MB4196.namprd10.prod.outlook.com ([fe80::245f:e3b1:35fd:43c5%7]) with mapi id 15.20.5102.017; Wed, 23 Mar 2022 17:21:38 +0000 Message-ID: <28c8bf2e-f47f-d62d-6490-dc808ec25979@oracle.com> Date: Wed, 23 Mar 2022 10:21:34 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: VM_BUG_ON(!tlb->end) on munmap() with CONT hugetlb pages Content-Language: en-US To: Steve Capper , Catalin Marinas , "Aneesh Kumar K . V" Cc: David Hildenbrand , "linux-mm@kvack.org" , anshuman.khandual@arm.com, Will Deacon , Peter Zijlstra , nd@arm.com References: <811c5c8e-b3a2-85d2-049c-717f17c3a03a@redhat.com> <993f1258-6550-e5d7-1e6f-72e2a24b60f0@oracle.com> <3ba18a1d-d5d8-558f-9576-8119c210e98a@oracle.com> <881efece-c362-af41-4dea-77db71ec9928@arm.com> From: Mike Kravetz In-Reply-To: <881efece-c362-af41-4dea-77db71ec9928@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MWHPR02CA0015.namprd02.prod.outlook.com (2603:10b6:300:4b::25) To BY5PR10MB4196.namprd10.prod.outlook.com (2603:10b6:a03:20d::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e961338b-ae72-4016-aa11-08da0cf195e3 X-MS-TrafficTypeDiagnostic: BN7PR10MB2499:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2G1oYVMJbB3DfYDuii6ak3RlyhiVsfkELGo4TSMAB1Fd9hcODuxc6jSy5c3ObdIXlDpiBZ58cBRMOkmbHFY+/WmI+MILXMvjw0tulBg0k2VJRG2Doqx7Y3hl2xw5vZqbXwq+gm+siW+8GjrA5H7D8o6Ccz9J2poSUyfvyHJu+OJqrJhlOQYldZMzsUXphpjZEBtjGYJqG2GixaWwI15yZIxllwX7S1biTNktHt5nt/y1WsRFeeUCY1NNXc4EvBPCA9KIWbJgdJPpH02JMaVrSOIlynLZGjvk+pPFawKZgjkTOrOMH9VLjy3VT3ZNqqhMMMkqg2+P2yfHPd0p8EWQq6J1ac4iRBhqc9iFnU6ruhpLeN50Lc9uVhQlF3zgbZlhslpxLdHf3kkctHUBOcNNstMIUa1cocLP2uvA+ow9zJwbbv/hQrutKq8Mtny9Raqk9q7O+LnQRE0+2tYLPpXt7/PoIzTHnOzLF96n242iHjjWaRfIYk+FI1HkJYRNADApHetBXMBPTP/3rkMCiei6unqHoqHw9onWhm/eA6uOzcR8TNl3kYDDYiFK0C2w2YpCnT2YMIML4rrQcAn/1+qDgGr5CjAKtfdVRnelLh48FMM4dlAgcXwbLuxrXG+oQS3Qj3rTMeVkmoelUPnvC62/g1fmb6xklxyKtGpU3qr+4pL68coThsKsVARas2cR6cE5XAV+Z1f16awh0RcEt9iErpuMMpibrECJCP+JI44me9/pFhZsenikA3GgI6HEfUISfhmzazEwYPkTEwapZu2u6w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY5PR10MB4196.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66476007)(66946007)(53546011)(36756003)(66556008)(26005)(110136005)(316002)(54906003)(186003)(38100700002)(8676002)(38350700002)(4326008)(2906002)(52116002)(6666004)(6506007)(6512007)(508600001)(2616005)(31696002)(86362001)(5660300002)(44832011)(8936002)(6486002)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VzJ6ZGtYZ3JBOVEramdxMUFuNkRUeXcvMWZFUGJjK3ZmWWFnbno5WU1JOVZs?= =?utf-8?B?Z3FVTWNFekxYUmpWNGhXeTY1a2FxS1VWZ2xoZTlkKzNPbUVWV0FZTXhwQytF?= =?utf-8?B?bkIxVGVYOEsxMGRHQ0U4c0VOekQrSFVIZ2pva2RqVGRCRFF6SXlaYmxsRzNT?= =?utf-8?B?TlJJWjhYMm05QlI3VXJ3ZEhvcGtRbkltQ0hEVlA4NUFIYnJoaVoyN0lMSkNK?= =?utf-8?B?bEF5RGt5TWZnN01DUkNyeFZ3MVRWTStEVENCYjBXSmU3WnhlbHFuS3R4MEpT?= =?utf-8?B?UnBUNWUxaFRkS1VXLy8xd25MZU5EY3NiWlZGdjduZzRDNUxUOW4wazZtMFRs?= =?utf-8?B?S3dtMitXMmRyQkV5VTEzNmxxbXJselV2cVBTSTNFTzZaU2JCUVVWNERSOW9J?= =?utf-8?B?ZWNqVDEwZG5XUFpJZVR2cFVXWTFBanNEWGlzcllUcWJxU0VxZzJzcERnVUk5?= =?utf-8?B?T2lvaTVRa1c3UDJGemFVczg0UUNLZG5qOXBKMk9SRVZKb0tYcXphbDczS296?= =?utf-8?B?T20wbHRrVXJFcmttbTBjeGhzTXdYbnp4bUpmTS9ESFhxTUlDYklEWGNlQzRn?= =?utf-8?B?NzJCRm5OK1pEaWYzeUZnUUpKd2xBS3NvZ2V5d2wzSVl1YnZWWE5nSzNjQTdZ?= =?utf-8?B?N08ra3dHZkZPU1ViTVM3aVp6blhTQXZTbEIxOVdzS3prSWJNdE02RDZIYVlp?= =?utf-8?B?T3F5RzB5a0Y1YWFVOE9ZbXJmNTZJN2l6ejRGQzcwbG5seEFrMUZlN0ZaYTUw?= =?utf-8?B?ZVRjTUZOQ2lXK3hBMzJyTjJFWC9TbjluQzI4TXJFSDdScHk5UVA4cjUvRU01?= =?utf-8?B?cW01Y0ZuR2R0UGNrODFqdTNhRWFqeDg3aml0K3E2bTI4OCthYXltNnc1RDVh?= =?utf-8?B?cnNvNVozcjZjRWxmZFQwUndWVGVCU0QzVjUxZXpBRmtmd3I2OVJKSjBwbTVw?= =?utf-8?B?ZktZdmplYzhJWnJJYjBQOEg2bEQ1R3pSQ3J3c2F1OVdNalNZdC8xNW1aQzNy?= =?utf-8?B?bGxsNTlUb2dsSXlORk5iUUpJMENhNFZJNjIrcWFoeFc4a3lyMUdZTk41bzRY?= =?utf-8?B?WldLRzM2UWZUMXR2RnkyQkY3bW1BTG5mUjRTRkhVZENTQU9VZWh1NTJETzdE?= =?utf-8?B?OFg3UU1WeGp3S0NFenZIbjF5TEtMZDUwUUdrbmVrT0cxVjZDakhzbU4wV3RG?= =?utf-8?B?V0hLS1JLVFZOYmI3aUNRM0paaEZWRTVwSko3UmQ3ZVpoTk5RUytPNDUwVFB4?= =?utf-8?B?enRyRjRvSlpmMmUvT0dNMW9QcVQ5V2Izd3Q2c0VtaHBDRFRSM1FHdFNWeEgv?= =?utf-8?B?eE9oNlI0RWFGMTJoUWVMSDdtUDZUVkFETzUyS3R3QmthcHFzZjBzYlBlWE1D?= =?utf-8?B?a0JwSEtYNEtJOHNqUmxLS1ZGZ2JKWDhiSjhydTM1MXJYOXZYZDBrRUlIODRN?= =?utf-8?B?a1d2bFIvT2JoVTIzSDJLeUxwaHo1WVpXMFJWb3VCaGY0QzYvNkZtODhsejFS?= =?utf-8?B?VnI2cEZFcjlPdXh4MlZLQldQbTVnanJQdmVycUtoRmw0bzJnS0lOdVcvTGdU?= =?utf-8?B?a01DMk1zKzU1ZWxpL3lwY0pncVJLQVFKZkl6NVp0N05Qd3k3MlhEa2YzTUxJ?= =?utf-8?B?MFhRRk9iOXBOMDhLMXhtY01MYk14M1JpRCtWalJoNEc1bHNZN2tsRUV1ZjZP?= =?utf-8?B?eldzejl4RGY2T3FVZlpmZXg0K3lpRytYenpEQWM5YzRkd1BNeUJoL2h6RHJV?= =?utf-8?B?U3NrTENOODAxbGczakJBQlRKVzVobHp6TDluSTllNmFxSWhkMktXeE03RnpI?= =?utf-8?B?bUU5SU51Q00rSXB0elpNVVBzSW8vakNUenA5QzV2WHFNakRhcVg1ci9HNHI5?= =?utf-8?B?cWJraFV1eGhtRGxwK1BkY01sdWtiL1hWWHdmWmJ2M0xNWHgvaGdnWGVLRTVa?= =?utf-8?B?UEVNeThhUzJaRnRROEVxZmlnTHprcUVMNGxBREZ4QWkyQVpiYm1mdzlxVlVk?= =?utf-8?B?dldHekUxSFF3PT0=?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: e961338b-ae72-4016-aa11-08da0cf195e3 X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2022 17:21:38.5388 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: i6cEMt5kFV04eg25dhoZwkNvnK6T60u+ybOH10U4OHPBPeK81svlfxKsRFjQM3hSqXB2DNiAxLhDpehz1CmC8g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR10MB2499 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10295 signatures=694973 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 spamscore=0 malwarescore=0 suspectscore=0 mlxlogscore=999 bulkscore=0 phishscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2203230092 X-Proofpoint-GUID: DPrAypdAYAQmXKur9aHL2Rsb8aLGKlg7 X-Proofpoint-ORIG-GUID: DPrAypdAYAQmXKur9aHL2Rsb8aLGKlg7 Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2021-07-09 header.b=Hw2I8prU; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=aIgROmJA; spf=none (imf16.hostedemail.com: domain of mike.kravetz@oracle.com has no SPF policy when checking 205.220.165.32) smtp.mailfrom=mike.kravetz@oracle.com; dmarc=pass (policy=none) header.from=oracle.com X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 5CF95180031 X-Stat-Signature: 3odio7d33nb9brh1wcaupu9nhhfb76th X-HE-Tag: 1648056137-332546 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/23/22 09:34, Steve Capper wrote: > > > On 23/03/2022 16:21, Catalin Marinas wrote: >> On Wed, Mar 23, 2022 at 11:51:25AM +0000, Steve Capper wrote: >>> On 22/03/2022 17:56, Catalin Marinas wrote: >>>> At a quick look, we wouldn't have a problem with missing TLB flushing >>>> since huge_ptep_get_and_clear() does this for contiguous PTEs. Not sure >>>> why it needs this though, Steve added it in commit d8bdcff28764. I think >>>> we can defer this flushing to tlb_remove_page_size(). >>> >>> The TLB flush in huge_ptep_get_and_clear() was added because it was called >>> by hugetlb_change_protection() without any flushing. The concern was that, >>> without the flush, it would be possible to get to different views of the >>> same contiguous huge page. (Being contiguous they were not changed en masse >>> atomically). >> >> Maybe the code paths have been changed since but looking at >> hugetlb_change_protection(), we have huge_ptep_modify_prot_start() >> calling huge_ptep_get_and_clear() which AFAICT only needs to clear the >> ptes. huge_ptep_modify_prot_commit() calls set_huge_pte_at() which does >> another pte clearing + TLBI (clear_flush()) before setting the new ptes. >> So we do the pte clearing and TLBI twice already. >> > > Thanks, yeah indeed the code has changed and the flush should be removed from the arm64 huge_ptep_get_and_clear. > Thanks Catalin and Steve for the arm64 expertise. Aneesh, IIUC powerpc also has hugetlb sizes that are not PMD_SIZE or PUD_SIZE. Is that correct? If so, then I would expect the same issue there. Steve's patch makes tlb_remove_huge_tlb_entry able to be arch specific, so there may need to be a powerpc specific version. -- Mike Kravetz