[PATCH] Makes slab pages field in show_free_areas() separate two field

[PATCH] Makes slab pages field in show_free_areas() separate two field

[KOSAKI Motohiro]

Subject: [PATCH] Makes slab pages field in show_free_areas() separate two field

if OOM happed, We really want to know the number of rest reclaimable pages.
Then, reclaimable slab and unreclaimable slab shouldn't be mixed displaing.


Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
---
 mm/page_alloc.c |    7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

Index: b/mm/page_alloc.c
===================================================================
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -2119,7 +2119,8 @@ void show_free_areas(void)
 		" inactive_file:%lu"
 		" unevictable:%lu"
 		" dirty:%lu writeback:%lu unstable:%lu\n"
-		" free:%lu slab:%lu mapped:%lu pagetables:%lu bounce:%lu\n",
+		" free:%lu slab_reclaimable:%lu slab_unreclaimable:%lu\n"
+		" mapped:%lu pagetables:%lu bounce:%lu\n",
 		global_page_state(NR_ACTIVE_ANON),
 		global_page_state(NR_ACTIVE_FILE),
 		global_page_state(NR_INACTIVE_ANON),
@@ -2129,8 +2130,8 @@ void show_free_areas(void)
 		global_page_state(NR_WRITEBACK),
 		global_page_state(NR_UNSTABLE_NFS),
 		global_page_state(NR_FREE_PAGES),
-		global_page_state(NR_SLAB_RECLAIMABLE) +
-			global_page_state(NR_SLAB_UNRECLAIMABLE),
+		global_page_state(NR_SLAB_RECLAIMABLE),
+		global_page_state(NR_SLAB_UNRECLAIMABLE),
 		global_page_state(NR_FILE_MAPPED),
 		global_page_state(NR_PAGETABLE),
 		global_page_state(NR_BOUNCE));


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH] Makes slab pages field in show_free_areas() separate two field

[Minchan Kim]

On Tue, Jun 30, 2009 at 3:25 PM, KOSAKI
Motohiro<kosaki.motohiro@jp.fujitsu.com> wrote:
> Subject: [PATCH] Makes slab pages field in show_free_areas() separate two field
>
> if OOM happed, We really want to know the number of rest reclaimable pages.
> Then, reclaimable slab and unreclaimable slab shouldn't be mixed displaing.

Yes. It makes sense to me.

>
>
> Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Reviewed-by: Minchan Kim <minchan.kim@gmail.com>

> ---
>  mm/page_alloc.c |    7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
>
> Index: b/mm/page_alloc.c
> ===================================================================
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -2119,7 +2119,8 @@ void show_free_areas(void)
>                " inactive_file:%lu"
>                " unevictable:%lu"
>                " dirty:%lu writeback:%lu unstable:%lu\n"
> -               " free:%lu slab:%lu mapped:%lu pagetables:%lu bounce:%lu\n",
> +               " free:%lu slab_reclaimable:%lu slab_unreclaimable:%lu\n"
> +               " mapped:%lu pagetables:%lu bounce:%lu\n",
>                global_page_state(NR_ACTIVE_ANON),
>                global_page_state(NR_ACTIVE_FILE),
>                global_page_state(NR_INACTIVE_ANON),
> @@ -2129,8 +2130,8 @@ void show_free_areas(void)
>                global_page_state(NR_WRITEBACK),
>                global_page_state(NR_UNSTABLE_NFS),
>                global_page_state(NR_FREE_PAGES),
> -               global_page_state(NR_SLAB_RECLAIMABLE) +
> -                       global_page_state(NR_SLAB_UNRECLAIMABLE),
> +               global_page_state(NR_SLAB_RECLAIMABLE),
> +               global_page_state(NR_SLAB_UNRECLAIMABLE),
>                global_page_state(NR_FILE_MAPPED),
>                global_page_state(NR_PAGETABLE),
>                global_page_state(NR_BOUNCE));
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>



-- 
Kinds regards,
Minchan Kim

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>