From: "MinChan Kim" <minchan.kim@gmail.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Balbir Singh <balbir@linux.vnet.ibm.com>
Cc: linux-mm <linux-mm@kvack.org>, Rik van Riel <riel@redhat.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Lee Schermerhorn <lee.schermerhorn@hp.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Race condition between putback_lru_page and mem_cgroup_move_list
Date: Mon, 4 Aug 2008 23:36:25 +0900 [thread overview]
Message-ID: <28c262360808040736u7f364fc0p28d7ceea7303a626@mail.gmail.com> (raw)
I think this is a race condition if mem_cgroup_move_lists's comment isn't right.
I am not sure that it was already known problem.
mem_cgroup_move_lists assume the appropriate zone's lru lock is already held.
but putback_lru_page calls mem_cgroup_move_lists without holding lru_lock.
Repeatedly, spin_[un/lock]_irq use in mem_cgroup_move_list have a big overhead
while doing list iteration.
Do we have to use pagevec ?
--
Kinds regards,
MinChan Kim
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2008-08-04 14:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-04 14:36 MinChan Kim [this message]
2008-08-04 15:31 ` Lee Schermerhorn
2008-08-04 16:37 ` KOSAKI Motohiro
2008-08-04 17:52 ` Balbir Singh
2008-08-04 23:52 ` MinChan Kim
2008-08-05 6:20 ` KOSAKI Motohiro
2008-08-05 10:46 ` Balbir Singh
2008-08-05 11:19 ` KOSAKI Motohiro
2008-08-05 11:38 ` KOSAKI Motohiro
2008-08-06 16:53 ` Lee Schermerhorn
2008-08-07 11:00 ` KOSAKI Motohiro
2008-08-07 11:27 ` Lee Schermerhorn
2008-08-07 12:42 ` Balbir Singh
2008-08-05 3:49 ` kamezawa.hiroyu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28c262360808040736u7f364fc0p28d7ceea7303a626@mail.gmail.com \
--to=minchan.kim@gmail.com \
--cc=balbir@linux.vnet.ibm.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=lee.schermerhorn@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox