From: "minchan kim" <minchan.kim@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Martin Bligh <mbligh@mbligh.org>,
Nick Piggin <nickpiggin@yahoo.com.au>
Subject: Re: [PATCH] remove duplicating priority setting in try_to_free_p
Date: Mon, 28 Jan 2008 21:38:57 +0900 [thread overview]
Message-ID: <28c262360801280438s59b6957bnffa5f3cf75f93014@mail.gmail.com> (raw)
In-Reply-To: <20080128010102.8cbcbdda.akpm@linux-foundation.org>
I agree with you.
If you will have a test result, Let me know it.
On Jan 28, 2008 6:01 PM, Andrew Morton <akpm@linux-foundation.org> wrote:
> On Mon, 28 Jan 2008 15:43:56 +0900 "minchan kim" <minchan.kim@gmail.com> wrote:
>
> > > I think this is actually a bugfix. The code you're removing doesn't do the
> > >
> > > if (priority < zone->prev_priority)
> > >
> > > thing.
> > >
> >
> > shrink_zones() in try_to_free_pages() already called
> > note_zone_scanning_priority().
> > So, it have done it.
>
> note_zone_scanning_priority() will only permit ->prev_priority to logically
> increase, whereas the code which you've removed will also permit
> ->prev_priority to logically decrease. So I don't see that they are
> equivalent?
>
>
--
Kinds regards,
barrios
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2008-01-28 12:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-26 7:29 minchan kim
2008-01-28 5:33 ` Andrew Morton
2008-01-28 6:43 ` minchan kim
2008-01-28 9:01 ` Andrew Morton
2008-01-28 12:38 ` minchan kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28c262360801280438s59b6957bnffa5f3cf75f93014@mail.gmail.com \
--to=minchan.kim@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mbligh@mbligh.org \
--cc=nickpiggin@yahoo.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox