From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39B23C433FE for ; Mon, 28 Nov 2022 07:43:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 75F086B0072; Mon, 28 Nov 2022 02:43:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 70F996B0073; Mon, 28 Nov 2022 02:43:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5FD686B0074; Mon, 28 Nov 2022 02:43:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 53AD06B0072 for ; Mon, 28 Nov 2022 02:43:53 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 0B7841604C9 for ; Mon, 28 Nov 2022 07:43:53 +0000 (UTC) X-FDA: 80182061946.20.30FCF7F Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf24.hostedemail.com (Postfix) with ESMTP id 5C6A118000E for ; Mon, 28 Nov 2022 07:43:52 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DF3D2D6E; Sun, 27 Nov 2022 23:43:57 -0800 (PST) Received: from [10.162.40.16] (unknown [10.162.40.16]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 547753F73B; Sun, 27 Nov 2022 23:43:48 -0800 (PST) Message-ID: <28b976dd-3d12-3f2c-9b70-a5423255943e@arm.com> Date: Mon, 28 Nov 2022 13:13:45 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH] s390/mm: Use pmd_pgtable_page() helper in __gmap_segment_gaddr() Content-Language: en-US To: Alexander Gordeev Cc: linux-mm@kvack.org, Christian Borntraeger , David Hildenbrand , Heiko Carstens , Andrew Morton , kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221125034502.1559986-1-anshuman.khandual@arm.com> From: Anshuman Khandual In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=none; spf=pass (imf24.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669621432; a=rsa-sha256; cv=none; b=DjsFcf0BxE1/P8+q2BalxepFiY2GjDJMYUKXFO7br7YoNGWQZUdLif/KTqK0VHKw+0olmd ukoboF/qPlY2ujMIiZzG4anv0KbBRL7Srf6+nJah8gTqKExxV3VuDlPCG2UQRivEXNVV7+ KgJ0qHMqD/1HYu0PyQDoOr5jKkqlRZo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669621432; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kgj9cdmh7UcnsruKyfMUEk5vpuOw68Cdmm6DJfpECt0=; b=ZtrTI4rx8j/5YG6DbSCliTm2ve2Oi8qrGH0hlhgtzwx+EZ76HrbJsvllueVH/j1M4BIQVV sKqYaaa5aGPu77bvlShgYWYhefTThM3TUT5LKyKoCxRaNWQTtUYUo1V5Jb05o/iTS7vOem aUAeL9k4ezD5NfB7iH6QW6xiF+qQ/Ng= Authentication-Results: imf24.hostedemail.com; dkim=none; spf=pass (imf24.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com X-Rspam-User: X-Rspamd-Queue-Id: 5C6A118000E X-Rspamd-Server: rspam01 X-Stat-Signature: pw7yhru9fth9998irjmqj39h43mq4ty4 X-HE-Tag: 1669621432-777661 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 11/28/22 12:43, Alexander Gordeev wrote: > On Mon, Nov 28, 2022 at 12:01:06PM +0530, Anshuman Khandual wrote: >>>> diff --git a/include/linux/mm.h b/include/linux/mm.h >>>> index e9e387caffac..5ead9e997510 100644 >>>> --- a/include/linux/mm.h >>>> +++ b/include/linux/mm.h >>>> @@ -2403,7 +2403,7 @@ static inline void pgtable_pte_page_dtor(struct page *page) >>>> >>>> #if USE_SPLIT_PMD_PTLOCKS >>>> >>>> -static struct page *pmd_pgtable_page(pmd_t *pmd) >>>> +static inline struct page *pmd_pgtable_page(pmd_t *pmd) >>>> { >>>> unsigned long mask = ~(PTRS_PER_PMD * sizeof(pmd_t) - 1); >>>> return virt_to_page((void *)((unsigned long) pmd & mask)); >>> >>> This chunk does not appear to belong to this patch. >> >> Should not this helper be made a 'static inline' before using it else where ? > > Probably yes, but it is not kvm s390-specific change. Right, just that the s390 change here is the first instance where this helper is being used outside the header, hence kept them together. > > I guess, you wanted to make it together or as a follow-up to this one? > https://lore.kernel.org/all/20221124131641.1523772-1-anshuman.khandual@arm.com/ > Unless too much trouble, could we just keep it here as proposed.