From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B9CEC433EF for ; Fri, 29 Apr 2022 09:30:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9C5AF6B0074; Fri, 29 Apr 2022 05:30:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 974E96B0075; Fri, 29 Apr 2022 05:30:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8158D6B0078; Fri, 29 Apr 2022 05:30:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id 7262B6B0074 for ; Fri, 29 Apr 2022 05:30:43 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id 45A7C81801 for ; Fri, 29 Apr 2022 09:30:43 +0000 (UTC) X-FDA: 79409396766.06.B013E24 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf10.hostedemail.com (Postfix) with ESMTP id 17EE2C0068 for ; Fri, 29 Apr 2022 09:30:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1651224642; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jzfc0XR3HdzCO3e4oTB5rJCxt+7ycFW3KMJ+LBAdZdw=; b=OwOeJYU6z7BR9FVlq1sxx6wB4cjoMMxO3lW9jNd56EJ2A8ofFZmdgT+ZkwIrKqqUgRiDnU Mg1cx4gxYQ2niX2nREM/ST7awbjlIf3NrQXW+t4T1134yzcPinhVO32RJqdNaYLDQzy6RD d+TysZYTKTkKMbSHXgMMoRpLSykPlvA= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-461-VPnTuVm3OJK4YBoFgxwaVg-1; Fri, 29 Apr 2022 05:30:39 -0400 X-MC-Unique: VPnTuVm3OJK4YBoFgxwaVg-1 Received: by mail-wr1-f71.google.com with SMTP id k20-20020adfc714000000b001e305cd1597so2844674wrg.19 for ; Fri, 29 Apr 2022 02:30:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:organization:in-reply-to :content-transfer-encoding; bh=jzfc0XR3HdzCO3e4oTB5rJCxt+7ycFW3KMJ+LBAdZdw=; b=5fdf+kADHVi7Kxata7QXUl1ergE2eKyKU0J/wJ7cftPhlCcQhjNuKJyg10tK9b6y+6 riLQaE+U4poSPUUJxKGdHz8JPCPq7RbXhOOisL1OA8m3TEBYusafzCinEIZvAjRpgP7R jKMZcCMTtS9v9lQJXuqgYXA4GqMfDKgFStcXWgkRqdee9NktBcdn2Mfbh+8F58RP6I28 1DA8mT7Yyj7v0nd0OxQpNhheD0rxLct/DwYrFFDjLnsGi50fndvfNsjvgk2QCOlbOTie /IZjlPCQzFbok+/HmQk3yuYZsHLrxloeHntmvJbw7cUoeDJMiFoF3ecRXN4v5g9e9Iru Bwjg== X-Gm-Message-State: AOAM533FTfsqJs8IJJPcSrIvCI7rXCxMmiYMCSQYDo2f9x+U/dIZ0ChP PvFDOXhBpX6BQ47ZXcjoRCvV9u641+XmGGvCCYZozuclFy3GG71H2t6b6KYBXus5D64Vpvxf1QI mb/Hvro8Yuxo= X-Received: by 2002:a05:6000:15ce:b0:20c:4c7f:56cf with SMTP id y14-20020a05600015ce00b0020c4c7f56cfmr852238wry.536.1651224637960; Fri, 29 Apr 2022 02:30:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxlcacLFDn/yRxpghaRW3zVcqRWyeRTKqdDViQiVuFsJG7FG4KKoXl0lemFGmEAAvYif3fEZg== X-Received: by 2002:a05:6000:15ce:b0:20c:4c7f:56cf with SMTP id y14-20020a05600015ce00b0020c4c7f56cfmr852214wry.536.1651224637670; Fri, 29 Apr 2022 02:30:37 -0700 (PDT) Received: from ?IPV6:2003:cb:c707:fe00:bbeb:98e6:617a:dea1? (p200300cbc707fe00bbeb98e6617adea1.dip0.t-ipconnect.de. [2003:cb:c707:fe00:bbeb:98e6:617a:dea1]) by smtp.gmail.com with ESMTPSA id p6-20020a05600c358600b00393eaf94077sm2772472wmq.8.2022.04.29.02.30.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 29 Apr 2022 02:30:37 -0700 (PDT) Message-ID: <28b6c421-5050-2d6f-7188-bedfc7b31862@redhat.com> Date: Fri, 29 Apr 2022 11:30:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH v3 2/4] hugetlb: Fix hugepages_setup when deal with pernode To: Peng Liu , mike.kravetz@oracle.com, akpm@linux-foundation.org, yaozhenguo1@gmail.com, baolin.wang@linux.alibaba.com, songmuchun@bytedance.com, liuyuntao10@huawei.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20220413032915.251254-1-liupeng256@huawei.com> <20220413032915.251254-3-liupeng256@huawei.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220413032915.251254-3-liupeng256@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OwOeJYU6; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf10.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 17EE2C0068 X-Rspam-User: X-Stat-Signature: umowuc38yas6nazoo4qt4w63xzcwowmp X-HE-Tag: 1651224631-978888 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 13.04.22 05:29, Peng Liu wrote: > Hugepages can be specified to pernode since "hugetlbfs: extend > the definition of hugepages parameter to support node allocation", > but the following problem is observed. > > Confusing behavior is observed when both 1G and 2M hugepage is set > after "numa=off". > cmdline hugepage settings: > hugepagesz=1G hugepages=0:3,1:3 > hugepagesz=2M hugepages=0:1024,1:1024 > results: > HugeTLB registered 1.00 GiB page size, pre-allocated 0 pages > HugeTLB registered 2.00 MiB page size, pre-allocated 1024 pages > > Furthermore, confusing behavior can be also observed when an > invalid node behind a valid node. To fix this, never allocate any > typical hugepage when an invalid parameter is received. > > Fixes: b5389086ad7b ("hugetlbfs: extend the definition of hugepages parameter to support node allocation") > Signed-off-by: Peng Liu > --- > mm/hugetlb.c | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index 5b5a2a5a742f..1930b6341f7e 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -4116,6 +4116,20 @@ bool __init __weak hugetlb_node_alloc_supported(void) > { > return true; > } > + > +static void __init hugepages_clear_pages_in_node(void) I think the name is a bit imprecise, but I have no better suggestion right now. Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb