From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61A07C433F5 for ; Fri, 11 Mar 2022 16:57:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C4B688D0002; Fri, 11 Mar 2022 11:57:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BF9FD8D0001; Fri, 11 Mar 2022 11:57:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AE83F8D0002; Fri, 11 Mar 2022 11:57:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0252.hostedemail.com [216.40.44.252]) by kanga.kvack.org (Postfix) with ESMTP id 9B7608D0001 for ; Fri, 11 Mar 2022 11:57:53 -0500 (EST) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 424A0181CB17D for ; Fri, 11 Mar 2022 16:57:53 +0000 (UTC) X-FDA: 79232712426.25.B835F86 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf09.hostedemail.com (Postfix) with ESMTP id 82A5914001C for ; Fri, 11 Mar 2022 16:57:52 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 0EE921F37F; Fri, 11 Mar 2022 16:57:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1647017871; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IgYsa93xt0GY9NquD+Rifu92tu5q759OSHLEWka1V1c=; b=TAQ2zI2PEEPgL4weLoI8+rSAKd9ncxDYA80GxH7LiGLG3ppmFAxcisd/CDUFcyzAecXkDD tWyiBorYE8fJKwjvKvceGJ2ykToOgbJGYTOB66BqxqQwHclOcAIoouJAZAcyNRjwG/iXqn sc74fekLIRG3hVv83iND1rNbFIjXX20= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1647017871; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IgYsa93xt0GY9NquD+Rifu92tu5q759OSHLEWka1V1c=; b=7FyObfeCbchdfIZG8lS4jiAmsvDxu5WSuF1V/D7FuDpQNa4Ss8NuJPZV5+too1CH1nnP/Y mqh6P/EA1sV58MAA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C554013A95; Fri, 11 Mar 2022 16:57:50 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id J5ulLo5/K2KuNQAAMHmgww (envelope-from ); Fri, 11 Mar 2022 16:57:50 +0000 Message-ID: <28aa571b-6dba-feb0-b888-4d18c9b0ffa1@suse.cz> Date: Fri, 11 Mar 2022 17:57:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH] mm/page_alloc: check high-order pages for corruption during PCP operations Content-Language: en-US To: Mel Gorman , Andrew Morton Cc: Eric Dumazet , Eric Dumazet , linux-kernel , linux-mm , Michal Hocko , Shakeel Butt , Wei Xu , Greg Thelen , Hugh Dickins , David Rientjes References: <20220310092456.GJ15701@techsingularity.net> From: Vlastimil Babka In-Reply-To: <20220310092456.GJ15701@techsingularity.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: g3qhi4rp41nsfipyb973ubfki1tfaj6b Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=TAQ2zI2P; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=7FyObfeC; spf=pass (imf09.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 82A5914001C X-HE-Tag: 1647017872-273592 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/10/22 10:24, Mel Gorman wrote: > Eric Dumazet pointed out that commit 44042b449872 ("mm/page_alloc: allow > high-order pages to be stored on the per-cpu lists") only checks the head > page during PCP refill and allocation operations. This was an oversight > and all pages should be checked. This will incur a small performance > penalty but it's necessary for correctness. > > Fixes: 44042b449872 ("mm/page_alloc: allow high-order pages to be stored on the per-cpu lists") > Reported-by: Eric Dumazet > Signed-off-by: Mel Gorman > Acked-by: Eric Dumazet Acked-by: Vlastimil Babka