From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96FCDE7717D for ; Fri, 13 Dec 2024 08:41:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 199256B0088; Fri, 13 Dec 2024 03:41:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 149486B0089; Fri, 13 Dec 2024 03:41:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 03A186B008A; Fri, 13 Dec 2024 03:41:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id DA9046B0088 for ; Fri, 13 Dec 2024 03:41:57 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 88B21160C33 for ; Fri, 13 Dec 2024 08:41:57 +0000 (UTC) X-FDA: 82889292822.14.6ED1036 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf25.hostedemail.com (Postfix) with ESMTP id B9071A0004 for ; Fri, 13 Dec 2024 08:41:35 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hcFkDr34; spf=pass (imf25.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734079298; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LH059ZlZ7u2Dl3ILlcbpmd2S5dMJXw8i4IebMr3J1Q8=; b=rhKNTdxirkqr4uyzs3DkxZmtRyQ4fV1i7dYzg6GvpvzmWA4nqlPiTYc+tZVLV4ygKQrGEF uG9Z3UT+IQylIzMBzF116qxaxSMX7z5fNhUN5v1lYArpU125w+A25uzPcjRmx7vMK5+boB 8HJY2z7tVTQFYOURrBKQavQvWVBnPgQ= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hcFkDr34; spf=pass (imf25.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734079298; a=rsa-sha256; cv=none; b=LDsdHqyReSBQP9QvVyf5MlM7wlm3gie0ISDnhIll5HMGBKzgyefRh/sIpYBrcySy3atH5q U5B5X6AlOhNprbpd91L0dYtkM60avVZfY1vPdV5XvwbSfZ399HaRxk9z25bqdywDP4dIP3 +F647Tw/UIfQAA/oNb5MH+IprWbiliY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1734079313; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LH059ZlZ7u2Dl3ILlcbpmd2S5dMJXw8i4IebMr3J1Q8=; b=hcFkDr34snY+rgplYzFC/hs1bwkG5BTX71TC777Am2a7L52+OyHolQbzcYubRvBAiAY5Fo m5R4LICUgXWoo0GF7E2ZBlSkfAjOLDyLcYCD4Q95Xf2t1NdTsQlj5LcqFgmedCznazEsGT z+MhfB5jwu2Rj9E4bg7Jf+RXquy3Yus= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-463-FQ7YRkbrM-u50h34dheMEQ-1; Fri, 13 Dec 2024 03:41:49 -0500 X-MC-Unique: FQ7YRkbrM-u50h34dheMEQ-1 X-Mimecast-MFC-AGG-ID: FQ7YRkbrM-u50h34dheMEQ Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 53048195604F; Fri, 13 Dec 2024 08:41:47 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.48]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id B9D04195605A; Fri, 13 Dec 2024 08:41:43 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20241213072651.1475826-1-lizhi.xu@windriver.com> References: <20241213072651.1475826-1-lizhi.xu@windriver.com> <2133166.1733759584@warthog.procyon.org.uk> To: Lizhi Xu Cc: dhowells@redhat.com, asmadeus@codewreck.org, brauner@kernel.org, ericvh@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux_oss@crudebyte.com, lucho@ionkov.net, syzbot+1fc6f64c40a9d143cfb6@syzkaller.appspotmail.com, syzkaller-bugs@googlegroups.com, v9fs@lists.linux.dev Subject: Re: [PATCH] netfs: If didn't read new data then abandon retry MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2890360.1734079302.1@warthog.procyon.org.uk> Content-Transfer-Encoding: quoted-printable Date: Fri, 13 Dec 2024 08:41:42 +0000 Message-ID: <2890361.1734079302@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 X-Rspamd-Server: rspam05 X-Stat-Signature: hh61isqm8r3r7ghsexajrn9twzgoinx9 X-Rspamd-Queue-Id: B9071A0004 X-Rspam-User: X-HE-Tag: 1734079295-35809 X-HE-Meta: U2FsdGVkX18neQJqa+OI2bEiiLj9QTL/lglHJh2zKCx2ihEgQCBm5LEAMUcBPqPghxxRZ3z6txbOOl97IP81ZduJq0qmdTRt3a3B0yXk9V9N5zALnw4rmX1AV1N1fmIQIoCWZzkrQO1zy5r3t1Y9DD2h+oG41sICmmGfmNJKboHWHXisU/RYBklcJzOGXIoFs2+PwfMker/hBYH0sf8rx+XY2v2OZgm70Te3AkrZKG9tZmp9gZFOS5tfKKPiyC0YZaXl7+Hhb58Ian7shHC9KewygVsI0e+NtcOVMV/CHtIy93hS3sOKtXsFEInCfnUP2lK838ytf2zSJqaO31LNH0/zOVZMf32CY/xlqgxEfmBqc0nC78uAc5PCRB30FnO3cPc2o5A2Qm1ub56Co2ZlVNHjC7zswh46ePXo8ztG0e0DtFjlepoeEZa94rHjBH2i3Af0og0NABOK303SUm0KwHM12ilX9KUTxAhprq3zcuiOL6bpzXYhKlPoIBOysobaRbos+ZgQ1Am2XGnAgFfSxKL9YFdkYUG0tZs7eIVatEVW/1JnYq7ESNYd58+nLS84SZdliXJocACv1QtphxQ9R4rpXZ5+ORmALWgPVegqUZGgKPd8U7akHC+F6/MizhPX9nBtnAfiBp0BYHVynpID8YFYAkeN82dVehJbNAz+TRrJnQRKaG9IxqsFU3G8hGOiDqMgrNRf90GSE8dLIYGFctDILQxmamjnn8Bk0I4jY2l0qspHWOKqRmtDhlMPUdc+LRBXJkX+dWjQL93DvA1QD0bmp55Upki90PFyJPz+l7Lj6b5zIZnUetZglBQ8iFyaPCEi5iwj+Ehe4LkTMqflHp0hfmNtGYKLUY5f7qXFdI915paW9R8pzey1aOcfVqhJs9WB0eXdo9VX52JrOQpLa8T+KcQwR9opY0J9LX4aQjBZy0yjHXrhUIYsMaAfXYi2ymPuTBrOiCb0pQSk5QF EznVTP9n wu6Ao/wD/ytI4aEW4MdO6FfNZF+XVb+oSGQvPec5Imw/rElG1GP8tKXybg7xscz0Mj3M2bBEXQ6YhcP4yEMqn7lqGfOQyWYodve0ZYxen0DFbiTb66JykNnW2ivIexTAuq4MQpb5xa08bFGfHTvE6qfcgGpOeET3GFGshuoEOaRv5hKC6DbJIO8rfgrPcONSi4/xefyXL4+noldzkoKe87cLG96ndowVSLoMnzcyIllLzpex8zkVqN4/0NZtri6HnFYmQeP2eDwjoLo5h8dy8mTUpZxcJ/hyaWtnYoIUhkltBUhZ1/5bUsNt2QAAy8iJJERcEsdPNtzaMt0d06OaoyaGaOlOttk3bRqpBLawdgtdIlYHuc4ChJG6uIjjXNQNc3tw9VtAp9iU4j8qKgcKCVxHUVprKFEP/KZAXVoZHumAE6ZO25ANucUS7ypp+kiulzLfz5QYYsnU3Cw8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Lizhi Xu wrote: > > (1) Replace NETFS_SREQ_NO_PROGRESS with NETFS_SREQ_MADE_PROGRESS = and make > > the filesystem set it if it managed to read or write at least= one byte > > of data. Clear this bit before issuing a subrequest. > Will there be conflicts when reading and writing use the same flag to ma= rk? No, because, at the moment, a read done by a write (e.g. RMW with crypto) = or a write done by a read (e.g. writing just-read data to the cache) are handle= d with an additional request structure since the set regions involved may di= ffer (RMW only needs read the unmodified ends for example). David