From: "Wang, Wei W" <wei.w.wang@intel.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: "virtio-dev@lists.oasis-open.org"
<virtio-dev@lists.oasis-open.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"mhocko@kernel.org" <mhocko@kernel.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"torvalds@linux-foundation.org" <torvalds@linux-foundation.org>,
"pbonzini@redhat.com" <pbonzini@redhat.com>,
"liliang.opensource@gmail.com" <liliang.opensource@gmail.com>,
"yang.zhang.wz@gmail.com" <yang.zhang.wz@gmail.com>,
"quan.xu0@gmail.com" <quan.xu0@gmail.com>,
"nilal@redhat.com" <nilal@redhat.com>,
"riel@redhat.com" <riel@redhat.com>,
"peterx@redhat.com" <peterx@redhat.com>
Subject: RE: [PATCH v33 0/4] Virtio-balloon: support free page reporting
Date: Fri, 15 Jun 2018 14:28:49 +0000 [thread overview]
Message-ID: <286AC319A985734F985F78AFA26841F7396A3DC9@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <20180615142610-mutt-send-email-mst@kernel.org>
On Friday, June 15, 2018 7:30 PM, Michael S. Tsirkin wrote:
> On Fri, Jun 15, 2018 at 12:43:09PM +0800, Wei Wang wrote:
> > - remove the cmd id related interface. Now host can just send a free
> > page hint command to the guest (via the host_cmd config register)
> > to start the reporting.
>
> Here we go again. And what if reporting was already started previously?
> I don't think it's a good idea to tweak the host/guest interface yet again.
This interface is much simpler, and I'm not sure if that would be an issue here now, because
now the guest delivers the whole buffer of hints to host once, instead of hint by hint as before. And the guest notifies host after the buffer is delivered. In any case, the host doorbell handler will be invoked, if host doesn't need the hints at that time, it will just give back the buffer. There will be no stale hints remained in the ring now.
Best,
Wei
next prev parent reply other threads:[~2018-06-15 14:28 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-15 4:43 Wei Wang
2018-06-15 4:43 ` [PATCH v33 1/4] mm: add a function to get free page blocks Wei Wang
2018-06-15 23:08 ` Linus Torvalds
2018-06-16 1:19 ` Wang, Wei W
2018-06-26 1:55 ` Michael S. Tsirkin
2018-06-27 16:05 ` Linus Torvalds
2018-06-27 19:07 ` Michael S. Tsirkin
2018-06-28 8:39 ` Wei Wang
2018-06-16 4:50 ` Matthew Wilcox
2018-06-17 0:07 ` Wang, Wei W
2018-06-18 2:16 ` Michael S. Tsirkin
2018-06-15 4:43 ` [PATCH v33 2/4] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT Wei Wang
2018-06-15 11:42 ` Michael S. Tsirkin
2018-06-15 14:11 ` Wang, Wei W
2018-06-15 14:29 ` Michael S. Tsirkin
2018-06-16 1:09 ` Wang, Wei W
2018-06-18 2:28 ` Michael S. Tsirkin
2018-06-19 1:06 ` [virtio-dev] " Wang, Wei W
2018-06-19 3:05 ` Michael S. Tsirkin
2018-06-19 12:13 ` Wei Wang
2018-06-19 14:43 ` Michael S. Tsirkin
2018-06-20 9:11 ` Wang, Wei W
2018-06-20 14:14 ` Michael S. Tsirkin
2018-06-15 4:43 ` [PATCH v33 3/4] mm/page_poison: expose page_poisoning_enabled to kernel modules Wei Wang
2018-06-15 4:43 ` [PATCH v33 4/4] virtio-balloon: VIRTIO_BALLOON_F_PAGE_POISON Wei Wang
2018-06-15 11:29 ` [PATCH v33 0/4] Virtio-balloon: support free page reporting Michael S. Tsirkin
2018-06-15 14:28 ` Wang, Wei W [this message]
2018-06-15 14:38 ` Michael S. Tsirkin
2018-06-15 19:21 ` Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=286AC319A985734F985F78AFA26841F7396A3DC9@shsmsx102.ccr.corp.intel.com \
--to=wei.w.wang@intel.com \
--cc=akpm@linux-foundation.org \
--cc=kvm@vger.kernel.org \
--cc=liliang.opensource@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mst@redhat.com \
--cc=nilal@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=quan.xu0@gmail.com \
--cc=riel@redhat.com \
--cc=torvalds@linux-foundation.org \
--cc=virtio-dev@lists.oasis-open.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=yang.zhang.wz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox