From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00594C001DB for ; Tue, 15 Aug 2023 12:51:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2C9A9940018; Tue, 15 Aug 2023 08:51:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 279538D0001; Tue, 15 Aug 2023 08:51:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 168BC940018; Tue, 15 Aug 2023 08:51:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 039088D0001 for ; Tue, 15 Aug 2023 08:51:38 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id C8623A095A for ; Tue, 15 Aug 2023 12:51:37 +0000 (UTC) X-FDA: 81126325434.21.FC223CF Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf17.hostedemail.com (Postfix) with ESMTP id AF83940018 for ; Tue, 15 Aug 2023 12:51:35 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cmqw8WjI; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf17.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692103895; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6h9aonqmeDneHn2sCJ+4YLuPQmV9DjwIRMJXM+2v704=; b=LnWCFxzbISaZwl+vn/OoQL/44SEsh/MNS03U8iaCCDdN1SHOR3720FkhJM+V41JdeF0i4M UBbLe0qo7DzUe4JEegXYd1/CVgI1UXDtE3CPwFotPcY0kb+yKyO4svDK4YanPHeHM1dtn6 Eq+INuPOuFOltclU+tCJcaoXPjgRA5o= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cmqw8WjI; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf17.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692103895; a=rsa-sha256; cv=none; b=CBYEgRuhSp12LZXcCDak1w9Mq0SXqFZrIqNWyjupI8RES2D/OTgFp3hk2/lDA4KcH6japu HvTBXBzLgLIIJMmRdKgIIv6hTJD41ZyAXaciLEQYWYaczamHFvRxZGx/Ag6uNMk9vERaV3 rWKVZbqo2S3JuwYHV8MwGgC9qITanLE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1692103895; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6h9aonqmeDneHn2sCJ+4YLuPQmV9DjwIRMJXM+2v704=; b=cmqw8WjIcpwQiGvZEiz9gPnJEs3CGV8f/kFRawouOvQJ835l77i6SnNgdtUVZLXqEUM0EW zwMfW4aiASn+gIjagCR887YVTk62TfrrHBGmO21Qmq7u1MnexyCwBFIihNokrPD9efmg4o 8/jp8W4H2AzmsMgGsJsARoZS+NBwFMw= Received: from mimecast-mx02.redhat.com (66.187.233.73 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-595-qBAZoA6cNmWTtYvAFtxRoA-1; Tue, 15 Aug 2023 08:51:32 -0400 X-MC-Unique: qBAZoA6cNmWTtYvAFtxRoA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 576E33C108C9; Tue, 15 Aug 2023 12:51:31 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.13]) by smtp.corp.redhat.com (Postfix) with ESMTP id C3E4B140E917; Tue, 15 Aug 2023 12:51:29 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <3710261.1691764329@warthog.procyon.org.uk> To: David Laight Cc: dhowells@redhat.com, Alexander Viro , Jens Axboe , Christoph Hellwig , Christian Brauner , Matthew Wilcox , Linus Torvalds , "jlayton@kernel.org" , "linux-block@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" Subject: Re: [RFC PATCH] iov_iter: Convert iterate*() to inline funcs MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <286906.1692103889.1@warthog.procyon.org.uk> Date: Tue, 15 Aug 2023 13:51:29 +0100 Message-ID: <286907.1692103889@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Rspamd-Queue-Id: AF83940018 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: r36pzy3dei4hegdqh9auc5gqgrmab1bn X-HE-Tag: 1692103895-762907 X-HE-Meta: U2FsdGVkX1+vHTn7PKgxUR1zd5YB+HxNFZwxIPx+YY08Np+E0b88heoCbwuSTezv/LJkf2PE3m7SHgNshTPwF+qrvUW6d5/vfD5IfrqGKZKlP+7dHWq/W/2N6yDe7JkbtNIACfIiXYm50ghITxNzyniozu3y4/xIvDvJuqsUJ7Uv4kOooVAlWzE1Elm1H8HybjftnXRjTi+LeD3hZH/kl13h7CoeXtB1HFU3OjMIi4dWHKU5l/lvjgD3YWRol9kixa4XZFSE7l8/gJ/shwfSRY4373P9S5cQfUXK4Zh/hfifgJAjZyG6m3Mek6MTexzUaDEo/CatSTRMsrSf8WN9ZJD/C+AnJ2TmYDsppz8zEh6oKIoXujGx0jS3hdtKqnLO4KqP0aNa2ZnTLzNP7/Vmo4nwmh7rYtqn0iRn7dnCYsqZLALOos+/tFNQpa4bt74tGV2hCJCqAgFY1r5kFnH88iUnQoSZGCmUBOL+dHXUtY5q6qLyKICLQcb7lNAfSoD6CMO+bA3yeUCFR0nEKHErFJtIzchazi1Yv1C/F1qi5XSBtK5yNVoF1AAC+eX9xfcwXWd4lXHmlxQRy2+p7eQyVjbBriO049FRubRIo7wYNvV+DkSF3/3oRrI2s7xy8nCpJaKb3Hwcd5Kj47gCjyiY+i7p92PWiAYZAL/DknuHD+zo3rBES06H76nP/e0uJXH0tO5NRaitmWgcKaVSedjPGNfQUM34zkGggYxkSE7fwf+Hp8Z5xPSilgx8OfNVYEBdnx4si6DxJ4XZVEzti3uLRtm/9hvQPCu13jaj9mYs6oB5WSg+ppcJ6qgxcI3bUMRcHvcFm6/xGV3Rg9x/1622ydmD8qKiKB4k4vKfCAr23aYkDzbe1a2ha6owznQmepgToJ94kYByUY/wp1XN283wQX/PwDM5szy6I1HmUkRsoyTvKNAkSd4juSKr2ie1oCmmgtLHWu3N/1sFxj55gO/ 5eiiDza2 toMppt4Y1gimFC7FRMNLN3L9YSPVsz1xq+aFJNw1977uEYDUFay+yl3uzgG7P+ke4oc6AQEZj1Y23cktWN86g7sL0wU7IRnWR2oyfzrQPseAmrBXP3SQRoOxkvZAt5OwfGLstnnNikleZC1X41n5RrVA3zm1cHDxS9MvI5tX037blB/QuT4/qmR7WkRMJ3FOm5ijS47JaYWMgRznUe2JQRUq5IrmWNDzvHLyHgGEaOxXFElzJmxNlCkKCRTUIwZksUdNzlUc9thTPT39BBwkgxg1dz9EAIEb1g8w4OVyzlvmJkmk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: David Laight wrote: > Actually quite typical because inlining happens much later on. > I suspect that the #define benefits from the compile front-end > optimising constants. I managed to mostly pull it back, and even make some functions slightly smaller, in the v2 I posted. Mostly that came about by arranging things to look a bit more like the upstream macro version. David