From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8C2BC32771 for ; Fri, 19 Aug 2022 11:14:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6FD568D0003; Fri, 19 Aug 2022 07:14:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 692248D0002; Fri, 19 Aug 2022 07:14:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5260A8D0003; Fri, 19 Aug 2022 07:14:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 408D78D0002 for ; Fri, 19 Aug 2022 07:14:09 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 0E9EE120B55 for ; Fri, 19 Aug 2022 11:14:09 +0000 (UTC) X-FDA: 79816083018.24.E02720F Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) by imf29.hostedemail.com (Postfix) with ESMTP id AB70A120150 for ; Fri, 19 Aug 2022 11:14:08 +0000 (UTC) Received: by mail-ed1-f43.google.com with SMTP id t5so5235673edc.11 for ; Fri, 19 Aug 2022 04:14:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=Sx9SlBHLsTj9fAFHZm02u/sabG6vSGKEbbaKRYbRUOU=; b=cTV7O7ZHNMJTb7hLnpCD4W9Poa3CmWMNi4C7SPsigI9hU9bs/MFfv0Z5uDFDJArXQ/ pEV+PfjemhSdL7kT9JTo0NJ3oPF+zcwzHWDfbwPKyh+cJKsH4KDU19cfIM0JILFiPUQB eQPWlJs3/j4C3gYMBdR+A80Brxejb+xBsQ+eC+TDje4M1Z0u7VogYJggAX8l56c/Oym5 hTECKO2kMZROIPCsbe+auJjPYAnHQbFRNMr5g2mlm4HS7ZwPnAG/dasNXNIwEdKMdE2G sohJtpySMRo6hwaPSchb/XIu28XU5iBx/eZdii/STBUJ+M72hyIrSaXiWmJ6OiCgJ+EH 4c2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=Sx9SlBHLsTj9fAFHZm02u/sabG6vSGKEbbaKRYbRUOU=; b=3uC7BZpraO40svUFICoFJ7fjUne/OskxifPQDfakAbPOJN6OoWO2upraG0TT819bTs 1NDtTxCDYiUGWaTnCdPDhuNrOcIdqSpWlRGQFgsh6MRwzRLeyepD5c67GVjilOTGZnHK 6jqpeVIiU3EzKd8cMEk8OdQKA5GY3QAnR5FaxPpyj6wenLi1DTMLCL/oxoPRNnTPHa6Q WNMy6MT+MUV11QQdU90NVu3CeZSuERTzalSjxk0x6Z9RQGm2ClVct6OmvO2kVBRnc+1k HYScI2f6myNZrLWVelE2rNOtHFlV+ZAtV/SaIGcil0S3TcjEyNRKoAyuPQtLn/Wdg2/W 0xmw== X-Gm-Message-State: ACgBeo1m+sdb5fXl7M7j68A20LDojYNwLhu4d3UMKm+bLaLHfvIUGuoQ /O3m4l5hVOs5BmFUNQoa2Of9LF2OEPw= X-Google-Smtp-Source: AA6agR4HpdgdiIUl9gdT4zG5+8q1hRLBTcDOpV7nt8ZB4ggvCfMmB7T/76+O/wkJiuC7HwWKK/1oHQ== X-Received: by 2002:a05:6402:35c:b0:43c:8f51:130 with SMTP id r28-20020a056402035c00b0043c8f510130mr5637575edw.393.1660907647505; Fri, 19 Aug 2022 04:14:07 -0700 (PDT) Received: from localhost.localdomain (host-87-17-106-94.retail.telecomitalia.it. [87.17.106.94]) by smtp.gmail.com with ESMTPSA id k8-20020a17090632c800b0073cd7cc2c81sm1010753ejk.181.2022.08.19.04.14.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Aug 2022 04:14:06 -0700 (PDT) From: "Fabio M. De Francesco" To: linux-fscrypt@vger.kernel.org, Eric Biggers Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] fs-verity: use kmap_local_page() instead of kmap() Date: Fri, 19 Aug 2022 13:14:03 +0200 Message-ID: <2851124.e9J7NaK4W3@localhost.localdomain> In-Reply-To: <20220818224010.43778-1-ebiggers@kernel.org> References: <20220818224010.43778-1-ebiggers@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660907648; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Sx9SlBHLsTj9fAFHZm02u/sabG6vSGKEbbaKRYbRUOU=; b=7jcKXY6vXxQH0vuk+hjlnemqAOGs75kcqcEj3STx2t8/TXVIEWNrCykQNlmQh0TUgp5Wb7 6GI7DdbhYmETZcsSFyFo0njjXI1+gRtSfk0DPH0M9rjHy0fDkzBOga9k7EJfFzmNzZgMFO 6oT6GrE0IhQZ/r7xEk10SaJ8nYPmwRQ= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=cTV7O7ZH; spf=pass (imf29.hostedemail.com: domain of fmdefrancesco@gmail.com designates 209.85.208.43 as permitted sender) smtp.mailfrom=fmdefrancesco@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660907648; a=rsa-sha256; cv=none; b=IQaZRyy6in75rbONKzaLh49j5rrkL6+CPifnLkmzkzKVrP4VwXpIQfyxAaYJWnVVvdjwre /h5Wx4UBcAjFmBFVZqX9UCa9cR3EXFCC1Ev0Hhd0yTbDC90he9dgb9d12//XlCJ3sxi3BK 28Nqx5TKXDdgtoBROEhtkUMHcHIzfm0= X-Rspam-User: Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=cTV7O7ZH; spf=pass (imf29.hostedemail.com: domain of fmdefrancesco@gmail.com designates 209.85.208.43 as permitted sender) smtp.mailfrom=fmdefrancesco@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Stat-Signature: xqbsmqu45gusgz7nnywe8ixhux5qwutg X-Rspamd-Queue-Id: AB70A120150 X-Rspamd-Server: rspam05 X-HE-Tag: 1660907648-947378 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Friday, August 19, 2022 12:40:10 AM CEST Eric Biggers wrote: > From: Eric Biggers > > Convert the use of kmap() to its recommended replacement > kmap_local_page(). This avoids the overhead of doing a non-local > mapping, which is unnecessary in this case. > > Signed-off-by: Eric Biggers > --- > fs/verity/read_metadata.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > It looks good to me... Reviewed-by: Fabio M. De Francesco Thanks, Fabio > diff --git a/fs/verity/read_metadata.c b/fs/verity/read_metadata.c > index 6ee849dc7bc183..2aefc5565152ad 100644 > --- a/fs/verity/read_metadata.c > +++ b/fs/verity/read_metadata.c > @@ -53,14 +53,14 @@ static int fsverity_read_merkle_tree(struct inode *inode, > break; > } > > - virt = kmap(page); > + virt = kmap_local_page(page); > if (copy_to_user(buf, virt + offs_in_page, bytes_to_copy)) { > - kunmap(page); > + kunmap_local(virt); > put_page(page); > err = -EFAULT; > break; > } > - kunmap(page); > + kunmap_local(virt); > put_page(page); > > retval += bytes_to_copy; > > base-commit: 568035b01cfb107af8d2e4bd2fb9aea22cf5b868 > prerequisite-patch-id: 188e114bdf3546eb18e7984b70be8a7c773acec3 > -- > 2.37.1 > >