From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2763AC4345F for ; Wed, 17 Apr 2024 09:03:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9F5C76B0089; Wed, 17 Apr 2024 05:03:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 97EDC6B008A; Wed, 17 Apr 2024 05:03:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7F91F6B008C; Wed, 17 Apr 2024 05:03:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 61B7B6B0089 for ; Wed, 17 Apr 2024 05:03:09 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id E7AACA12A6 for ; Wed, 17 Apr 2024 09:03:08 +0000 (UTC) X-FDA: 82018434456.02.AD879BD Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf04.hostedemail.com (Postfix) with ESMTP id F060E4000C for ; Wed, 17 Apr 2024 09:03:06 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="d/f0SHMZ"; spf=pass (imf04.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713344587; a=rsa-sha256; cv=none; b=RkzDD4UVYlSuWBuBQI8cBUSbbbzxiKvaBBGyQmadgHXeo6pC0/m0nP+KVlGlOkMAZNR7pW Idmse0TYtFkkANsJzMtnrG8WODgKGx0pPik5gH5NJxOfXrEIJnARa+/1U9m1AkJbDtRS4o krRrUxl1tE8gI/XUAmtPQ64urA6RZvI= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="d/f0SHMZ"; spf=pass (imf04.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713344587; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+cqHolZFVcFPpeLBdV05ZqicpNbJqZRKW17Kvjt/Abs=; b=YpWTcOEuOq0S2lpl9gVoA3OrGGnd6nVXxhXCxceqdsiUPaVYhzqcyx1d5wwsymyOIlbcyg TBtXEICFkZvt9PVqhboEBTnWmDYZyn/jPnOLKZeXTTjVw9L3zDRRU9lFCUdZ4YpzU0B4iU Ro24GhWmhEdRa/4KyWmcvy8dOpE8YQw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713344586; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+cqHolZFVcFPpeLBdV05ZqicpNbJqZRKW17Kvjt/Abs=; b=d/f0SHMZN64k9uuHgJ/2oBnlsNJIrr7j+CE683Ft8JTfXTXXiYdTxg6g4T1EqDKFAIVPsj fpfUsQuB6aNeLfqPKGT+40Hnos7kvtUelc1G/u4CFInKFXT11d1+94T2KPc8KRkf7njsTt bPGRgqG5ZOWqWhvWAZ0nTrC9O7y+GJo= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-455-UAKkPT0cNTu8x3FwjUWu1g-1; Wed, 17 Apr 2024 05:03:00 -0400 X-MC-Unique: UAKkPT0cNTu8x3FwjUWu1g-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D56BA10499A0; Wed, 17 Apr 2024 09:02:58 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.200]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6F32BC13FA2; Wed, 17 Apr 2024 09:02:53 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <3570373a3db66151033a3667cb8c28bbf8bc505b.camel@kernel.org> References: <3570373a3db66151033a3667cb8c28bbf8bc505b.camel@kernel.org> <20240328163424.2781320-1-dhowells@redhat.com> <20240328163424.2781320-10-dhowells@redhat.com> To: Jeff Layton Cc: David Howells , Christian Brauner , Gao Xiang , Dominique Martinet , Matthew Wilcox , Steve French , Marc Dionne , Paulo Alcantara , Shyam Prasad N , Tom Talpey , Eric Van Hensbergen , Ilya Dryomov , netfs@lists.linux.dev, linux-cachefs@redhat.com, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Miklos Szeredi , Trond Myklebust , Christoph Hellwig , Andrew Morton , Alexander Viro , Christian Brauner , devel@lists.orangefs.org Subject: Re: [PATCH 09/26] mm: Provide a means of invalidation without using launder_folio MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <28262.1713344568.1@warthog.procyon.org.uk> Date: Wed, 17 Apr 2024 10:02:48 +0100 Message-ID: <28263.1713344568@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.8 X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: F060E4000C X-Stat-Signature: 9yg39fzeo1tofiweh89gfsmgeojeousw X-Rspam-User: X-HE-Tag: 1713344586-427537 X-HE-Meta: U2FsdGVkX184rgUfSn1l5iHiyAo2E1GPnyAi1P9FZCE/7mgPyqd6bULIhaaiK0yueCxk60En+jt7zfaafInKAMFp3rzybjAMnCatAAZCTJJY/MZfjxRmyDbNRliK8zRzbXNozDcfeoBunokgvmFDGZveO5Yk4Hcqypz7rwNlq71fZ3SMnTmbDqxHQ9Nt9Z8rlhjRU8xFKZgP9xKSviX/av56OUQjMdUa1QEwqEzBfgJjTDxWFWNZJUUN9494Q37hGQfnPYfxgVwf1Kg9VTEOPXaXaVLzDcv19WllSf5nHdtDImw9ez0E4C/FnObH1VSHLHgs+MWUDeI6d4i4ihm3iwPTBwMpl9ivny3EOZY8IYz10kERw4EfIrDi983gCtD37EShFvaeT0EdxJaJ8h/8jHfeXaT+ETvVu6i3mMGmEl/rfGRZmHh8NOZUyx/Qah/kM/kpVZYYYkoqhxiOXZsvZtLu08hd/LLNBqxMnxpeadVNPTLz7bOVGuin9CUSMDIaTq0CqLTEnRRb5rth1DzeSferMq2qnEijg1Ybdg03029saFOX8WDZRtV8Qkw1YbGasKIcWlTMamW+PQqVilPkfVA6Cs4WVznf14fFhswMM1QG10GdNXmIULSnrC8Gwv1UgImys7HE+JtAKRelXtN9sDdJ2RgoPElE2SfmMqefF/2/QpdPxdb0DSYXGdAhrLIOdvL/wRRQNuQKfSLaGNhktDYqw8W+CjcbpWEX2m2mhI6DqbussbYcjMxVtJmd7UZoPUK6MwvcbMwpU2PIeqyPYwUdshxMdgCa1/A507zeCQA7aVKsXrGrlvZhdjyzTRrmtNqj2NuqbNWHCitWrIhBRuO6lZRaLoaS9gEXMsrsPFABUzcGGZ+apzmpXCxojOd2OWY7bx1VPJLRG9adSC0S/gBupAzcLEY2WorduDtrH/tyvHrPZf9A7jJAon5HGeQ8EgINAEQpzWHPa1oo4IR wrn/9nEE CbNdr2dSIeW2ohrBCtYKT3VMFYLwTBs9lrDHn89NRg7zvk2Dyz4vdUy0hJzq7/bSIT+FeozIRqkh5Gr83GCIy2QVtf1UgyYV0re2lM9MwExiI0QV+DQeCzSkubSAXrrWMkojD/7/eJKF3PzQf83AiHMTqaACNeR28ptFx4tAafAprUC4oWIjaV/paAtKvTdBonjRlCKDEwDOW9ZgR4IrkYyJ0dCgJMOz/w4KbKKWmPH3SUhAwutDOzXFQT9lQLQBuc9FSrcIIgGZndoU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Jeff Layton wrote: > I'd have liked to have seen the first caller of this function too. Looking again at my code, I also need to make netfs_unbuffered_write_iter() use this function too. I missed it before because that wasn't calling invalidate_inode_pages2_range() directly, but rather going through kiocb_invalidate_pages(). So I'll add those changes into this patch to give you a first caller. I also then need to make filemap_invalidate_inode() take a byte range. David