From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F24DC7EE23 for ; Mon, 12 Jun 2023 07:46:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 941016B0075; Mon, 12 Jun 2023 03:46:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8F1DD6B0078; Mon, 12 Jun 2023 03:46:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7BA6C6B007B; Mon, 12 Jun 2023 03:46:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 692A26B0075 for ; Mon, 12 Jun 2023 03:46:30 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 3190EC0144 for ; Mon, 12 Jun 2023 07:46:30 +0000 (UTC) X-FDA: 80893313340.07.2CD5517 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf07.hostedemail.com (Postfix) with ESMTP id BBF9240015 for ; Mon, 12 Jun 2023 07:46:27 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MjisV+ei; spf=pass (imf07.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686555987; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yP4vMHkO+yCSQ+z82iPRDsudDDu4cQh6jmBlyoee49w=; b=IiPFwkrSgBaL6QpI0eY4gYLgNwhh964C/Jli09WHMsDA0uB+ue7sN436w2MLEyZMcIUO/X sgUYe0VZCdixUuB5qtCIpiYon74MfGGY+5xtKwl+SQSA/f8BLklm6ApRva/+jFEEA0fuXQ 17yENQd80Z6j+hjBXeuYt0AqoCMUsrM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686555987; a=rsa-sha256; cv=none; b=dbapqnymDDxdzdyumH1HInd4BGZ+gBxNt+GOiYb7BE0bYqjB02VOGLUjfI4ic3SBuzcOeg V02AJ1+uvalzISXfgShaLvQcZYQBH8DO28Gln46XjFAevzZTq3Y3p48HPom71Lts8+mFij TySSqJ22H3DttaD6uDV4nZj6gV+4QJ0= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MjisV+ei; spf=pass (imf07.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686555987; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yP4vMHkO+yCSQ+z82iPRDsudDDu4cQh6jmBlyoee49w=; b=MjisV+eiM7lhIJAbrwALYToMgji3BkE1ezY4OUE0dYSiVHzuxUtKlhzfx3MxYqKtAsEBeP TCXrWCl14r1XSDeh8y+ktg7ZNRp8Yw23PaJCKcXCinwPkqhZUYtEhk/ANxYXO/lgFA4Tvp 4/zQdD1Ky9i3YU8cU7uJSA5b0Ky7ORU= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-283-K7T15TTaMGypu2a9Nboz_w-1; Mon, 12 Jun 2023 03:46:25 -0400 X-MC-Unique: K7T15TTaMGypu2a9Nboz_w-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-30fc5d6e697so130393f8f.0 for ; Mon, 12 Jun 2023 00:46:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686555984; x=1689147984; h=content-transfer-encoding:in-reply-to:subject:organization:from :references:cc:to:content-language:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=yP4vMHkO+yCSQ+z82iPRDsudDDu4cQh6jmBlyoee49w=; b=MCadjC+b4//LxwukH72loplfHD4WymSRc30uIJFwzPKNyTGETC0RN/6qigchQ/qdyV SvQv2xq6ag9EV8DciP6mJdnVVcuetdDnN4BY/bntQpOVFwyg0jAEQ3V5D3Dsk2z4fTwV 7QkA2pPYZQIsG010oxNrXL9Uq5lQUB8zQ/XJeia7cpYpkoOQr+p+ZKdBgvykoGZutzSV rIuU4kfWDHOPQgLYBTEomdHHQqI2EL3Ys/bg6DPRQj7goFMUO7QfCe96ntpx4E6CnJQv aqzM9mWtf8Z48Ngbit2j+hVQKQkFLFRrwItBghNp/9hZJm2RIRJKvcCe+1YVn0brcBrG MnLw== X-Gm-Message-State: AC+VfDyJPpgru6uX34wVAci4L/wBq2u/MFuRW/kdOCHemQE4+9pG5SU4 IuhAulpqflQlfnAlRoSqHqrh8gj0v/LdCAmXLDTPcmbSAdFAbQjREW68jUuLu5+SQGEKuEJYktN hEnBksRJFJvI= X-Received: by 2002:a05:6000:14c:b0:30f:a895:d991 with SMTP id r12-20020a056000014c00b0030fa895d991mr3131816wrx.55.1686555984697; Mon, 12 Jun 2023 00:46:24 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ73G0tqHUKMiC3veRGtl5w/v7h2Kk9F4KUkzVL4unSRQmLHkul9W56Mg29yppbvMAA2E73L5A== X-Received: by 2002:a05:6000:14c:b0:30f:a895:d991 with SMTP id r12-20020a056000014c00b0030fa895d991mr3131789wrx.55.1686555984277; Mon, 12 Jun 2023 00:46:24 -0700 (PDT) Received: from ?IPV6:2003:cb:c74e:1600:4f67:25b2:3e8c:2a4e? (p200300cbc74e16004f6725b23e8c2a4e.dip0.t-ipconnect.de. [2003:cb:c74e:1600:4f67:25b2:3e8c:2a4e]) by smtp.gmail.com with ESMTPSA id b5-20020adff905000000b0030aedb8156esm11491237wrr.102.2023.06.12.00.46.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Jun 2023 00:46:23 -0700 (PDT) Message-ID: <281caf4f-25da-3a73-554b-4fb252963035@redhat.com> Date: Mon, 12 Jun 2023 09:46:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 To: "Kasireddy, Vivek" , Mike Kravetz , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "dri-devel@lists.freedesktop.org" , "qemu-devel@nongnu.org" , Hugh Dickins Cc: Gerd Hoffmann , "Kim, Dongwon" , "Chang, Junxiao" , "kirill.shutemov@linux.intel.com" , "Hocko, Michal" , "jmarchan@redhat.com" , "muchun.song@linux.dev" , James Houghton , Greg Kroah-Hartman , Andrew Morton , "stable@vger.kernel.org" References: <20230608204927.88711-1-mike.kravetz@oracle.com> From: David Hildenbrand Organization: Red Hat Subject: Re: [PATCH] udmabuf: revert 'Add support for mapping hugepages (v4)' In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: cbcyeifbeuwzhqpozxam5ag61wd4rjb8 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: BBF9240015 X-Rspam-User: X-HE-Tag: 1686555987-132126 X-HE-Meta: U2FsdGVkX1/mkf2hZDjtCPa4mhdTHqyCYbuewMcOY62v0IeNAi6zzfF5iquEArNFFof1x5RRQgxa92jq8PhOsEltmZi13J7hdHjlY8Ipa3iAPYpWMrt6AL5zouawrCcVoDnnObVjWhJoo5KrXPjBLBlLjWTIq5kDSGbuZpr4OsS9ibHPRAlOvYwkvS6uDCaNNgJ6ntVAG6mq6qwymCd1qpDWIP/sB3RWJCcYs+/MV+qxxKwm9eZ9RIaeFnKmKoinuEJbcGGbLfzxbwD7X2fvxZrva8lSKPR5mr5lOVCRShlXgVBUSsrrMx4Tr07Rzp5kQO4u8LJultJ2ou5J1+xvL9gKWep2P/y7/Td64MlIVXrAW99I6GVENHEnXTm3lkg8qVEKFmClgQMWaXgKXXc2qzEmnoW7tHvtgFC/xAC8AaCcIq+dlwqjxcR15uyiXR4Fuw7Aq7SQWvwRuRVhYuG+GNmOE6a69etJqmMJSe54P4MRv6Z6ErzC6fIPbcLWn0a7zU42F/kneZb01bMexiLvscTbgE3vS98Nu+DB94g3rztDSmYnaxyFwOqDWvWX0F6JoK8QgooBSwHc6f6jqNPKcr3rKMF+ZCCNfjQoX3V1IX12RzURK+fAvI6jSwwluSMOZhBDWWMFVATbFA8V6r3f12QjUs5/rZSqBYNV7RB6mssgOwLRhHSirV3E4j7ciDaD1IspL4vkXkmnNO4vZyAzU18yxibvQp9BxrmB8AuQ/GpTSNh6SS2KHDiZzWeCeDsZcFoZj6v04pCCuN0/ZBwCvhXSyUc+xxrVk9n1doVG3xbVv0MRTNaXJoiIaoTjDeHT1zycwozbzIwzxnifbOw42jmJq9T0/BkRHooIqxANmiXCXYGXJ2XlJkpU889ssR0911+V0AcjZcXztJbfCje0wHIDgnu3AIPW4NZfdAQ3l9psn2mfYGoJ4ERE+xc7Ed03y0G2yMDo+qvmHTBIMGd 5zo5EcdI TPVLo9dbQItGGJet1w9rrRaoyOvTo7IrrzXHhGSObH5UvUxxzYv2r5kH5pZstqQta7Rmf7m4KwAeJm5VuYw860yVrC2l5h9mU9bFo4lwLImsbCAvge/Tk1nLiU/Z91QpNZ7ujgRM0M5mKq5l3Inv/16CToE2AcuhrY57Hxbt1Z41ikuszxfTv6mcDfPPDk7m2+SuHFg1pP6/RpL5X+t5KAbJLuC6nyLmOsE7kKwxCEdd1SASzuKuIs8tYIk5DMZxG3h4Ma0baz0vmdHAJI/U26/bOEPFqM5ot1XnVecZCLWglygvmCe6Pi4+KHih45d2BxkEn0w98BXVrSq9s5VzDmNt6Yz9pKB02jWQ2wF6u5NJ9PpiS1yeZ1JuBHb04JLR01XO/GWogoYtfFkJw6am8xc7LQgxAdVIGL4X8/eCO+E3nnbIh+p4ZIYyI0xjIs++zGjr3 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 12.06.23 09:10, Kasireddy, Vivek wrote: > Hi Mike, Hi Vivek, > > Sorry for the late reply; I just got back from vacation. > If it is unsafe to directly use the subpages of a hugetlb page, then reverting > this patch seems like the only option for addressing this issue immediately. > So, this patch is > Acked-by: Vivek Kasireddy > > As far as the use-case is concerned, there are two main users of the udmabuf > driver: Qemu and CrosVM VMMs. However, it appears Qemu is the only one > that uses hugetlb pages (when hugetlb=on is set) as the backing store for > Guest (Linux, Android and Windows) system memory. The main goal is to > share the pages associated with the Guest allocated framebuffer (FB) with > the Host GPU driver and other components in a zero-copy way. To that end, > the guest GPU driver (virtio-gpu) allocates 4k size pages (associated with > the FB) and pins them before sharing the (guest) physical (or dma) addresses > (and lengths) with Qemu. Qemu then translates the addresses into file > offsets and shares these offsets with udmabuf. Is my understanding correct, that we can effectively long-term pin (worse than mlock) 64 MiB per UDMABUF_CREATE, allowing eventually !root users ll /dev/udmabuf crw-rw---- 1 root kvm 10, 125 12. Jun 08:12 /dev/udmabuf to bypass there effective MEMLOCK limit, fragmenting physical memory and breaking swap? Regarding the udmabuf_vm_fault(), I assume we're mapping pages we obtained from the memfd ourselves into a special VMA (mmap() of the udmabuf). I'm not sure how well shmem pages are prepared for getting mapped by someone else into an arbitrary VMA (page->index?). ... also, just imagine someone doing FALLOC_FL_PUNCH_HOLE / ftruncate() on the memfd. What's mapped into the memfd no longer corresponds to what's pinned / mapped into the VMA. Was linux-mm (and especially shmem maintainers, ccing Hugh) involved in the upstreaming of udmabuf? -- Cheers, David / dhildenb