linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "Jiaxun Yang" <jiaxun.yang@flygoat.com>
To: "Yu Zhao" <yuzhao@google.com>
Cc: "linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>,
	Linux-MM <linux-mm@kvack.org>
Subject: Re: MCEs on MIPS: multiple matching TLB entries
Date: Wed, 03 Jul 2024 13:13:23 +0800	[thread overview]
Message-ID: <2815c608-a921-476a-92c1-c4d648f95a3c@app.fastmail.com> (raw)
In-Reply-To: <CAOUHufbR6sFguZ0r6NvGRH1mO542BkLaE7vzdFq2LArMNj9qfg@mail.gmail.com>



在2024年7月1日七月 上午2:23,Yu Zhao写道:
> On Sun, Jun 30, 2024 at 11:25 AM Jiaxun Yang <jiaxun.yang@flygoat.com> wrote:
>>
>>
>>
>> 在2024年6月30日六月 上午4:01,Jiaxun Yang写道:
>> > 在2024年6月30日六月 上午3:22,Jiaxun Yang写道:
>> >> 在2024年6月28日六月 下午6:57,Yu Zhao写道:
>> >>> Hi,
>> >>>
>> >>> OpenWrt folks ran into MCEs caused by multiple matching TLB entries
>> >>> [1], after they updated their kernel from v6.1 to v6.6.
>> >>>
>> >>> I reported similar crashes previously [2], on v6.4. So they asked me
>> >>> whether I'm aware of a fix from the mainline, which I am not.
>> >>> on
>> >>> I took a quick look from the MM's POV and found nothing obviously
>> >>> wrong. I'm hoping they have better luck with the MIPS experts.
>> >>
>> >> Hi Yu,
>> >>
>> >> I never hit such problem on my (non-bcm) 74Kc systems.
>> >>
>> >> However a quick glance suggested it may be related to Wired TLB entries
>> >> on your platform.
>> >>
>> >> Both duplicated TLB entries, Index 2 and 3, are all below "Wired" setting,
>> >> which means they are not managed by mm, but platform code.
>> >
>> > I just tried to dig into bcm47xx platform code and I think we should blame
>> > bcm47xx_prom_highmem_init, which created wired entry for high mem and may
>> > conflict with kernel's mapping.
>> >
>> > Nowadays, MIPS mm code can handle highmem on it's own, so there is no need
>> > to create such entry IMO.
>>
>> Sorry, I think I made a wrong diagnoses, it's actually a problem in our cache
>> alias code.
>>
>> Will try to fix.
>
> Thanks for looking into this!

So it's a problem incurred by OpenWRT's down stream patch rather than upstream code.

This is sorted at: https://github.com/openwrt/openwrt/pull/15635 

No further action required :-)

Thanks
-- 
- Jiaxun


      reply	other threads:[~2024-07-03  5:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-28 17:57 Yu Zhao
2024-06-30  2:22 ` Jiaxun Yang
2024-06-30  3:01   ` Jiaxun Yang
2024-06-30 17:25     ` Jiaxun Yang
2024-06-30 18:23       ` Yu Zhao
2024-07-03  5:13         ` Jiaxun Yang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2815c608-a921-476a-92c1-c4d648f95a3c@app.fastmail.com \
    --to=jiaxun.yang@flygoat.com \
    --cc=linux-mips@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=yuzhao@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox