From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21E72CD54BE for ; Mon, 25 Sep 2023 20:11:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A95E08D0035; Mon, 25 Sep 2023 16:11:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A45B38D0001; Mon, 25 Sep 2023 16:11:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 90CAF8D0035; Mon, 25 Sep 2023 16:11:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 81D118D0001 for ; Mon, 25 Sep 2023 16:11:43 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 5678AA06BB for ; Mon, 25 Sep 2023 20:11:43 +0000 (UTC) X-FDA: 81276215286.01.7366573 Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) by imf01.hostedemail.com (Postfix) with ESMTP id 9C17440013 for ; Mon, 25 Sep 2023 20:11:39 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=none; dmarc=none; spf=none (imf01.hostedemail.com: domain of riel@shelob.surriel.com has no SPF policy when checking 96.67.55.147) smtp.mailfrom=riel@shelob.surriel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695672701; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zyU96XuEyyB8OidMXxtYxG04PuNdpLZ5yhO7IBlJiFQ=; b=VMLaCxrsWgxVoDBL/sbx4BVGGCYxL4IriXU5PBs+c3q3+e/Pjvi18+zKPYj9vcqXyvaAeA RU+mjig4FeixTIr5uIdrzEXqZQC3Xp9prSfjcKrAcE63caDholGZmVtpkqCvnv0Ct1Ugwj 0GrU14z9v4sSl8FQhqnSyuwvDDOhCoM= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=none; dmarc=none; spf=none (imf01.hostedemail.com: domain of riel@shelob.surriel.com has no SPF policy when checking 96.67.55.147) smtp.mailfrom=riel@shelob.surriel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695672701; a=rsa-sha256; cv=none; b=29HGVhbgfCuu7O+o8H2avMmhTqvItGZmPFx6RZsjQsxiIhAVtCAf/SR7SyRdbFnPqJFOcC atJylAVT8yu73pQs89900ZkQrpIRSSBJUYYTagA/4elDT/nMkdeleBkgdVALlCWkseHDR3 PRwJ2EfSBqcUyOFG8MGT6gSaeEFzQxM= Received: from imladris.home.surriel.com ([10.0.13.28] helo=imladris.surriel.com) by shelob.surriel.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qkrvU-00065u-2H; Mon, 25 Sep 2023 16:11:28 -0400 Message-ID: <2813e3aea98da510b9075e2a532272a1f77f5355.camel@surriel.com> Subject: Re: [PATCH 3/3] hugetlbfs: replace hugetlb_vma_lock with invalidate_lock From: Rik van Riel To: Mike Kravetz Cc: kernel test robot , linux-kernel@vger.kernel.org, oe-kbuild-all@lists.linux.dev, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, muchun.song@linux.dev, leit@meta.com, willy@infradead.org Date: Mon, 25 Sep 2023 16:11:28 -0400 In-Reply-To: <20230925200659.GB11309@monkey> References: <20230922190552.3963067-4-riel@surriel.com> <202309250923.NEPT0ip2-lkp@intel.com> <692fafae9842a9b15b7b4a033bb7dc800784d4aa.camel@surriel.com> <20230925200659.GB11309@monkey> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 9C17440013 X-Stat-Signature: 6ruttokre6he884z78t8a7uw3pqhdtiw X-HE-Tag: 1695672699-815556 X-HE-Meta: U2FsdGVkX187SCP7ZQ2cR+Pv3/rWFgOyUeKlcM3cUQBZY+cyuOuGThydFW+3lojcFI7wEhrVyLYH0NNUc5kw7iiLNRWmdBdQ/UgujshRRHWQtX0b4ZeDIQRGeSKvptklJUoldPFfehIpYqYpsjbsdscGzJP7unJZA7+s0nr9kBZr1fUhpdotSP1l22mQT2sobiBkoFnjIICzQOeTnJrHhXO+p3kEoo/azmFK5tNxhVYjGYoZ73K/YFxL1b+/Mrriad2Ce3PgjJfVK0gFa6Iy/gpqwMzBStcW9aTB8F79NqS8KQrgbFX0o5DS3pDyBixeAuX6fU4dHDZ2AQ1RndQhoMCTl1gZMqs7/OrNOLIE1EuVfNdyw+f766M01ZDbugSYxQiZj7rvLcidO+42Z52cbStBQIdDUziwIjj60lIYSZkrlAEg4aLHs5yXdJotidLRJcMP4/5xJdnIha2Sb+H4/9k9pMRfeqUVjjnfhBOigvv9nb+AnbdC8L1vkOE0MXZI9rjx/7Gg6qnSupZTjxBBYHtzbCfy2fTW7Xy7zRhToSCegQIrB+lWDNh00wkix5W9qCSz3mFG+znG2AkoJhkMxfG1G5Stmhs7rG9d3VERgxoDjYOHce/Bym9E4Jf7EllGDeBVwBas070dAJyw9rBI2bHlwvpAAr8ZBMb5zsN+R6NoaqHwPua4WI9FtLSqnUVI4h1zP785s776N7DpJu+tJCnGIl+5COdzS6xczio5uA4d7eVYnb4DMRnS+wR3f5CzVYZ48vJuFY1y4NKyHm9Apz+6W9RhDYD2HJ1TXjtv9T1rEJh404qQAQbS2j/U6XUM85fTEDiFxOfqf1eMmDZSfrpDqOZxNuKoVpyBREQnvLHjnAQE9H/a+YGGG9pSaogPgZOg0GiOuMXlqdES+vnD+W3fpi2eOcOK4TkEd2DZbUw4GxC/dgZLMl7D/KslBrUFQIx3HQEjfPXcxnkp3Qw /43Rxdy5 LVjBaQsOUyyC+3yQ7/k5Ch0PWLVCnqzX4NdUVlI2gXxlvCUQdpIUn/TkZ0kjGdXUORffqvxq+fgMLP0bQkkRdbpo/21XoVrSn53aWQpXxIox4kfypIpFGx6n1M8+DJliSIrNKLb+PZOFflv32FJHKoKPR/rjVyhf/4TR2zpdWyuqGcgrcfyZ4Bhsb02G5FDmtDxGm/m0eRR9HnPQ93oHAw6XmQG9sR2tuOzfqvpMTdWxcFz+8MiOztILrxBpHifa+DmojwyPN4/JM1VpLWU9VegUXZfZ2Wy+r3Dj+JOLalb0nzUawPc59umrTWjnh98f2duSb01MyrVCWMqjZCN7zwSrKvdN2r5Yo4sl7 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 2023-09-25 at 13:06 -0700, Mike Kravetz wrote: > On 09/25/23 15:22, Rik van Riel wrote: > > On Mon, 2023-09-25 at 10:04 +0800, kernel test robot wrote: > > > Hi, > > >=20 > > > kernel test robot noticed the following build errors: > > >=20 > > > [auto build test ERROR on akpm-mm/mm-everything] > > > [also build test ERROR on linus/master v6.6-rc3 next-20230921] > > > [If your patch is applied to the wrong git tree, kindly drop us a > > > note. > > > And when submitting patch, we suggest to use '--base' as > > > documented > > > in > > > https://git-scm.com/docs/git-format-patch#_base_tree_information] > >=20 > > OK, so I have a fix for patch 3/3 that gets rid of the > > compile error, but the libhugetlbfs test cases show that > > patch 3/3 opens up a condition where resv_hugepages=20 > > underflows. > >=20 > > I have not figured out the cause of that yet, but > > patches 1 & 2 seem to survive all tests fine. >=20 > In addition, I suspect patch 3 is going to cause a performance > regression. > It is taking me a little while to resurrect the test environment used > when > the hugetlb vma lock was introduced.=C2=A0 My plan is to exercise the > series in > that environment. >=20 I am planning to send a v3 of the series soon, once I have confirmed that the bugs in patch 3 have all been fixed. I have no strong opinion on whether or not patch 3 gets merged at all. Patches 1 & 2 fix the actual bug that I am trying to fix, and I am perfectly fine if patch 3 ends up getting dropped in the end. It seemed worth trying to get that cleanup though ;) > I should be able to review patches 1 & 2 later (my) today. Thank you! --=20 All Rights Reversed.