From: "Weiny, Ira" <ira.weiny@intel.com>
To: William Kucharski <william.kucharski@oracle.com>,
Huang Shijie <sjhuang@iluvatar.ai>
Cc: "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"sfr@canb.auug.org.au" <sfr@canb.auug.org.au>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] mm/gup.c: fix the wrong comments
Date: Thu, 4 Apr 2019 16:53:53 +0000 [thread overview]
Message-ID: <2807E5FD2F6FDA4886F6618EAC48510E79C99E19@CRSMSX101.amr.corp.intel.com> (raw)
In-Reply-To: <3D9A544A-D447-4FD2-87A5-211588D6F3E5@oracle.com>
> > On Apr 4, 2019, at 1:23 AM, Huang Shijie <sjhuang@iluvatar.ai> wrote:
> >
> >
> > + * This function is different from the get_user_pages_unlocked():
> > + * The @pages may has different page order with the result
> > + * got by get_user_pages_unlocked().
> > + *
>
> I suggest a slight rewrite of the comment, something like:
>
> * Note this routine may fill the pages array with entries in a
> * different order than get_user_pages_unlocked(), which may cause
> * issues for callers expecting the routines to be equivalent.
This is good too. :-D
Ira
next prev parent reply other threads:[~2019-04-04 16:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-04 7:23 Huang Shijie
2019-04-04 12:32 ` William Kucharski
2019-04-04 16:53 ` Weiny, Ira [this message]
2019-04-04 16:50 ` Ira Weiny
2019-04-08 1:23 ` Huang Shijie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2807E5FD2F6FDA4886F6618EAC48510E79C99E19@CRSMSX101.amr.corp.intel.com \
--to=ira.weiny@intel.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sfr@canb.auug.org.au \
--cc=sjhuang@iluvatar.ai \
--cc=william.kucharski@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox