From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D10DC4167B for ; Mon, 11 Dec 2023 21:11:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7408D6B020B; Mon, 11 Dec 2023 16:11:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6EEAF6B020C; Mon, 11 Dec 2023 16:11:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 51A836B020D; Mon, 11 Dec 2023 16:11:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 3D01A6B020B for ; Mon, 11 Dec 2023 16:11:27 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id F3219120825 for ; Mon, 11 Dec 2023 21:11:26 +0000 (UTC) X-FDA: 81555783372.04.6CB8429 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2063.outbound.protection.outlook.com [40.107.237.63]) by imf22.hostedemail.com (Postfix) with ESMTP id 0E102C0026 for ; Mon, 11 Dec 2023 21:11:23 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=amd.com header.s=selector1 header.b=gNK5nIAE; spf=pass (imf22.hostedemail.com: domain of Ashish.Kalra@amd.com designates 40.107.237.63 as permitted sender) smtp.mailfrom=Ashish.Kalra@amd.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=quarantine) header.from=amd.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702329084; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iCQlNXeMh3MMrKodn3KJZTEiTKuKflU4pnh41nCxQs8=; b=cxbPTt/5jm5cYenneGrkpJQI194yOJl1vcbBWPPfQrYD2jMbtEYsRbKb0as3bLkvxfof83 V0repaQeMF3oVX4YjPvfUqWSEHVqY38YgrcU4qKQopJMrwWIXwvalBHb+E1m3ZjJtZ2bJ5 8sQBhQBhh/RgWgDs6DH8mmc6ozVY8Oo= ARC-Authentication-Results: i=2; imf22.hostedemail.com; dkim=pass header.d=amd.com header.s=selector1 header.b=gNK5nIAE; spf=pass (imf22.hostedemail.com: domain of Ashish.Kalra@amd.com designates 40.107.237.63 as permitted sender) smtp.mailfrom=Ashish.Kalra@amd.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=quarantine) header.from=amd.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1702329084; a=rsa-sha256; cv=pass; b=gmbioT6YMInvapjhwG3L1fvsPUJSVdZDiBiWdHvS/MnLIcidCAy0KEZVzSrmWhgMXvkalH hZ0gM81Fk3F02GgKXdkpKgkB2H81JfOAHjNsF04e/J/ny950I1MTPQeB0K/u7M18bw7Zum /xBIwnDqKIWHvDbZFSL+QrzB2wFQc6s= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=capwhdIMFl+GDO48A1JbOhlj9F3a3lDD5wbQn2ZI+MHEmc9HmocAlsRwdOCi1a9Bh5M6BOtbyQd6+D/G/yXtSdM5G3HpXkdsRQpFcoBOnCN8RDwjdG3hm6BReVLrSnhmjWNX423QQEIhRZ3iO9vQycUc3sg5bGV5PAjtzIRhWchWpztS9cioTCr5gIkPAD1OpgUzvpVqHEEJvTydIeVtd8oS2HbWk/eA1+AmlJgHRqD9hjl9Hok69BcOmMwgxis85MuZJWAMqc3B23yYs033iRs9gRy45isxwnLUMpgeVwxiP4hVsadJa6Xh7VjCC7+15lHAqJDeMFwMFh/75q29MA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iCQlNXeMh3MMrKodn3KJZTEiTKuKflU4pnh41nCxQs8=; b=GTqBpSb05mmlZ+UxVTF6rLsKrJnmJ8WyXiUOdKUuFMgZXxsCduFVHidrp5GHcngzRk0RPUYAg/GS8WPfP9ocQx5s9TsXhY5EaDcBTBn8jfY2CnqKl4gRe/oW5F/+DnefUsBykvRVCoeosKhOMuDxsLEV/vVZ5tznTslW6EL48PKb3NfCO7oxCsfqSukRvdHWYm/YSrHiYPzmVRVHAMqT1wLF1TKAoe5AJ04LxJcpmHi63SZ7+cF/ffQSlf8vcqDDUyLY1sphGNjAW7nt6ikXjmxkcc6Yv6HAuDGMwa9k2/P1Z0DZYHt3qTdsZJjGSaCjZ2pZLhWW9lmSdjDBmCrXfw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iCQlNXeMh3MMrKodn3KJZTEiTKuKflU4pnh41nCxQs8=; b=gNK5nIAEB9BxNGpLgE6+Pilz0tPrNzNecO+4zV6G//+C1o9A3Yg07ROu7hc69CjzMYlaHZNStdtmickIkpN591M2ZuJw1G4dlQlt0DVuwd4dcdlrIaGsD1m85OZDskoSC9KA+K7S2KAzkkboRMDJuyQyNPEeMJc3YmUzHdLBPnY= Received: from SN6PR12MB2767.namprd12.prod.outlook.com (2603:10b6:805:75::23) by CH3PR12MB8536.namprd12.prod.outlook.com (2603:10b6:610:15e::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.32; Mon, 11 Dec 2023 21:11:20 +0000 Received: from SN6PR12MB2767.namprd12.prod.outlook.com ([fe80::3341:faaf:5974:f152]) by SN6PR12MB2767.namprd12.prod.outlook.com ([fe80::3341:faaf:5974:f152%7]) with mapi id 15.20.7068.031; Mon, 11 Dec 2023 21:11:20 +0000 Message-ID: <2800d4d6-8ae9-e6c9-287a-301beb0a2f50@amd.com> Date: Mon, 11 Dec 2023 15:11:17 -0600 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.1 Subject: Re: [PATCH v10 14/50] crypto: ccp: Add support to initialize the AMD-SP for SEV-SNP Content-Language: en-US To: Borislav Petkov Cc: Michael Roth , kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, pbonzini@redhat.com, seanjc@google.com, vkuznets@redhat.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, dovmurik@linux.ibm.com, tobin@ibm.com, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, marcorr@google.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, jarkko@kernel.org, nikunj.dadhania@amd.com, pankaj.gupta@amd.com, liam.merwick@oracle.com, zhi.a.wang@intel.com, Brijesh Singh , Jarkko Sakkinen References: <20231016132819.1002933-1-michael.roth@amd.com> <20231016132819.1002933-15-michael.roth@amd.com> <20231127095937.GLZWRoiaqGlJMX54Xb@fat_crate.local> <20231206170807.GBZXCqd0z8uu2rlhpn@fat_crate.local> <9af9b10f-0ab6-1fe8-eaec-c9f98e14a203@amd.com> <20231209162015.GBZXSTv738J09Htf51@fat_crate.local> From: "Kalra, Ashish" In-Reply-To: <20231209162015.GBZXSTv738J09Htf51@fat_crate.local> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SA9PR03CA0021.namprd03.prod.outlook.com (2603:10b6:806:20::26) To SN6PR12MB2767.namprd12.prod.outlook.com (2603:10b6:805:75::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR12MB2767:EE_|CH3PR12MB8536:EE_ X-MS-Office365-Filtering-Correlation-Id: 00676926-4538-482a-3040-08dbfa8db8f1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oxANGmkK9i6dSjxMlkK8iN0EktOb5EQa8Grx4IZ4SCKX3SJeclXE23LXtTJrEorLJ1Hr5j00vhl9mJGi6Akjy44VJ0gK7s6ZcxJrgSjleaJi+v3htS8BKUX4ZQZW1JeN4bpxxd/kYU31eU4+h2hAMxWiIobZrYGoMYrxjOerFB6LPOI0Pmiz5BbqGNR1SHZGWYzJN1lqQsY5ORR2w4CbCWWqzrFrfhaWnHKqsGgPYDrihQHPldrFg2yiYRztkXiusXyrqtpUsJr/i2bq6cqG1Z71wOx+ADyPCGmKgBvNTpFL7XicVUSjKX1PjIk6kIt5j2SAbBopHGQfQoMOXBQXojah3pm6JU8sjtKaR8U8Mr3cxVx2akgj2+4zj8tXe4qHd/bSt8nVZN8V2GITHBCf0JzJlTV9PqO1Wx95Youty9D/nSeBOZdS9CuItrLybtpdk8va/Dluf6X6uAEPppSSrnCaT/yFvz9WWZrpSV0p2euaTi2MpEkrPdIRTHAnLqGsVSKJXa3ZfZLqgv8moVm1iXTm1YhikGyelmO3dty4cXehWArbt31iqqtYjHpK4rR5QG9LucIAcXSie0S/a3L5AdKvT0B75VcBSLz4ysueySbqNjZHCjelnc3i3J7BDn4qkpGaVQZdwuXQEVAhm4M9KA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2767.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366004)(39860400002)(376002)(136003)(346002)(396003)(230922051799003)(451199024)(1800799012)(186009)(64100799003)(41300700001)(5660300002)(7416002)(7406005)(2906002)(6512007)(53546011)(6506007)(2616005)(31686004)(36756003)(478600001)(6666004)(6486002)(38100700002)(83380400001)(8936002)(26005)(4326008)(6916009)(66476007)(86362001)(66556008)(54906003)(316002)(66946007)(31696002)(8676002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NVg5dHp4S3UvejJPVnFTeFpiSDcwSW1reElnT1RKQXMrZEh5SUtkZmNkeVVi?= =?utf-8?B?ZW9QYk9scG1NSWFUVnpFNUlObHFwbjcydWNtQ09pWnpGZ3dvZzNyTWVYREhD?= =?utf-8?B?b0Y1aStkRjhBSFJ6ZU5SQzY4M3JFZnhRS0NmSXM4c09PWjliT0tpcGJZNUlx?= =?utf-8?B?a3kwSWIvUlVOU1ovNmlvTEdOOEh5WHRHRjF1VUwvWGpsUE9ESDJEUC8zY0ls?= =?utf-8?B?MkxCdmk5QXg3M3pBK3VIVTFzTWJMNk1ZM0txSkZmWHU5R21YNDdGT1J2QVYy?= =?utf-8?B?Mm9yRzFJaHNId01pU0pkOUR4QkpCYWdUMjdJR3dNc0hDVjR1UENjdjFXMHZS?= =?utf-8?B?ZEV3dlpnNGRIbEw1LzMxODRldUh0UzNobHVPNE52WTVBd2xDVmNhZlRMNi9t?= =?utf-8?B?aWptUURMVnNPK0o5RURJMXM1OVJOMlVjaGNqVDRpZHE3R0tmdE4vT3BmWis2?= =?utf-8?B?TWhCZkNSbXFhK1hXWHFzTHNBTzJJWTZRb0w4dVpqWU9Ed1Qvc1d0U1VvSGMr?= =?utf-8?B?bXg4QmQvM3h5V2xEUUdjYmtsbWpTR29GUVRPK2JoZzJHUHM1YmtuL3gxWWRs?= =?utf-8?B?S1RiRlMrNWdkajZkOFZzakxRRHhqaHRvRmRVdWFNakNqc0lUY3lGUzlWL0E1?= =?utf-8?B?NFVQSmEzdEZLVGE2N3lYMUY4V3UvOVZrc2ZVKzhPdjRwaUUybU5TTFBKWDkv?= =?utf-8?B?OHN2OG1KeHFLdVorNURLMDlOTW9mend3R3hoZitLV3VyZ0FRTjhta2NhU0xx?= =?utf-8?B?NDBFeFZOMDZRbDdiUk1TY3dPSkEwaUtWWThoMGNFZDNoTFB0bmptY1hSUmE3?= =?utf-8?B?b3BlS3NaallTTlhFMXpPbDhwOHNvM21lMHZZSExFU1d0c2NRUzloblh1OHlS?= =?utf-8?B?RXdhVGF1aG5xRUhZV1k1SkxJbCtUd2Rna0ZuYXpXMVJqdE5ENEFXVVJiRlhz?= =?utf-8?B?MEtwdlZDSU1rY1lWYXg3TVBsbU84VjRTcnROOEdKN2NhaFNUR3BnUkNISFY1?= =?utf-8?B?TUFZL2FGalQ1NUJ6djJWdHpZQjJob2pzc2RyVllyOSt6WnhPeGpiWUEycGF6?= =?utf-8?B?N2F6ajRsN0dYS1JZY1BUcXc3T2pkUXl1QkM5dE85Y25RWUdSUG1JVDE1OU8w?= =?utf-8?B?Wnkxbi9yUVhCRDZqSFhmNjhyczdXNGFwV2Q4Z3N0MWV6MjZ4MkRrcmNETzhV?= =?utf-8?B?UGlSNitUNXRscVdPRzlxT1pzcVJBOWhqSHFjVmt0a3g1SDh4b3FZRFgwOGNl?= =?utf-8?B?eGh0Ynl3SFhVVmVVbVdYZGNTN0N3ckd0dUg0eWtDSTFEUjcrVFd2dml5RnRq?= =?utf-8?B?Sy93QWhTdVBxYmRUcmdxQUxBQlhUc0RTYlBna0F6TnNYaTM2b01kWDRwdXc2?= =?utf-8?B?MXl4SGhTSjczeEsrNW43T2RGSXN0WGdYQnNhZVFzUWxqL3hXUXpnbmxYdWxs?= =?utf-8?B?WXZyNnFjWHRsS3I2OHkwL3Uvd0E3c0R5bGFLbWNMODF6eDQ1cEVwZnNrTFYv?= =?utf-8?B?SVlINkRwNnRtcWcrcjVxK0JadEs3WFh0eG1ZZHhVNGVucFoxTXVoOW51MXBw?= =?utf-8?B?eE5KQy9hendxTG1vTGVXN2I2WThqYzErM1EwY0VocWllOTl5OEFhQUc1bWsx?= =?utf-8?B?V3FoWWtCbkpBbTY3U1BDUndNRmdMckZhaEdhZXhxOFlsYjg4bm8vZy95ZTcz?= =?utf-8?B?OXRHbDUyWDhkSU91Q1UzY21VMytMd3EzUW5YZ1A4b0hBa2RxWFRTM25icGtX?= =?utf-8?B?TDVXbmhlZ3hFOVdKT0YrUVJFYndnZE1iZHM2Tjc2bDlPWmhrd2NnSFhnYlB2?= =?utf-8?B?UHRxZ2kvRHhaL3ZoU3JkRmlDYUZWeDM5dnRMUDV5Wjh2Qkx1ZFRMT0NJb2w1?= =?utf-8?B?UzBXanJZRXZyQ3hQdkVZWUhkcVhYMFAxanNTWFlRL2J5UlhraVJROWIvMWll?= =?utf-8?B?b1RXNm1OazlZUVNXMXpwdGFaWWdlT25SQk1jaHVQdjU3cGE0a3grcldRVXNq?= =?utf-8?B?ZGl4ZHovTjVSWUNkM0orL01GMEJqdHUrY3pMZ1ovTVlUdXUxOHpNdzg1M1Z5?= =?utf-8?B?TDZjbE5NYUUvaTVkdFM3RXg2bDNIb1dyNXJSWmdnbW1Vdm9WTzdsbXA4dGJz?= =?utf-8?Q?AjiPlVankMZrjAta98nkmPd/m?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 00676926-4538-482a-3040-08dbfa8db8f1 X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2767.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Dec 2023 21:11:20.4626 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3+BulLT4SX+uX5bhtXDQfEiQbtN04MWxqwBEz6rC/Fi+xgehfBTODKu6j0kOxLhJtnVSK4WAepgGtcyGmDH89A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8536 X-Rspamd-Queue-Id: 0E102C0026 X-Rspam-User: X-Stat-Signature: chgkdeoztsctgmas3mdaaaxgngxr6z5a X-Rspamd-Server: rspam01 X-HE-Tag: 1702329083-374155 X-HE-Meta: U2FsdGVkX1/uuGuLlAOD7WaQgKDY0KtKpm9MnfYDvx19rC7vJzvRMVw1zR/W3cUuZu6gC01eQRq0qr8fs9wzhcmFu/Yf9rM1MXUWBFYnR2wufPzufwiL/xJ7nT87425a5b93Fz4iUao8V1SSIZvoCsgCrdKunwxn4RdEbX5S0NyjxECQeQbimGR7LJzUr9qlHUxgzQaER2UPJdKfaInPadpp6NAPjLrnMhVtpwm0zZeVYQiIFNeXkPK9IK1lAGHni1bBdM71mbCTnZd2BNWCu/wn2b1q3GUM/oKDOdPHfC2v40RFpLkgCIYzYdTvddDR+JtJU7yo0nvTGkIrVMzbC9oGaQU45KfJpy2O+mnD51LbfR2t4zbMmSBra0mTankqM++aaV8iWaUENCx8U0loDUJX5E5nbA26/JDeqcOT11tQVBkE1W5JiixJqqvToxrrljgnO2WCK4GhzzfeNSPq36IZVxkgdIWxh6U5OXLCgX0r/Z6LWDMU3aPtYjBYtvZb41UdQc8lKlms83wwzw11G7Qh6SGx87qEATaWPzXYvrN79wmsoqNvDXuIlUU7WVUdBD8pbrQ4+IfOTsA5tZqODdLmvRG0tAnlicymvVPTOjhdHOzP3/+SsdC5TrEl8KS3+4OHSSdZuBB37t8/gJ5tjlgECP6AssUvUi3V2WSve93lP8d4Ubx43aTf6PrytNn1DUj4lOQD742XYUq/YdjYH8FzMVRmhP01Zlp46+q20tLg1bt6ynX6wspKJl1PUI4wbvUHHh/0sbOs2ytb9x+S8uq5vicft4M++3i2pGBe7I2DbQGJ23B9x8FTKdl7C18Eoz1e/CUtiuk0qg+dLNLG1rtP5sz34YW7XgkIGK/agiE6E7FxxJgqvnQIclNHyzWgHshbqFr7R7YGRHkE1w0tK7RUEs3NpnBrkC2S1ovF+3APDdCxQX9YBGNIHTjxikVkVG3i7DQnrv1hPN+N/4Y k1lt6uHH vKWb0OaKGs32ZNdjAve5b3OLrlPIhG5g8OBFPkq/GScJgUX5bYiqje7znccg/k32I0+/c67uHPw00zdjbnBmvxU/4QMMDlivEMH2AGxGzkYUSU/hfGZ0oynmbYCTxdTsYoGEMGiwz8+WbQj84m9fm4imbZbAmysidvduPZNkCD2fd7JhxiaKMA8C4UIsXK5BNjK4nRboodj9WmBE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hello Boris, On 12/9/2023 10:20 AM, Borislav Petkov wrote: > On Wed, Dec 06, 2023 at 02:35:28PM -0600, Kalra, Ashish wrote: >> The main use case for the probe parameter is to control if we want to doHl >> legacy SEV/SEV-ES INIT during probe. There is a usage case where we want to >> delay legacy SEV INIT till an actual SEV/SEV-ES guest is being launched. So >> essentially the probe parameter controls if we want to >> execute __sev_do_init_locked() or not. >> >> We always want to do SNP INIT at probe time. > > Here's what I mean (diff ontop): > See my comments below on this patch: > +int sev_platform_init(int *error) > { > int rc; > > mutex_lock(&sev_cmd_mutex); > - rc = ___sev_platform_init_locked(error, true); > + rc = _sev_platform_init_locked(error, false); > mutex_unlock(&sev_cmd_mutex); > > return rc; > } > +EXPORT_SYMBOL_GPL(sev_platform_init); > What we need is a mechanism to do legacy SEV/SEV-ES INIT only if a SEV/SEV-ES guest is being launched, hence, we want an additional parameter added to sev_platform_init() exported interface so that kvm_amd module can call this interface during guest launch and indicate if SNP/legacy guest is being launched. That's the reason we want to add the probe parameter to sev_platform_init(). And to address your previous comments, this will remain a clean interface, there are going to be only two functions: sev_platform_init() & __sev_platform_init_locked(). Thanks, Ashish