From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 051B2C433E0 for ; Fri, 19 Jun 2020 01:34:53 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BC6FE20809 for ; Fri, 19 Jun 2020 01:34:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BC6FE20809 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5F8878D006E; Thu, 18 Jun 2020 21:34:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5A8828D0052; Thu, 18 Jun 2020 21:34:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4BD9F8D006E; Thu, 18 Jun 2020 21:34:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0249.hostedemail.com [216.40.44.249]) by kanga.kvack.org (Postfix) with ESMTP id 315898D0052 for ; Thu, 18 Jun 2020 21:34:52 -0400 (EDT) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id BA7C4181AC9C6 for ; Fri, 19 Jun 2020 01:34:51 +0000 (UTC) X-FDA: 76944242382.17.match25_2311b6226e15 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin17.hostedemail.com (Postfix) with ESMTP id 98FFC180D0184 for ; Fri, 19 Jun 2020 01:34:51 +0000 (UTC) X-HE-Tag: match25_2311b6226e15 X-Filterd-Recvd-Size: 3388 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf24.hostedemail.com (Postfix) with ESMTP for ; Fri, 19 Jun 2020 01:34:50 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 238DFD6E; Thu, 18 Jun 2020 18:34:50 -0700 (PDT) Received: from [10.163.81.119] (unknown [10.163.81.119]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 216703F73C; Thu, 18 Jun 2020 18:34:41 -0700 (PDT) From: Anshuman Khandual Subject: Re: [PATCH V3 (RESEND) 0/3] arm64: Enable vmemmap mapping from device memory To: Mike Rapoport Cc: linux-mm@kvack.org, Catalin Marinas , Will Deacon , Mark Rutland , Paul Walmsley , Palmer Dabbelt , Tony Luck , Fenghua Yu , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , David Hildenbrand , Michal Hocko , "Matthew Wilcox (Oracle)" , "Kirill A. Shutemov" , Andrew Morton , Dan Williams , Pavel Tatashin , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linux-riscv@lists.infradead.org, x86@kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org References: <1592442930-9380-1-git-send-email-anshuman.khandual@arm.com> <20200618085641.GE6493@linux.ibm.com> Message-ID: <27f8c6f9-3970-6f02-dff4-7ca15bee7138@arm.com> Date: Fri, 19 Jun 2020 07:04:35 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200618085641.GE6493@linux.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 98FFC180D0184 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 06/18/2020 02:26 PM, Mike Rapoport wrote: > On Thu, Jun 18, 2020 at 06:45:27AM +0530, Anshuman Khandual wrote: >> This series enables vmemmap backing memory allocation from device memory >> ranges on arm64. But before that, it enables vmemmap_populate_basepages() >> and vmemmap_alloc_block_buf() to accommodate struct vmem_altmap based >> alocation requests. >> >> This series applies on 5.8-rc1. >> >> Pending Question: >> >> altmap_alloc_block_buf() does not have any other remaining users in >> the tree after this change. Should it be converted into a static >> function and it's declaration be dropped from the header >> (include/linux/mm.h). Avoided doing so because I was not sure if there >> are any off-tree users or not. > > Well, off-tree users probably have an active fork anyway so they could > switch to vmemmap_alloc_block_buf()... Sure, will make the function a static and remove it's declaration from the header. > > Regardless, can you please update Documentation/vm/memory-model.rst to > keep it in sync with the code? Sure, will do.