From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EB9BC433F5 for ; Fri, 18 Mar 2022 10:35:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AE5208D0002; Fri, 18 Mar 2022 06:35:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A907E8D0001; Fri, 18 Mar 2022 06:35:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 958148D0002; Fri, 18 Mar 2022 06:35:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0221.hostedemail.com [216.40.44.221]) by kanga.kvack.org (Postfix) with ESMTP id 86D788D0001 for ; Fri, 18 Mar 2022 06:35:33 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 31BBF18272EE1 for ; Fri, 18 Mar 2022 10:35:33 +0000 (UTC) X-FDA: 79257150546.24.EC562BF Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) by imf13.hostedemail.com (Postfix) with ESMTP id B45DC20021 for ; Fri, 18 Mar 2022 10:35:32 +0000 (UTC) Received: by mail-wr1-f50.google.com with SMTP id j18so1515375wrd.6 for ; Fri, 18 Mar 2022 03:35:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=conchuod-ie.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=JfEJoa5FQc0SFv27pEV1qIzAe58CvJ8qEwch4fxvvoE=; b=QQfcznGO/K6jTP86GQkpnjsQjiIPCViMn0XlfOIfbsb/naLgYwfikZaq8sPO/C1i0e lllNiDeQTVf62x2sq/V1WevimJHfu9HDecvPQj6ZbxO4Yay86hBVzy/jZX7L43GJtegO HI5oYufU1bxESgmsgxItSmDDQ1ZEkIeFi+0QLv6bk4IO5eGKKBKFe625RmEeIllLSkT/ 5PTOleF9mPKaq8jSfb87sC1COe1OoS1rFMK0O11UL6XAxG1ODrrmkqowIk0F4tz93Cf8 797A7oWVmj8mEkP8BLk3qmOpuCsxDV3AFS7uisBzs6E5GKh91SdndFRAEPaLAo4xt54h Jq4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=JfEJoa5FQc0SFv27pEV1qIzAe58CvJ8qEwch4fxvvoE=; b=viGZh/Uqk3GbaDZK9fLQqVITe72t56fu5kPk2QQHwJ8LciBWALHW8x+ZMsaTX3iWXw 5jNMpnfAFkGEfUThgCelRJYacT6IFcaqarlyAiZudIfE+kewgzttcbyroA/+mYQsPeSk sJjQV4foMT5/WohjYfBkNBgD7vl+nFvn5v228Xd9Rsazd+HhuC0/mJUqZj63UMQ5dBZJ z2kDZdGpDwcDxmxLNczfgeNPY7NoVx4NSIz/DC8NPm4O081CD/L59d4l3owR6Gve45UK 7Fn9hNKflQYiCt7PWj4rVj3cwl5ekfY9XsiSHdvJFS8APLG9Ulyo7DEPD2SF6ITE+YMQ OqTg== X-Gm-Message-State: AOAM530Tz2IBaWlKFoWnotINMGgYDwt6ROF+7BRyXfgnOqwZReZLRp7M M1dtR45S221jdSoZCbNQBMr5lIwHlpFgmxH4 X-Google-Smtp-Source: ABdhPJy0MNJclHla0TRbVHd7YSXLESGy7yRg7KgQrfBrGXNtcdqzvQNrymXKxcLipuDZj9UqERiFPQ== X-Received: by 2002:adf:c188:0:b0:1e6:8ecb:ea5a with SMTP id x8-20020adfc188000000b001e68ecbea5amr7282848wre.711.1647599731107; Fri, 18 Mar 2022 03:35:31 -0700 (PDT) Received: from [192.168.2.222] ([109.76.4.19]) by smtp.gmail.com with ESMTPSA id 11-20020a05600c26cb00b0037ff53511f2sm8991921wmv.31.2022.03.18.03.35.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Mar 2022 03:35:30 -0700 (PDT) Message-ID: <27f88b3e-f814-c284-e399-33e9cd5db205@conchuod.ie> Date: Fri, 18 Mar 2022 10:35:29 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [linux-next:master 7918/13392] drivers/soc/microchip/mpfs-sys-controller.c:73:1-6: WARNING: invalid free of devm_ allocated data Content-Language: en-US To: Nicolas Ferre , conor.dooley@microchip.com, lkp@intel.com, Arnd Bergmann Cc: kbuild-all@lists.01.org, linux-mm@kvack.org References: <202203180259.lgIylRZV-lkp@intel.com> <20220317211734.1340281-1-mail@conchuod.ie> From: Conor Dooley In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: B45DC20021 X-Stat-Signature: w7zrcwn53pfipmr71hbimk5kmb5sbfeb Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=conchuod-ie.20210112.gappssmtp.com header.s=20210112 header.b=QQfcznGO; spf=pass (imf13.hostedemail.com: domain of mail@conchuod.ie designates 209.85.221.50 as permitted sender) smtp.mailfrom=mail@conchuod.ie; dmarc=pass (policy=quarantine) header.from=conchuod.ie X-Rspam-User: X-HE-Tag: 1647599732-409302 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000010, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 18/03/2022 09:43, Nicolas Ferre wrote: > (+ Arnd) >=20 > Conor, Arnd, >=20 > On 17/03/2022 at 22:17, conor dooley wrote: >>> tree: =20 >>> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git=20 >>> master >>> head:=C2=A0=C2=A0 97add482e9033a9386baa8824fbea34d0cbfe663 >>> commit: d0054a470c33902f5ae88835ed8a8ecc3cf8faa4 [7918/13392] soc:=20 >>> add microchip polarfire soc system controller >>> config: ia64-randconfig-c004-20220317=20 >>> (https://download.01.org/0day-ci/archive/20220318/202203180259.lgIylR= ZV-lkp@intel.com/config)=20 >>> >>> compiler: ia64-linux-gcc (GCC) 11.2.0 >>> >>> If you fix the issue, kindly add following tag as appropriate >>> Reported-by: kernel test robot >>> >>> >>> cocci warnings: (new ones prefixed by >>) >>>>> drivers/soc/microchip/mpfs-sys-controller.c:73:1-6: WARNING:=20 >>>>> invalid free of devm_ allocated data >> >> Silly mistake, should've changed this when the alloc was converted to >> devm_. >> >> @Nicolas, rest of this week is public holiday, but I'll try to >> send a fix before the weekend. Should it go to you or to Arnd? >=20 > I cannot queue in my branches because otherwise it will conflict with=20 > the patch already taken by Arnd as an individual patch [1]: > "soc: microchip: make mpfs_sys_controller_put static" >=20 > What I propose is that we deal with this during the stabilization phase= =20 > as a "fix" after 5.18-rc1 is released (in 2 weeks). If that fine by you (plural) then that's fine by me too :) >=20 > Is there a drawback to this approach in the sense that it can trigger=20 > other test robots? >=20 > This way, we won't have to disturb Arnd as I believe that his branches=20 > are all ready to be sent to Linus after this week-end. Additional=20 > benefit, you don't have to change your plans and enjoy St Patrick=20 > week-end ;-). >=20 > Best regards, > =C2=A0=C2=A0 Nicolas >=20 > [1]:=20 > https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git/commit/?h=3D= for-next&id=3D17588e867e694e8a03234628145f7c4d738288e2=20 >=20 >=20 >=20 >>> vim +73 drivers/soc/microchip/mpfs-sys-controller.c >>> >>> =C2=A0=C2=A0=C2=A0=C2=A0 66 >>> =C2=A0=C2=A0=C2=A0=C2=A0 67=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= static void mpfs_sys_controller_delete(struct kref *kref) >>> =C2=A0=C2=A0=C2=A0=C2=A0 68=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= { >>> =C2=A0=C2=A0=C2=A0=C2=A0 69=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 struct mpfs_sys_controll= er *sys_controller =3D=20 >>> container_of(kref, struct mpfs_sys_controller, >>> =C2=A0=C2=A0=C2=A0=C2=A0 70 = =20 >>> consumers); >>> =C2=A0=C2=A0=C2=A0=C2=A0 71 >>> =C2=A0=C2=A0=C2=A0=C2=A0 72=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 mbox_free_channel(sys_co= ntroller->chan); >>> =C2=A0=C2=A0 > 73=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 kfree(sys_controller); >>> =C2=A0=C2=A0=C2=A0=C2=A0 74=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= } >>> =C2=A0=C2=A0=C2=A0=C2=A0 75 >>> >>> --- >>> 0-DAY CI Kernel Test Service >>> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org >=20 >=20