From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32FB3C43334 for ; Tue, 14 Jun 2022 02:20:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7FBB46B009F; Mon, 13 Jun 2022 22:20:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7835A8D01EE; Mon, 13 Jun 2022 22:20:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5FD846B029F; Mon, 13 Jun 2022 22:20:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 494B96B009F for ; Mon, 13 Jun 2022 22:20:41 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id 19D1880814 for ; Tue, 14 Jun 2022 02:20:41 +0000 (UTC) X-FDA: 79575237882.08.7D0C224 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf16.hostedemail.com (Postfix) with ESMTP id 5A628180083 for ; Tue, 14 Jun 2022 02:20:40 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 56A9A23A; Mon, 13 Jun 2022 19:20:39 -0700 (PDT) Received: from [10.162.40.17] (unknown [10.162.40.17]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5FE6E3F792; Mon, 13 Jun 2022 19:20:37 -0700 (PDT) Message-ID: <27f29bb6-f82a-eefe-4774-0d2d1872482a@arm.com> Date: Tue, 14 Jun 2022 07:50:34 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH V2 2/2] mm/mmap: Drop generic protection_map[] array Content-Language: en-US To: kernel test robot , linux-mm@kvack.org Cc: kbuild-all@lists.01.org, Andrew Morton , linux-kernel@vger.kernel.org References: <20220613053354.553579-3-anshuman.khandual@arm.com> <202206131716.tDWk9rLs-lkp@intel.com> From: Anshuman Khandual In-Reply-To: <202206131716.tDWk9rLs-lkp@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655173240; a=rsa-sha256; cv=none; b=KXbwoRu2cQkmJ/9LzhYSN2jRJXUnVltAra/p2AucqMhsJngqrFEF92iG4ye5FFbYWv0AzT VpsSq4P7NXe1mFsh5VtAREmY/OuIrsRyFoACU/gCiiNTrQ6mew6yMXmzSWDSD/HMYF8trQ NpD1VA8P8b5SsKg4i+qAABb5knjGoYk= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=none; spf=pass (imf16.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655173240; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JVVYusmGhuUe9w+nvun09bSuZImqp35AYUD67ysWosY=; b=b7KqiZdIx4ZETLcGL5wv/h/9OiztaMkB/JfEuoIaC/d/ce3i6b8DWioxN+JAVNOTayJKH8 4BrucQ9dj+szJWmgOD0X4jD9/kKEy+h9XlAaFhv361zTwv4pAHDrMsebmcxnRCNUBtSKif NZsKu9NDZCCupENLH9cPR3uR7jMmJw4= X-Stat-Signature: ptdh3o5aqq4gnrc8oiup7ybbxx3ghes1 X-Rspamd-Queue-Id: 5A628180083 Authentication-Results: imf16.hostedemail.com; dkim=none; spf=pass (imf16.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com X-Rspamd-Server: rspam07 X-Rspam-User: X-HE-Tag: 1655173240-957257 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 6/13/22 15:01, kernel test robot wrote: > Hi Anshuman, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on akpm-mm/mm-everything] > > url: https://github.com/intel-lab-lkp/linux/commits/Anshuman-Khandual/mm-mmap-Drop-__SXXX-__PXXX-macros-from-across-platforms/20220613-133456 > base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything > config: riscv-randconfig-r042-20220613 (https://download.01.org/0day-ci/archive/20220613/202206131716.tDWk9rLs-lkp@intel.com/config) > compiler: riscv64-linux-gcc (GCC) 11.3.0 > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # https://github.com/intel-lab-lkp/linux/commit/696f81b49f7b6316f652d795da4c0008efef4487 > git remote add linux-review https://github.com/intel-lab-lkp/linux > git fetch --no-tags linux-review Anshuman-Khandual/mm-mmap-Drop-__SXXX-__PXXX-macros-from-across-platforms/20220613-133456 > git checkout 696f81b49f7b6316f652d795da4c0008efef4487 > # save the config file > mkdir build_dir && cp config build_dir/.config > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash arch/riscv/mm/ > > If you fix the issue, kindly add following tag where applicable > Reported-by: kernel test robot > > All errors (new ones prefixed by >>): > >>> arch/riscv/mm/init.c:1224:59: error: 'PAGE_NONE' undeclared here (not in a function); did you mean 'SIGEV_NONE'? > 1224 | [VM_NONE] = PAGE_NONE, > | ^~~~~~~~~ > | SIGEV_NONE >>> arch/riscv/mm/init.c:1225:59: error: 'PAGE_READ' undeclared here (not in a function); did you mean 'MAY_READ'? > 1225 | [VM_READ] = PAGE_READ, > | ^~~~~~~~~ > | MAY_READ >>> arch/riscv/mm/init.c:1226:59: error: 'PAGE_COPY' undeclared here (not in a function) > 1226 | [VM_WRITE] = PAGE_COPY, > | ^~~~~~~~~ >>> arch/riscv/mm/init.c:1228:59: error: 'PAGE_EXEC' undeclared here (not in a function); did you mean 'TASK_EXEC'? > 1228 | [VM_EXEC] = PAGE_EXEC, > | ^~~~~~~~~ > | TASK_EXEC >>> arch/riscv/mm/init.c:1229:59: error: 'PAGE_READ_EXEC' undeclared here (not in a function); did you mean 'PAGE_KERNEL_EXEC'? > 1229 | [VM_EXEC | VM_READ] = PAGE_READ_EXEC, > | ^~~~~~~~~~~~~~ > | PAGE_KERNEL_EXEC >>> arch/riscv/mm/init.c:1230:59: error: 'PAGE_COPY_EXEC' undeclared here (not in a function); did you mean 'PAGE_KERNEL_EXEC'? > 1230 | [VM_EXEC | VM_WRITE] = PAGE_COPY_EXEC, > | ^~~~~~~~~~~~~~ > | PAGE_KERNEL_EXEC >>> arch/riscv/mm/init.c:1231:59: error: 'PAGE_COPY_READ_EXEC' undeclared here (not in a function) > 1231 | [VM_EXEC | VM_WRITE | VM_READ] = PAGE_COPY_READ_EXEC, > | ^~~~~~~~~~~~~~~~~~~ >>> arch/riscv/mm/init.c:1238:59: error: 'PAGE_SHARED_EXEC' undeclared here (not in a function); did you mean 'PAGE_SHARED'? > 1238 | [VM_SHARED | VM_EXEC | VM_WRITE] = PAGE_SHARED_EXEC, > | ^~~~~~~~~~~~~~~~ > | PAGE_SHARED > > > vim +1224 arch/riscv/mm/init.c > > 1222 > 1223 pgprot_t protection_map[16] __ro_after_init = { >> 1224 [VM_NONE] = PAGE_NONE, >> 1225 [VM_READ] = PAGE_READ, >> 1226 [VM_WRITE] = PAGE_COPY, > 1227 [VM_WRITE | VM_READ] = PAGE_COPY, >> 1228 [VM_EXEC] = PAGE_EXEC, >> 1229 [VM_EXEC | VM_READ] = PAGE_READ_EXEC, >> 1230 [VM_EXEC | VM_WRITE] = PAGE_COPY_EXEC, >> 1231 [VM_EXEC | VM_WRITE | VM_READ] = PAGE_COPY_READ_EXEC, > 1232 [VM_SHARED] = PAGE_NONE, > 1233 [VM_SHARED | VM_READ] = PAGE_READ, > 1234 [VM_SHARED | VM_WRITE] = PAGE_SHARED, > 1235 [VM_SHARED | VM_WRITE | VM_READ] = PAGE_SHARED, > 1236 [VM_SHARED | VM_EXEC] = PAGE_EXEC, > 1237 [VM_SHARED | VM_EXEC | VM_READ] = PAGE_READ_EXEC, >> 1238 [VM_SHARED | VM_EXEC | VM_WRITE] = PAGE_SHARED_EXEC, > PAGE_XXXX[_YYYY] symbols on riscv are wrapped around with CONFIG_MMU, just moving protection_map[] to appropriate place with CONFIG_MMU assert solves this build problem. diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c index 5e4ed43f0d79..84ee476ba4a4 100644 --- a/arch/riscv/mm/init.c +++ b/arch/riscv/mm/init.c @@ -288,6 +288,25 @@ static pmd_t __maybe_unused early_dtb_pmd[PTRS_PER_PMD] __initdata __aligned(PAG #define early_pg_dir ((pgd_t *)XIP_FIXUP(early_pg_dir)) #endif /* CONFIG_XIP_KERNEL */ +pgprot_t protection_map[16] __ro_after_init = { + [VM_NONE] = PAGE_NONE, + [VM_READ] = PAGE_READ, + [VM_WRITE] = PAGE_COPY, + [VM_WRITE | VM_READ] = PAGE_COPY, + [VM_EXEC] = PAGE_EXEC, + [VM_EXEC | VM_READ] = PAGE_READ_EXEC, + [VM_EXEC | VM_WRITE] = PAGE_COPY_EXEC, + [VM_EXEC | VM_WRITE | VM_READ] = PAGE_COPY_READ_EXEC, + [VM_SHARED] = PAGE_NONE, + [VM_SHARED | VM_READ] = PAGE_READ, + [VM_SHARED | VM_WRITE] = PAGE_SHARED, + [VM_SHARED | VM_WRITE | VM_READ] = PAGE_SHARED, + [VM_SHARED | VM_EXEC] = PAGE_EXEC, + [VM_SHARED | VM_EXEC | VM_READ] = PAGE_READ_EXEC, + [VM_SHARED | VM_EXEC | VM_WRITE] = PAGE_SHARED_EXEC, + [VM_SHARED | VM_EXEC | VM_WRITE | VM_READ] = PAGE_SHARED_EXEC +}; + void __set_fixmap(enum fixed_addresses idx, phys_addr_t phys, pgprot_t prot) { unsigned long addr = __fix_to_virt(idx); @@ -1219,22 +1238,3 @@ int __meminit vmemmap_populate(unsigned long start, unsigned long end, int node, return vmemmap_populate_basepages(start, end, node, NULL); } #endif - -pgprot_t protection_map[16] __ro_after_init = { - [VM_NONE] = PAGE_NONE, - [VM_READ] = PAGE_READ, - [VM_WRITE] = PAGE_COPY, - [VM_WRITE | VM_READ] = PAGE_COPY, - [VM_EXEC] = PAGE_EXEC, - [VM_EXEC | VM_READ] = PAGE_READ_EXEC, - [VM_EXEC | VM_WRITE] = PAGE_COPY_EXEC, - [VM_EXEC | VM_WRITE | VM_READ] = PAGE_COPY_READ_EXEC, - [VM_SHARED] = PAGE_NONE, - [VM_SHARED | VM_READ] = PAGE_READ, - [VM_SHARED | VM_WRITE] = PAGE_SHARED, - [VM_SHARED | VM_WRITE | VM_READ] = PAGE_SHARED, - [VM_SHARED | VM_EXEC] = PAGE_EXEC, - [VM_SHARED | VM_EXEC | VM_READ] = PAGE_READ_EXEC, - [VM_SHARED | VM_EXEC | VM_WRITE] = PAGE_SHARED_EXEC, - [VM_SHARED | VM_EXEC | VM_WRITE | VM_READ] = PAGE_SHARED_EXEC -};