From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FEBDC7115C for ; Wed, 25 Jun 2025 10:00:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BF4C16B00C5; Wed, 25 Jun 2025 06:00:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B84CE6B00C6; Wed, 25 Jun 2025 06:00:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9D04F6B00C7; Wed, 25 Jun 2025 06:00:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 838696B00C5 for ; Wed, 25 Jun 2025 06:00:49 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 3C45FC1BE7 for ; Wed, 25 Jun 2025 10:00:49 +0000 (UTC) X-FDA: 83593479018.12.EFCC6B3 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf25.hostedemail.com (Postfix) with ESMTP id 8DB53A000E for ; Wed, 25 Jun 2025 10:00:46 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=RUVdhZZf; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750845646; a=rsa-sha256; cv=none; b=UVNfMiOZj1W7Ix8X0sFHjgW2NleWLmH8WDKr0FQINsJuGn9oDu6qEfAun8n9xzYtEGVL0Q A0yHnYCBNzS5uleyS29bVriawBoNoJ7XBl3X7my29QLEPT1miSkTgdlg/KZ+UTy6Vq7VCj bLnmJ6kTr5v3JqdjlW3JCSCPClbjcv8= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=RUVdhZZf; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750845646; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Z6x25AG0NKTqt1lkb9Vl1FBFG/qqID/tFbHdX57Nvh8=; b=pLau6zyaDcfzXdVPnzcAduMquhrUAZh5EQBCu1Xkye7mDCzJ+hKBLOVgWCEssQu09gaE4o l6Y6UrxufCAsTqWsi8rJhtwbCM+hrwOA0fC2mGptcTp1AGJyfKsyXChFzYte1yp8SjXmWT GV09Sb9QSk9j8xlkvDNFEXEkxq0CVs0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750845646; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Z6x25AG0NKTqt1lkb9Vl1FBFG/qqID/tFbHdX57Nvh8=; b=RUVdhZZfZ9O0WLNHipR5gJ2xxgZKoruwiOq3yMUJimcHLf4HPldioD7J7srnXbV7zS3+06 TV5F4z5YOf8bgsMkEzLDwPh7icJfEpO561Z236k6NoE5b7Ptw0yHLAHbv5u+xW4Eef4hb9 JKgJWQ5YSzJfFZev5vcOBo/K1FPj5v8= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-277-MLfwYmCvMJqFEiJ_oXIMkA-1; Wed, 25 Jun 2025 06:00:44 -0400 X-MC-Unique: MLfwYmCvMJqFEiJ_oXIMkA-1 X-Mimecast-MFC-AGG-ID: MLfwYmCvMJqFEiJ_oXIMkA_1750845643 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4535ad64d30so50459565e9.3 for ; Wed, 25 Jun 2025 03:00:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750845643; x=1751450443; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=Z6x25AG0NKTqt1lkb9Vl1FBFG/qqID/tFbHdX57Nvh8=; b=bstylPPfiaa6p+5oIin1PwiuypPFAxi1fP0YGlzf9jWYJF3hOjWr44AtjnyO7E56Qi EzIjKK+HfMDvLWglpNfPvaitRaq+z9BxEwPM0ASTBJ2kOcHsQ03OyR+11l9SZc6fOPGB 4g3HTX7ZxrYalEto7Z4p+C1cUHmywG678KwOYrsQ9i4E5di2iZlAvLeSo+TWu2aVdX2A aPbmf0FrhAruewUK2Yd+rbn+8iO7txjX/YtjzvWY8Eq9MA66MigQb9br5JOMS6fZXs+t +5fAuvYoKuthS3HhrT99M5+GsMtMm4OMgqqUqHwcWMoJZsgCl0ffkMEusun4/MVtDRuy Qq4A== X-Forwarded-Encrypted: i=1; AJvYcCWRriAoYULd1XZEVC5XlWPYqFk04XI7adR+5yAqAm7+4ChdRKIs2gAGmV+2QmLhmO42SyhsS1J7kw==@kvack.org X-Gm-Message-State: AOJu0YxRua+yxAFuG9PjNHXTC8PXncjXEU7uwnFUsRdFRY/SmZ0cf3zN ePw6tP3YeYQcJSKylgLN2cmQ1TBviCoB4KbOYEwnNrANy8QiNO4oyo2SSyyc5HNXTD5fN3/CRms q8gdC/H53CBcXQioli2C8eiJnA2Ht3J7wkZxCyZNn9RW72ZXBLtE6 X-Gm-Gg: ASbGncuV4K1UuVbo1T7LW2hTqxslAsEYDyciQuVYjjJAppKMNNip++5eZDzwMPCeg37 9YUinNWvxb2PBqj6Y2kLa/EwMcJyJyUIgU9/LkRjTGsO0Acm16guj00IVW5rNgcXOazdPwU8O1X cGQcnTp8aHagv/zIkV3jEVBUgDjSjp9Lyn2P3ykS+cjEHIhrIkUCrIfSF1D9kGTJNdhC83QekgH ssdgvt1SEH0W0fsQEvAO3rzA8iGAaaY0hIb/rKCAb1BJdfasN4D68WPjhgim9XwqY+DoA3K55fM HteJjg/cqOc93UVetnfgzzLof+Iulb+dh99zPZlZAxk0sDAeNVq2D+CUkqQc721U9fy3Sgb3dQt tai6IcnmHPgtIPis2pbevDYxK1PFOU2sVaUFVB69LV5nQ X-Received: by 2002:a05:600c:34d5:b0:442:f97b:87e with SMTP id 5b1f17b1804b1-45381aa54a4mr19589825e9.6.1750845643111; Wed, 25 Jun 2025 03:00:43 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGbFu+V0sZ3EiTRGRhEf4Kgy4D0bfZ6Q+UXw5h7nqUWzo/Aj45oYcdj8mNtUHNPs1PdualaTw== X-Received: by 2002:a05:600c:34d5:b0:442:f97b:87e with SMTP id 5b1f17b1804b1-45381aa54a4mr19589155e9.6.1750845642504; Wed, 25 Jun 2025 03:00:42 -0700 (PDT) Received: from ?IPV6:2003:d8:2f12:1b00:5d6b:db26:e2b7:12? (p200300d82f121b005d6bdb26e2b70012.dip0.t-ipconnect.de. [2003:d8:2f12:1b00:5d6b:db26:e2b7:12]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45382366f88sm14780565e9.30.2025.06.25.03.00.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Jun 2025 03:00:40 -0700 (PDT) Message-ID: <27d174e0-c209-4851-825a-0baeb56df86f@redhat.com> Date: Wed, 25 Jun 2025 12:00:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 3/4] mm: Support batched unmap for lazyfree large folios during reclamation To: Lance Yang Cc: 21cnbao@gmail.com, akpm@linux-foundation.org, baolin.wang@linux.alibaba.com, chrisl@kernel.org, kasong@tencent.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, lorenzo.stoakes@oracle.com, ryan.roberts@arm.com, v-songbaohua@oppo.com, x86@kernel.org, ying.huang@intel.com, zhengtangquan@oppo.com References: <2c19a6cf-0b42-477b-a672-ed8c1edd4267@redhat.com> <20250624162503.78957-1-ioworker0@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250624162503.78957-1-ioworker0@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: cqa7D4crUgX0LOIXaL5ZIHmmgsThunP5YOD6EzB8z4Y_1750845643 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 8DB53A000E X-Rspamd-Server: rspam10 X-Stat-Signature: 595kuuufigk8ui1ztsx84131if3nzh58 X-HE-Tag: 1750845646-113453 X-HE-Meta: U2FsdGVkX188kmcbohK6pNeU8xRjTHKU7GSf67VRQa0oxHUpeGalwLiY6BmjfB0N1ZqyarfJskj84s9iW8VPjRKXMZLbsBwknyDyWYNjgdchnUy9ZH0tLnyXQVg7AxBF6kLGZndE50BTerds9QVPQuTXzrhgUcgmjyn89x7OhUxFDp7Ifn45K2IHOrUZBM5f5eZPEnjkS+G6HyeCD4WZCUjCzMrrtpCdgKglEur7VPFQ+SFW2IO2QHuVsChAOtSAs0K/hC/zEx96GTltshqnGisc5frPP13Zhy8jA++N5ERAQPcZyMN8COz09XuIs5K9LrB6zEfXNoRU3B8g4iuO2E89fkpa8nSk0HPyJu00keTkIBykCTJll06OLEnhFZDXaH9d9g+OC5DfDLD5RSeWa+8k2H+ns5nTCAtn8TBIuB59jX1a9iRitfYAXCMGTeGGPXnlohrhB8wpSff9s/Q76Z+zBNhR3leWldR0LMLDp9+9byLazCO088wt3m4AcIx2Wk4i1HEIqLHSDSklMMp+br3DIiRTSBxX60vppFWiV2y+gDiynBO2+WJntFCsZZjgMLZEVr4dtt64WyvdV5DSKNqKaN5vsolYUAximwz113q/6e1yW2aWoLau3+IG+xAdVXNAuMk5OHeKxqgJP5QDKEEwyvZmuswhrzu4WUjiY1BMHFXSf8TN8jw8LD29hfgAiAQryio5nDkcY0L3BtFX4LyzlQvgYWXFgfPPDtd1JVvCxoGpcMzHOk/ybd4uvpqbQn/2Q46o+uEFNZ4rfzSein6yPYdtw7S5s0Vak9/w1NeeC4KYPABCr23cYnlxcwfs/TKwnSW2zwCya9hsBYeuLIdWNXiRa9B3gf5EEDEcSOicy3FisNjH+dYEABe5mgzSGNqrsZh0K0BdSgCpI6BiAhgjrkLvLP+vNqcgskSq/9l36IgZTTjavRh0nvPWXBy3TzxwIsweiReah2/HRRP bFMRolte noyFzZLhomq6aMLABMaL3ckMuuZOxIMcHdKu/gqJsawkpru6C9pFQxJFVTzVx/UWkFtmZkIr0x5wxnGV1dAOH+SSkz2mJ05IG8oQEIehVXpsMEA2q3ts6uemo2ke7E4kdDSrmTq89/qifgfJRgRx0/3PgR+25Ol0I2e6O/iMdKJHwg6evrVRG0Ey/+gW8XvoJy+7DyEOtF1caySpBKEiVS6b6QcjMjYQhY+WJq3xABNPaoQQ/QTQZG8WOiVELw4xguDXHUJ2F0zM5X2ImLb6SonxQysDZv8IyRIFKexRmx1+IQc49wxj/YFHkyWUVAslbuhckvtt7k52BC6m3/A0ojxZ6Np1YpWBaja9XXCYHbJJRR4nkKNWRM8CQdeCn23rP+Cy2mx5tJUkO8086G96N682fAqaS+ypZl9f1vLZfbcdcU9zyv3PfIFjSfQE4/VFNB1jIFEIPWKRy7t8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 24.06.25 18:25, Lance Yang wrote: > On 2025/6/24 23:34, David Hildenbrand wrote: >> On 24.06.25 17:26, Lance Yang wrote: >>> On 2025/6/24 20:55, David Hildenbrand wrote: >>>> On 14.02.25 10:30, Barry Song wrote: >>>>> From: Barry Song >>> [...] >>>>> diff --git a/mm/rmap.c b/mm/rmap.c >>>>> index 89e51a7a9509..8786704bd466 100644 >>>>> --- a/mm/rmap.c >>>>> +++ b/mm/rmap.c >>>>> @@ -1781,6 +1781,25 @@ void folio_remove_rmap_pud(struct folio *folio, >>>>> struct page *page, >>>>> #endif >>>>> } >>>>> +/* We support batch unmapping of PTEs for lazyfree large folios */ >>>>> +static inline bool can_batch_unmap_folio_ptes(unsigned long addr, >>>>> + struct folio *folio, pte_t *ptep) >>>>> +{ >>>>> + const fpb_t fpb_flags = FPB_IGNORE_DIRTY | FPB_IGNORE_SOFT_DIRTY; >>>>> + int max_nr = folio_nr_pages(folio); >>>> >>>> Let's assume we have the first page of a folio mapped at the last page >>>> table entry in our page table. >>> >>> Good point. I'm curious if it is something we've seen in practice ;) >> >> I challenge you to write a reproducer :P I assume it might be doable >> through simple mremap(). >> >>> >>>> >>>> What prevents folio_pte_batch() from reading outside the page table? >>> >>> Assuming such a scenario is possible, to prevent any chance of an >>> out-of-bounds read, how about this change: >>> >>> diff --git a/mm/rmap.c b/mm/rmap.c >>> index fb63d9256f09..9aeae811a38b 100644 >>> --- a/mm/rmap.c >>> +++ b/mm/rmap.c >>> @@ -1852,6 +1852,25 @@ static inline bool >>> can_batch_unmap_folio_ptes(unsigned long addr, >>> const fpb_t fpb_flags = FPB_IGNORE_DIRTY | FPB_IGNORE_SOFT_DIRTY; >>> int max_nr = folio_nr_pages(folio); >>> pte_t pte = ptep_get(ptep); >>> + unsigned long end_addr; >>> + >>> + /* >>> + * To batch unmap, the entire folio's PTEs must be contiguous >>> + * and mapped within the same PTE page table, which corresponds to >>> + * a single PMD entry. Before calling folio_pte_batch(), which does >>> + * not perform boundary checks itself, we must verify that the >>> + * address range covered by the folio does not cross a PMD boundary. >>> + */ >>> + end_addr = addr + (max_nr * PAGE_SIZE) - 1; >>> + >>> + /* >>> + * A fast way to check for a PMD boundary cross is to align both >>> + * the start and end addresses to the PMD boundary and see if they >>> + * are different. If they are, the range spans across at least two >>> + * different PMD-managed regions. >>> + */ >>> + if ((addr & PMD_MASK) != (end_addr & PMD_MASK)) >>> + return false; >> >> You should not be messing with max_nr = folio_nr_pages(folio) here at >> all. folio_pte_batch() takes care of that. >> >> Also, way too many comments ;) >> >> You may only batch within a single VMA and within a single page table. >> >> So simply align the addr up to the next PMD, and make sure it does not >> exceed the vma end. >> >> ALIGN and friends can help avoiding excessive comments. > > Thanks! How about this updated version based on your suggestion: > > diff --git a/mm/rmap.c b/mm/rmap.c > index fb63d9256f09..241d55a92a47 100644 > --- a/mm/rmap.c > +++ b/mm/rmap.c > @@ -1847,12 +1847,25 @@ void folio_remove_rmap_pud(struct folio *folio, struct page *page, > > /* We support batch unmapping of PTEs for lazyfree large folios */ > static inline bool can_batch_unmap_folio_ptes(unsigned long addr, > - struct folio *folio, pte_t *ptep) > + struct folio *folio, pte_t *ptep, > + struct vm_area_struct *vma) > { > const fpb_t fpb_flags = FPB_IGNORE_DIRTY | FPB_IGNORE_SOFT_DIRTY; > + unsigned long next_pmd, vma_end, end_addr; > int max_nr = folio_nr_pages(folio); > pte_t pte = ptep_get(ptep); > > + /* > + * Limit the batch scan within a single VMA and within a single > + * page table. > + */ > + vma_end = vma->vm_end; > + next_pmd = ALIGN(addr + 1, PMD_SIZE); > + end_addr = addr + (unsigned long)max_nr * PAGE_SIZE; > + > + if (end_addr > min(next_pmd, vma_end)) > + return false; May I suggest that we clean all that up as we fix it? Maybe something like this: diff --git a/mm/rmap.c b/mm/rmap.c index 3b74bb19c11dd..11fbddc6ad8d6 100644 --- a/mm/rmap.c +++ b/mm/rmap.c @@ -1845,23 +1845,38 @@ void folio_remove_rmap_pud(struct folio *folio, struct page *page, #endif } -/* We support batch unmapping of PTEs for lazyfree large folios */ -static inline bool can_batch_unmap_folio_ptes(unsigned long addr, - struct folio *folio, pte_t *ptep) +static inline unsigned int folio_unmap_pte_batch(struct folio *folio, + struct page_vma_mapped_walk *pvmw, enum ttu_flags flags, + pte_t pte) { const fpb_t fpb_flags = FPB_IGNORE_DIRTY | FPB_IGNORE_SOFT_DIRTY; - int max_nr = folio_nr_pages(folio); - pte_t pte = ptep_get(ptep); + struct vm_area_struct *vma = pvmw->vma; + unsigned long end_addr, addr = pvmw->address; + unsigned int max_nr; + + if (flags & TTU_HWPOISON) + return 1; + if (!folio_test_large(folio)) + return 1; + + /* We may only batch within a single VMA and a single page table. */ + end_addr = min_t(unsigned long, ALIGN(addr + 1, PMD_SIZE), vma->vm_end); + max_nr = (end_addr - addr) >> PAGE_SHIFT; + /* We only support lazyfree batching for now ... */ if (!folio_test_anon(folio) || folio_test_swapbacked(folio)) - return false; + return 1; if (pte_unused(pte)) - return false; - if (pte_pfn(pte) != folio_pfn(folio)) - return false; + return 1; + /* ... where we must be able to batch the whole folio. */ + if (pte_pfn(pte) != folio_pfn(folio) || max_nr != folio_nr_pages(folio)) + return 1; + max_nr = folio_pte_batch(folio, addr, pvmw->pte, pte, max_nr, fpb_flags, + NULL, NULL, NULL); - return folio_pte_batch(folio, addr, ptep, pte, max_nr, fpb_flags, NULL, - NULL, NULL) == max_nr; + if (max_nr != folio_nr_pages(folio)) + return 1; + return max_nr; } /* @@ -2024,9 +2039,7 @@ static bool try_to_unmap_one(struct folio *folio, struct vm_area_struct *vma, if (pte_dirty(pteval)) folio_mark_dirty(folio); } else if (likely(pte_present(pteval))) { - if (folio_test_large(folio) && !(flags & TTU_HWPOISON) && - can_batch_unmap_folio_ptes(address, folio, pvmw.pte)) - nr_pages = folio_nr_pages(folio); + nr_pages = folio_unmap_pte_batch(folio, &pvmw, flags, pteval); end_addr = address + nr_pages * PAGE_SIZE; flush_cache_range(vma, address, end_addr); Note that I don't quite understand why we have to batch the whole thing or fallback to individual pages. Why can't we perform other batches that span only some PTEs? What's special about 1 PTE vs. 2 PTEs vs. all PTEs? Can someone enlighten me why that is required? -- Cheers, David / dhildenb